[Bug 19349] Fix relayer object to numbered layer

peter-b · web-flow · commit 1132c8734f31 · 2017-03-15T15:33:39.000Z
In livecode#5026, the relayering logic was modified to fix a possible memory leak. Unfortunately the list iteration was implemented incorrectly, so relayering didn't work if the target object for relayering wasn't the top object in the card. Coverity-ID: 16369
diff --git a/engine/src/card.cpp b/engine/src/card.cpp
@@ -1778,6 +1778,7 @@ Exec_stat MCCard::relayer(MCControl *optr, uint2 newlayer)
                     }
                     break;
                 }
+                t_insert_iter = t_insert_iter->next();
             }
             while (t_insert_iter != objptrs);
         }

Original file line number	Diff line number	Diff line change
`@@ -1778,6 +1778,7 @@ Exec_stat MCCard::relayer(MCControl *optr, uint2 newlayer)`
`1778`	`1778`	`}`
`1779`	`1779`	`break;`
`1780`	`1780`	`}`
	`1781`	`+ t_insert_iter = t_insert_iter->next();`
`1781`	`1782`	`}`
`1782`	`1783`	`while (t_insert_iter != objptrs);`
`1783`	`1784`	`}`