[CID 16206] MCKill::lookup(): Remove incorrect semicolon.

peter-b · peter-b · commit 7d457f8394ea · 2015-01-28T12:25:09.000Z
The semicolon caused the line:

    return signal_table[size].which

to fall out of the `while` looping, causing a possible buffer overrun
due to unsigned arithmetic underflow.

Coverity-ID: 16206
Coverity-ID: 16963
diff --git a/engine/src/cmdsf.cpp b/engine/src/cmdsf.cpp
@@ -2806,7 +2806,7 @@ int4 MCKill::lookup(MCStringRef s)
 {
 	uint2 size = ELEMENTS(signal_table);
 	while(size--)
-		if (MCStringIsEqualToCString(s, signal_table[size].token, kMCCompareCaseless));
+		if (MCStringIsEqualToCString(s, signal_table[size].token, kMCCompareCaseless))
 			return signal_table[size].which;
 	return SIGTERM;
 }

Original file line number	Diff line number	Diff line change
`@@ -2806,7 +2806,7 @@ int4 MCKill::lookup(MCStringRef s)`
`2806`	`2806`	`{`
`2807`	`2807`	`uint2 size = ELEMENTS(signal_table);`
`2808`	`2808`	`while(size--)`
`2809`		`- if (MCStringIsEqualToCString(s, signal_table[size].token, kMCCompareCaseless));`
	`2809`	`+ if (MCStringIsEqualToCString(s, signal_table[size].token, kMCCompareCaseless))`
`2810`	`2810`	`return signal_table[size].which;`
`2811`	`2811`	`return SIGTERM;`
`2812`	`2812`	`}`