[[ Cleanup ]] Fix maybe-uninitialized warnings in release build

montegoulding · montegoulding · commit 8549c039e518 · 2018-03-07T17:11:29.000+11:00
diff --git a/engine/src/exec-engine.cpp b/engine/src/exec-engine.cpp
@@ -1192,7 +1192,7 @@ static void MCEngineSplitScriptIntoMessageAndParameters(MCExecContext& ctxt, MCS
     t_offset++;
     
 	MCerrorlock++;
-    unichar_t t_char;
+    unichar_t t_char = '\0';
     uindex_t t_start_offset;
     t_start_offset = t_offset;
     
diff --git a/engine/src/exec-extension.cpp b/engine/src/exec-extension.cpp
@@ -124,7 +124,10 @@ bool MCEngineAddExtensionFromModule(MCScriptModuleRef p_module)
     }
     
     MCLoadedExtension *t_ext;
-    /* UNCHECKED */ MCMemoryNew(t_ext);
+    if (!MCMemoryNew(t_ext))
+    {
+      return false;
+    }
     
     t_ext -> module_name = MCValueRetain(MCScriptGetNameOfModule(p_module));
     t_ext -> module = MCScriptRetainModule(p_module);
diff --git a/engine/src/exec-files.cpp b/engine/src/exec-files.cpp
@@ -1546,7 +1546,7 @@ void MCFilesExecPerformReadUnicodeFor(MCExecContext& ctxt, IO_handle p_stream, i
 
     while (t_progress < p_count)
     {
-        uint4 t_new_boundary;
+        uint4 t_new_boundary = 0;
         // SN-2014-06-18 [[ Bug 12538 ]] Read from process until empty
         // We need to allow a reading to return nothing, without being stuck in a waiting loop for data
         if (!MCFilesExecPerformReadChunk(ctxt, p_index, p_encoding, false, p_unit_type, t_last_char_boundary, t_duration, p_stream, *t_output, t_new_boundary,t_stat))
@@ -1606,7 +1606,7 @@ void MCFilesExecPerformReadTextUntil(MCExecContext& ctxt, IO_handle p_stream, in
 
     while (p_count)
     {
-        uint4 t_new_char_boundary;
+        uint4 t_new_char_boundary = 0;
         if (!MCFilesExecPerformReadChunk(ctxt, p_index, p_encoding, t_empty_allowed, FU_CODEPOINT, t_last_char_boundary, t_duration, p_stream, *t_output, t_new_char_boundary, t_stat))
             // error occurred while reading a codepoint
             break;
diff --git a/engine/src/exec-filters.cpp b/engine/src/exec-filters.cpp
@@ -842,8 +842,10 @@ void MCFiltersEvalBinaryEncode(MCExecContext& ctxt, MCStringRef p_format, MCValu
                 MCAutoStringRefAsNativeChars t_auto_native;
                 const char_t* t_native;
                 uindex_t t_length;
-                /* UNCHECKED */ t_auto_native . Lock(*t_string, t_native, t_length);
-
+                t_success = t_auto_native . Lock(*t_string, t_native, t_length);
+								if (!t_success)
+									break;
+									
 				switch (cmd)
 				{
 				case 'a':
diff --git a/engine/src/exec-interface-field-chunk.cpp b/engine/src/exec-interface-field-chunk.cpp
@@ -557,6 +557,7 @@ template<typename T> void GetParagraphPropOfCharChunk(MCExecContext& ctxt, MCFie
     do
     {
         typename T::stack_type t_new_value;
+        T::init(t_new_value);
         T::getter(ctxt, sptr, p_getter, t_new_value);
         if (ctxt . HasError())
             return;
diff --git a/engine/src/exec-interface2.cpp b/engine/src/exec-interface2.cpp
@@ -1227,7 +1227,7 @@ void MCInterfaceGetCursor(MCExecContext& ctxt, uinteger_t*& r_value)
 
 void MCInterfaceSetCursor(MCExecContext& ctxt, uinteger_t* p_value)
 {
-	MCCursorRef t_cursor;
+	MCCursorRef t_cursor = nullptr;
 
     uinteger_t t_cursor_id;
     if (p_value == NULL)
@@ -1255,7 +1255,7 @@ void MCInterfaceGetDefaultCursor(MCExecContext& ctxt, uinteger_t& r_value)
 
 void MCInterfaceSetDefaultCursor(MCExecContext& ctxt, uinteger_t p_value)
 {
-	MCCursorRef t_cursor;
+	MCCursorRef t_cursor = nullptr;
 	MCInterfaceSetCursor(ctxt, p_value, true, t_cursor);
 	
     // PM-2015-06-17: [[ Bug 15200 ]] Default cursor should reset when set to empty, thus t_cursor *can* be nil
diff --git a/engine/src/exec-strings.cpp b/engine/src/exec-strings.cpp
@@ -1045,8 +1045,12 @@ void MCStringsEvalFormat(MCExecContext& ctxt, MCStringRef p_format, MCValueRef*
             uindex_t t_cformat_length;
             const char_t* t_cstart;
 
-            /* UNCHECKED */ MCStringCreateWithChars(t_unicode_start, format - t_start, &t_substring);
-            /* UNCHECKED */ t_auto_native . Lock(*t_substring, t_native_format, t_cformat_length);
+            if (!MCStringCreateWithChars(t_unicode_start, format - t_start, &t_substring) ||
+            			!t_auto_native . Lock(*t_substring, t_native_format, t_cformat_length))
+						{
+							ctxt.LegacyThrow(EE_NO_MEMORY);
+							return;
+						}
             t_cstart = t_native_format;
 
             char newFormat[40];
diff --git a/engine/src/exec.cpp b/engine/src/exec.cpp
@@ -3132,7 +3132,7 @@ void MCExecStoreProperty(MCExecContext& ctxt, const MCPropertyInfo *prop, void *
         {
             MCAutoStringRef t_input;
             MCPoint *t_value;
-            uindex_t t_count;
+            uindex_t t_count = 0;
         
             MCExecTypeConvertAndReleaseAlways(ctxt, p_value . type, &p_value, kMCExecValueTypeStringRef, &(&t_input));
             
diff --git a/engine/src/itransform.cpp b/engine/src/itransform.cpp
@@ -116,9 +116,11 @@ static void resize_seq_32_32(	const uint1* const src_data, const int src_n, cons
 	const real8 k = (real8)(src_n-1) / dst_n;
 	const real8 _1_k = 1.0 / k;
 
-	real8 v1, v2;     // current value, next value
+	real8 v1 = 0.0;          // current value,
+  real8 v2 = 0.0;          // next value
 	real8 a, b, c, d; // polynom coefs
-	real8 t;          // polynom argument
+  a = b = c = d = 0.0;
+	real8 t = 0.0;          // polynom argument
 
 	curs = src_data, curd = dst_data;
 
diff --git a/engine/src/lnxdc.cpp b/engine/src/lnxdc.cpp
@@ -325,7 +325,10 @@ bool MCScreenDC::device_getdisplays(bool p_effective, MCDisplay * &r_displays, u
     
     // Allocate the list of monitors
     MCDisplay *t_displays;
-    MCMemoryNewArray(t_monitor_count, t_displays);
+    if (!MCMemoryNewArray(t_monitor_count, t_displays))
+		{
+			  return false;
+		}
     
     // Get the geometry of each monitor
     for (gint i = 0; i < t_monitor_count; i++)
diff --git a/engine/src/lnxdcs.cpp b/engine/src/lnxdcs.cpp
@@ -373,7 +373,11 @@ Boolean MCScreenDC::open()
                     cmap = gdk_colormap_new(vis, TRUE);
                     setupcolors();
                     GdkColor *t_colors;
-                    /* UNCHECKED */ MCMemoryNewArray(ncolors, t_colors);
+                    if (!MCMemoryNewArray(ncolors, t_colors))
+                    {
+                      return False;
+                    }
+                    
                     for (int i = 0 ; i < ncolors ; i++)
                     {
                         colors[i].red = colors[i].green = colors[i].blue = i * MAXUINT2 / ncolors;
diff --git a/engine/src/lnxelevate.cpp b/engine/src/lnxelevate.cpp
@@ -407,7 +407,8 @@ int MCSystemElevatedMain(int argc, char* argv[])
 
 	// Now we can read in the arguments
 	uint32_t t_arg_count;
-	read_uint32_from_fd(fileno(stdin), t_arg_count);
+	if (!read_uint32_from_fd(fileno(stdin), t_arg_count))
+		return -1;
 
 	// The arguments read from the FIFO are encoded in the system encoding
 	char **t_args;
diff --git a/engine/src/lnxflst.cpp b/engine/src/lnxflst.cpp
@@ -406,7 +406,7 @@ bool MCNewFontlist::ctxt_layouttext(const unichar_t *p_chars, uint32_t p_char_co
 		if (t_run == nil)
 			break;
 
-		MCTextLayoutGlyph *t_glyphs;
+		MCTextLayoutGlyph *t_glyphs = nullptr;
 		if (!MCMemoryNewArray(t_run -> glyphs -> num_glyphs, t_glyphs))
 			t_success = false;
         
diff --git a/engine/src/module-canvas.cpp b/engine/src/module-canvas.cpp
@@ -4174,7 +4174,10 @@ void MCCanvasEffectMake(integer_t p_type, MCCanvasEffectRef &r_effect)
 bool MCCanvasEffectThrowPropertyInvalidValueError(MCCanvasEffectProperty p_property, MCValueRef p_value)
 {
 	MCStringRef t_prop_name;
-	MCCanvasEffectPropertyToString(p_property, t_prop_name);
+	if (!MCCanvasEffectPropertyToString(p_property, t_prop_name))
+	{
+		return false;
+	}
 	
 	return MCErrorCreateAndThrow(kMCCanvasEffectPropertyInvalidValueErrorTypeInfo,
 								 "property", t_prop_name,
@@ -4185,9 +4188,16 @@ bool MCCanvasEffectThrowPropertyInvalidValueError(MCCanvasEffectProperty p_prope
 bool MCCanvasEffectThrowPropertyNotAvailableError(MCCanvasEffectProperty p_property, MCCanvasEffectType p_type)
 {
 	MCStringRef t_prop_name;
+	if (!MCCanvasEffectPropertyToString(p_property, t_prop_name))
+	{
+		return false;
+	}
+	
 	MCStringRef t_type_name;
-	MCCanvasEffectPropertyToString(p_property, t_prop_name);
-	MCCanvasEffectTypeToString(p_type, t_type_name);
+	if (!MCCanvasEffectTypeToString(p_type, t_type_name))
+	{
+		return false;
+	}
 	
 	return MCErrorCreateAndThrow(kMCCanvasEffectPropertyNotAvailableErrorTypeInfo,
 								 "property", t_prop_name,
@@ -5442,9 +5452,11 @@ bool MCCanvasApplyGradientPaint(__MCCanvasImpl &x_canvas, MCCanvasGradientRef p_
 		for (uint32_t i = 0; i < t_ramp_length; i++)
 		{
 			MCCanvasGradientStopRef t_stop;
-			/* UNCHECKED */ MCProperListFetchGradientStopAt(t_gradient->ramp, i, t_stop);
-			t_offsets[i] = MCCanvasGradientStopGet(t_stop)->offset;
-			t_colors[i] = MCCanvasColorToMCGColor(MCCanvasGradientStopGet(t_stop)->color);
+			if (MCProperListFetchGradientStopAt(t_gradient->ramp, i, t_stop))
+			{
+					t_offsets[i] = MCCanvasGradientStopGet(t_stop)->offset;
+					t_colors[i] = MCCanvasColorToMCGColor(MCCanvasGradientStopGet(t_stop)->color);
+			}
 		}
 		
 		MCGContextSetFillGradient(x_canvas.context, t_gradient->function, t_offsets, t_colors, t_ramp_length, t_gradient->mirror, t_gradient->wrap, t_gradient->repeats, t_gradient_transform, t_gradient->filter);
@@ -5815,7 +5827,8 @@ MC_DLLEXPORT_DEF
 void MCCanvasDrawImage(MCCanvasImageRef p_image, MCCanvasRectangleRef p_dst_rect, MCCanvasRef p_canvas)
 {
 	MCGRectangle t_src_rect;
-	uint32_t t_width, t_height;
+	uint32_t t_width = 0;
+	uint32_t t_height = 0;
 	MCCanvasImageGetWidth(p_image, t_width);
 	MCCanvasImageGetHeight(p_image, t_height);
 	t_src_rect = MCGRectangleMake(0, 0, t_width, t_height);
@@ -6949,10 +6962,9 @@ bool MCSVGParse(MCStringRef p_string, MCSVGParseCallback p_callback, void *p_con
 	
 	bool t_first_command;
 	t_first_command = true;
+	MCSVGPathCommand t_command;
 	while (!MCRangeIsEmpty(t_range))
 	{
-		MCSVGPathCommand t_command;
-		
 		// First skip any whitespace in the string. After this we know that we should
 		// be expecting a path command, anything else is an error.
 		MCSVGSkipWhitespace(*t_native_string, t_range);
diff --git a/engine/src/object.cpp b/engine/src/object.cpp
@@ -1583,7 +1583,8 @@ Boolean MCObject::getforecolor(uint2 p_di, Boolean rev, Boolean hilite,
         case DI_SHADOW:
             which = P_SHADOW_COLOR;
             break;
-            
+        default:
+            MCUnreachableReturn(False);
     }
     if (o->getthemeselectorsforprop(which, t_control_type, t_control_part, t_control_state, t_theme_prop, t_theme_prop_type))
     {
@@ -4648,8 +4649,11 @@ bool MCObject::intersects(MCObject *p_other, uint32_t p_threshold)
 		
 		// We accumulate the normalized mask a scanline at a time.
 		uint8_t *t_this_scanline, *t_other_scanline;
-		MCMemoryNewArray(t_scanline_width, t_this_scanline);
-		MCMemoryNewArray(t_scanline_width, t_other_scanline);
+		if (!MCMemoryNewArray(t_scanline_width, t_this_scanline) ||
+		    !MCMemoryNewArray(t_scanline_width, t_other_scanline))
+    {
+      return False;
+    }
 				
 		// IM-2013-10-17: [[ FullscreenMode ]] Precompute initial pixel coords & row/column increments
 		MCGFloat t_this_x, t_this_y, t_this_x_inc, t_this_y_inc;
diff --git a/engine/src/objectpropsets.cpp b/engine/src/objectpropsets.cpp
@@ -279,7 +279,7 @@ bool MCObject::clonepropsets(MCObjectPropertySet*& r_new_props) const
 	t_new_props_tail = nil;
 	while(t_set != nil)
 	{
-		MCObjectPropertySet *t_new_set;
+		MCObjectPropertySet *t_new_set = nullptr;
 
 		/* UNCHECKED */ t_set -> clone(t_new_set);
 		if (t_new_props_tail != nil)
@@ -352,7 +352,7 @@ IO_stat MCObject::loadpropsets(IO_handle stream, uint32_t version)
 			if ((stat = IO_read_nameref_new(pname, stream, true)) != IO_NORMAL)
 				return checkloadstat(stat);
 			
-			MCObjectPropertySet *v;
+			MCObjectPropertySet *v = nullptr;
 			/* UNCHECKED */ MCObjectPropertySet::createwithname_nocopy(pname, v);
 			if (p != nil)
 			{
@@ -444,7 +444,7 @@ IO_stat MCObject::loadpropsets_legacy(IO_handle stream)
 			}
 			else
 			{
-				MCObjectPropertySet *v;
+				MCObjectPropertySet *v = nullptr;
 				/* UNCHECKED */ MCObjectPropertySet::createwithname_nocopy(pname, v);
 				p->setnext(v);
 				p = p->getnext();
@@ -496,7 +496,7 @@ IO_stat MCObject::loadarraypropsets_legacy(MCObjectInputStream& p_stream)
 					continue;
 				}
 
-				MCObjectPropertySet *t_new_prop;
+				MCObjectPropertySet *t_new_prop = nullptr;
 				/* UNCHEKED */ MCObjectPropertySet::createwithname(kMCEmptyName, t_new_prop);
 				t_prop -> setnext(t_new_prop);
 
diff --git a/engine/src/paragraf.cpp b/engine/src/paragraf.cpp
@@ -974,7 +974,7 @@ bool MCParagraph::layout(bool p_force, bool p_check_redraw)
 	if (!needs_layout && !p_force)
 		return false;
 
-    uindex_t t_count;
+    uindex_t t_count = 0;
     if (p_check_redraw)
         t_count = countlines();
     
diff --git a/engine/src/rtf.cpp b/engine/src/rtf.cpp
@@ -881,7 +881,7 @@ RTFStatus RTFReader::ParseDocument(RTFToken p_token, int4 p_value)
 		bool t_turn_off;
 		t_turn_off = t_has_parameter && p_value == 0;
 
-		RTFFontStyle t_mask;
+		RTFFontStyle t_mask = 0;
 		if (t_token == kRTFTokenBold)
 			t_mask = kRTFFontStyleBold;
 		else if (t_token == kRTFTokenItalic)
diff --git a/engine/src/widget-popup.cpp b/engine/src/widget-popup.cpp
@@ -138,7 +138,8 @@ class MCWidgetPopup: public MCStack
 		if (!createwidget(p_kind, p_properties))
 			return false;
 		
-		uint32_t t_width, t_height;
+		uint32_t t_width = 0;
+		uint32_t t_height = 0;
 		getwidgetgeometry(t_width, t_height);
 		
 		if (MCErrorIsPending())
@@ -456,7 +457,7 @@ extern "C" MC_DLLEXPORT_DEF void MCWidgetExecClosePopupWithResult(MCValueRef p_r
     if (!MCWidgetEnsureCurrentWidget())
         return;
 	
-	bool t_is_popup;
+	bool t_is_popup = false;
 	MCWidgetEvalIsPopup(t_is_popup);
 	
 	if (!t_is_popup)
diff --git a/libfoundation/src/foundation-string.cpp b/libfoundation/src/foundation-string.cpp
@@ -222,10 +222,10 @@ MCStringRef MCSTR(const char *p_cstring)
 {
 	MCAssert(nil != p_cstring);
 
-	MCStringRef t_string;
+	MCStringRef t_string = nullptr;
 	/* UNCHECKED */ MCStringCreateWithNativeChars((const char_t *)p_cstring, strlen(p_cstring), t_string);
 	
-	MCValueRef t_unique_string;
+	MCValueRef t_unique_string = nullptr;
 	/* UNCHECKED */ MCValueInter(t_string, t_unique_string);
 	
 	MCValueRelease(t_string);
diff --git a/libfoundation/src/foundation-typeinfo.cpp b/libfoundation/src/foundation-typeinfo.cpp
@@ -181,7 +181,7 @@ bool MCTypeInfoResolve(MCTypeInfoRef self, MCResolvedTypeInfo& r_resolution)
     if (t_ext_typecode == kMCTypeInfoTypeIsNamed)
     {
         // Attempt to resolve the binding, this will throw an error if it fails.
-        MCTypeInfoRef t_next_type;
+        MCTypeInfoRef t_next_type = nullptr;
         if (!MCNamedTypeInfoResolve(self, t_next_type))
             return false;
         
diff --git a/libfoundation/src/foundation-unicode.cpp b/libfoundation/src/foundation-unicode.cpp
@@ -2201,7 +2201,7 @@ bool MCUnicodeWildcardMatch(const void *source_chars, uindex_t source_length, bo
                 // Records whether we have yet seen anything to match within these brackets.
                 bool t_character_found = false;
                 // Store the 'lower limit' if we have a range.
-                codepoint_t t_lower_limit;
+                codepoint_t t_lower_limit = 0;
                 
 				int notflag = 0;
                 t_pattern_filter -> AdvanceCursor();
diff --git a/libfoundation/src/system-stream.cpp b/libfoundation/src/system-stream.cpp
@@ -231,7 +231,7 @@ __MCSStdioStreamRead (MCStreamRef p_stream,
 	if (!__MCSStdioStreamInterleave (p_stream))
 		return false;
 
-	byte_t *t_buffer;
+	byte_t *t_buffer = nullptr;
 	size_t t_total_read = 0;
 
 	if (t_success)
diff --git a/libgraphics/src/context.cpp b/libgraphics/src/context.cpp
@@ -390,7 +390,7 @@ static bool MCGContextCreateWithBitmap(SkBitmap& p_bitmap, MCGContextRef& r_cont
 {
 	bool t_success = true;
 
-	MCGContextRef t_context;
+	MCGContextRef t_context = nullptr;
 	t_success = MCGContextCreateUnbound(t_context);
 
 	SkCanvas *t_canvas = nil;

Original file line number	Diff line number	Diff line change
`@@ -557,6 +557,7 @@ template<typename T> void GetParagraphPropOfCharChunk(MCExecContext& ctxt, MCFie`
`557`	`557`	`do`
`558`	`558`	`{`
`559`	`559`	`typename T::stack_type t_new_value;`
	`560`	`+ T::init(t_new_value);`
`560`	`561`	`T::getter(ctxt, sptr, p_getter, t_new_value);`
`561`	`562`	`if (ctxt . HasError())`
`562`	`563`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -1227,7 +1227,7 @@ void MCInterfaceGetCursor(MCExecContext& ctxt, uinteger_t*& r_value)`
`1227`	`1227`
`1228`	`1228`	`void MCInterfaceSetCursor(MCExecContext& ctxt, uinteger_t* p_value)`
`1229`	`1229`	`{`
`1230`		`- MCCursorRef t_cursor;`
	`1230`	`+ MCCursorRef t_cursor = nullptr;`
`1231`	`1231`
`1232`	`1232`	`uinteger_t t_cursor_id;`
`1233`	`1233`	`if (p_value == NULL)`
`@@ -1255,7 +1255,7 @@ void MCInterfaceGetDefaultCursor(MCExecContext& ctxt, uinteger_t& r_value)`
`1255`	`1255`
`1256`	`1256`	`void MCInterfaceSetDefaultCursor(MCExecContext& ctxt, uinteger_t p_value)`
`1257`	`1257`	`{`
`1258`		`- MCCursorRef t_cursor;`
	`1258`	`+ MCCursorRef t_cursor = nullptr;`
`1259`	`1259`	`MCInterfaceSetCursor(ctxt, p_value, true, t_cursor);`
`1260`	`1260`
`1261`	`1261`	`// PM-2015-06-17: [[ Bug 15200 ]] Default cursor should reset when set to empty, thus t_cursor can be nil`
Original file line number	Diff line number	Diff line change
`@@ -3132,7 +3132,7 @@ void MCExecStoreProperty(MCExecContext& ctxt, const MCPropertyInfo prop, void `
`3132`	`3132`	`{`
`3133`	`3133`	`MCAutoStringRef t_input;`
`3134`	`3134`	`MCPoint *t_value;`
`3135`		`- uindex_t t_count;`
	`3135`	`+ uindex_t t_count = 0;`
`3136`	`3136`
`3137`	`3137`	`MCExecTypeConvertAndReleaseAlways(ctxt, p_value . type, &p_value, kMCExecValueTypeStringRef, &(&t_input));`
`3138`	`3138`