[[ StdMlc ]] Update bitwise docs, code and tests

runrevali · runrevali · commit cd32531632ff · 2014-12-10T11:51:42.000Z
diff --git a/libscript/src/bitwise.mlc b/libscript/src/bitwise.mlc
@@ -1,5 +1,5 @@
 /*  
-This module specifies the syntax definitions and bindings for bitwise operations on integers in modular LiveCode.
+This module specifies the bitwise operations on integers included in the standard library of modular LiveCode.
 */
 
 module com.livecode.bitwise
@@ -26,7 +26,9 @@ Example:
 	
 Description:
 Each bit of <Left> bitwise and <Right> is 1 if and only if both the corresponding bit of the binary representation of <Left> and that of <Right> is 1. Otherwise it is 0.
-	
+
+Tags: Bitwise operations
+
 */
 
 syntax BitwiseAnd is left binary operator with precedence 2
@@ -50,6 +52,7 @@ Example:
 Description:
 Each bit of <Left> bitwise or <Right> is 0 if and only if both the corresponding bit of the binary representation of <Left> and that of <Right> is 0. Otherwise it is 1.
 
+Tags: Bitwise operations
 */
 
 syntax BitwiseOr is left binary operator with precedence 4
@@ -72,6 +75,7 @@ Example:
 Description:
 Each bit of <Left> bitwise xor <Right> is 1 if and only if exactly one of the corresponding bits of the binary representation of <Left> and that of <Right> is 1. Otherwise it is 0.
 
+Tags: Bitwise operations
 */
 
 syntax BitwiseXor is left binary operator with precedence 3
@@ -85,6 +89,15 @@ Summary:        Performs a bitwise NOT operation on the binary representation of
 
 Operand:        An expression which evaluates to an integer.
 output:         The integer whose binary representation is the result of the bitwise NOT operation.
+
+Example:
+	variable tVar as int
+	put bitwise not -5 into tVar -- tVar contains 4
+
+Description:
+Bitwise not returns the complement of <Operand> as a signed 32-bit integer, thus is equivalent to -(x + 1).
+
+Tags: Bitwise operations
 */
 
 syntax BitwiseNot is prefix operator with precedence 1
@@ -108,6 +121,8 @@ Example:
 
 Description:
 Shifting the bits of <Operand> by x is equivalent to multiplying by 2^x
+
+Tags: Bitwise operations
 */
 
 syntax BitwiseShift is postfix operator with precedence 1
diff --git a/libscript/src/module-bitwise.cpp b/libscript/src/module-bitwise.cpp
@@ -33,7 +33,7 @@ extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseXor(integer_t p_left, integer_t
 
 extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseNot(integer_t p_operand, integer_t& r_output)
 {
-    r_output = ~p_operand;
+    r_output = ~((int32_t)p_operand);
 }
 
 extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseShift(integer_t p_operand, integer_t p_shift, integer_t& r_output)
diff --git a/toolchain/lc-compile/test.mlc b/toolchain/lc-compile/test.mlc
@@ -319,7 +319,8 @@ public handler testBitwise(inout xResults as list)
 	put 3 bitwise xor 6 into tVar
 	testLog("Bitwise", "BitwiseXor", tVar is 5, xResults)
 	
-	--put bitwise not 0 into tVar
+	put bitwise not 5 into tVar
+	testLog("Bitwise", "BitwiseNot", tVar is - 6, xResults)
 
 	put 7 shifted by 2 bitwise into tVar 
 	testLog("Bitwise", "BitwiseShift", tVar is 28, xResults)
@@ -406,7 +407,6 @@ public handler testChar(inout xResults as list)
 	put "abcde" after char 5 of tString
 	
 	testLog("Char", "AfterCharOf", tString is "abcdeabcdeabcde", xResults)
-
 	
 	testLog("Char", "BeginsWithEmpty", tString begins with "", xResults)
 	testLog("Char", "BeginsWith", tString begins with "abcd", xResults)

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseXor(integer_t p_left, integer_t`
`33`	`33`
`34`	`34`	`extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseNot(integer_t p_operand, integer_t& r_output)`
`35`	`35`	`{`
`36`		`- r_output = ~p_operand;`
	`36`	`+ r_output = ~((int32_t)p_operand);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`extern "C" MC_DLLEXPORT void MCBitwiseEvalBitwiseShift(integer_t p_operand, integer_t p_shift, integer_t& r_output)`