[[ Bug ]] Fix over-release crash in ListToNSArray

montegoulding · montegoulding · commit eabd4c50b8ba · 2019-02-21T11:53:01.000+11:00
This patch fixes an over-release of any objective-c objects that are elements of a list passed to `ListToNSArray`. `MCValueConvertToCFTypeRef` should return a retained object which will be released when `MCAutoCustomPointer<const void, CFDeleter> t_cf_value;` goes out of scope. (cherry picked from commit 3688b01)
diff --git a/libfoundation/src/foundation-cf.cpp b/libfoundation/src/foundation-cf.cpp
@@ -514,7 +514,7 @@ bool MCValueConvertToCFTypeRef(MCValueRef p_value, bool p_use_lists, CFTypeRef&
         default:
             if (MCValueGetTypeInfo(p_value) == kMCObjcObjectTypeInfo)
             {
-                r_cf_type = MCObjcObjectGetId((MCObjcObjectRef)p_value);
+                r_cf_type = CFRetain(MCObjcObjectGetId((MCObjcObjectRef)p_value));
                 return true;
             }
             break;

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ bool MCValueConvertToCFTypeRef(MCValueRef p_value, bool p_use_lists, CFTypeRef&`
`514`	`514`	`default:`
`515`	`515`	`if (MCValueGetTypeInfo(p_value) == kMCObjcObjectTypeInfo)`
`516`	`516`	`{`
`517`		`- r_cf_type = MCObjcObjectGetId((MCObjcObjectRef)p_value);`
	`517`	`+ r_cf_type = CFRetain(MCObjcObjectGetId((MCObjcObjectRef)p_value));`
`518`	`518`	`return true;`
`519`	`519`	`}`
`520`	`520`	`break;`