added

SanjarH · SanjarH · commit 8a428aec4a4c · 2023-02-04T22:09:37.000+01:00
diff --git a/int_to_roman.py b/int_to_roman.py
@@ -0,0 +1,28 @@
+# Learn Python together
+""" Write a function that converts integer to roman numerical"""
+
+# Solution
+def int_to_roman(num: int) -> str:
+    # create the list with tuples representing the romans and their values 
+    roman_map = [
+        ('M', 1000), ('CM', 900), ('D', 500), ('CD', 400), ('C', 100),
+        ('XC', 90), ('L', 50), ('XL', 40), ('X', 10),
+        ('IX', 9), ('V', 5), ('IV', 4), ('I', 1)
+    ]
+    if num <= 0:
+            return "Roman numerals don't represent 0 or negative numbers"
+    # epmty result
+    result = ''
+    # using for loop for iterate over the roman_map list:
+    for roman, value in roman_map:
+        # while loop runs until the value of the current roman is greater than the num   
+        while value <= num:
+            result += roman # For each iteration of the while loop, the roman is added to the result
+            num -= value    # and the value is subtracted from num
+    return result
+
+# check
+print(int_to_roman(1994)) # output -> MCMXCIV
+print(int_to_roman(-609)) # output -> Roman numerals don't represent 0 or negative numbers
+print(int_to_roman(0)) # output -> Roman numerals don't represent 0 or negative numbers
+print(int_to_roman(609)) # output -> DCIX
diff --git a/roman_to_int.py b/roman_to_int.py
@@ -19,13 +19,30 @@ def romanToInt(s):
     # use for loop for chcecking characters in range of lenths a string - s
     for i in range(len(s)):
         #check if chararter in s(string) is > 0 and is second charecter greater then previous character 
+         # if yes, subtract 2 times the value of the previous character and add to result
         if i > 0 and roman_dict[s[i]] > roman_dict[s[i - 1]]:
-            # if yes, subtract 2 times the value of the previous character and add to result  
             result += roman_dict[s[i]] - 2 * roman_dict[s[i - 1]]
         else:
             # if second character less then previous character add it to result
             result += roman_dict[s[i]]
     return result
 # check
 print(romanToInt('MCMXCIV')) # output -> 1994
-print(romanToInt('DCIX')) # output -> 609
+print(romanToInt('DCIX')) # output -> 609
+
+# Solution 2 
+def romanToInt2(s: str) -> int:
+    roman_dict = {'I': 1, 'V': 5, 'X': 10, 'L': 50, 'C': 100, 'D': 500, 'M': 1000}
+    result = 0
+    prev_value = 0
+    for c in s[::-1]:
+        curr_value = roman_dict[c]
+        if curr_value >= prev_value:
+            result += curr_value
+        else:
+            result -= curr_value
+        prev_value = curr_value
+    return result
+
+print(romanToInt2('MCMXCIV')) # output -> 1994
+print(romanToInt2('DCIX')) # output -> 609
