Avoiding call to ResultSet.first() for forward-only ResultSets.

thesquaregroot · thesquaregroot · commit f6edea18fea4 · 2023-02-22T16:53:20.000-05:00
diff --git a/src/main/java/com/softwareverde/database/jdbc/JdbcDatabaseConnection.java b/src/main/java/com/softwareverde/database/jdbc/JdbcDatabaseConnection.java
@@ -105,7 +105,15 @@ protected List<Row> _query(final String query, final TypedParameter[] typedParam
             try (final PreparedStatement preparedStatement = _prepareStatement(query, typedParameters);
                  final ResultSet resultSet = preparedStatement.executeQuery() ) {
 
-                if (resultSet.first()) {
+                boolean shouldIterate;
+                if (resultSet.getType() == ResultSet.TYPE_FORWARD_ONLY) {
+                    shouldIterate = resultSet.next();
+                }
+                else {
+                    shouldIterate = resultSet.first();
+                }
+
+                if (shouldIterate) {
                     do {
                         results.add(_rowFactory.fromResultSet(resultSet));
                     } while (resultSet.next());
@@ -193,4 +201,4 @@ public void close() throws DatabaseException {
             throw new DatabaseException("Unable to close database connection.", exception);
         }
     }
-}
+}
