Exceptions are now logged via Logger, not to System.out.

joshmg · joshmg · commit 27a3d61720a8 · 2020-12-10T09:46:25.000-05:00
diff --git a/build.gradle b/build.gradle
@@ -1,5 +1,5 @@
 group 'com.softwareverde'
-version '2.0.5'
+version '2.0.6'
 
 apply plugin: 'java'
 apply plugin: 'java-library'
@@ -13,8 +13,8 @@ repositories {
 
 dependencies {
     api                 group: 'com.github.softwareverde',   name: 'json',           version: 'v2.0.0'
-    implementation      group: 'com.github.softwareverde',   name: 'java-logging',   version: 'v2.1.0'
-    implementation      group: 'com.github.softwareverde',   name: 'java-util',      version: 'v2.0.7'
+    implementation      group: 'com.github.softwareverde',   name: 'java-logging',   version: 'v2.2.0'
+    implementation      group: 'com.github.softwareverde',   name: 'java-util',      version: 'v2.6.1'
 
     testImplementation  group: 'junit', name: 'junit', version: '4.12'
 }
diff --git a/src/main/java/com/softwareverde/http/HttpRequestExecutionThread.java b/src/main/java/com/softwareverde/http/HttpRequestExecutionThread.java
@@ -2,9 +2,9 @@
 
 import com.softwareverde.constable.bytearray.ByteArray;
 import com.softwareverde.constable.bytearray.MutableByteArray;
+import com.softwareverde.logging.Logger;
 import com.softwareverde.util.IoUtil;
 import com.softwareverde.util.ReflectionUtil;
-import com.softwareverde.util.StringUtil;
 import com.softwareverde.util.Util;
 
 import javax.net.ssl.HttpsURLConnection;
@@ -166,8 +166,7 @@ public void run() {
                     httpResponse._webSocket = webSocketFactory.newWebSocket(socket);
                 }
                 catch (final Exception exception) {
-                    System.out.println("NOTICE: Unable to get underlying socket for WebSocket within HttpRequest.");
-                    exception.printStackTrace();
+                    Logger.warn("Unable to get underlying socket for WebSocket within HttpRequest via reflection.", exception);
                     connection.disconnect();
                 }
             }
@@ -177,7 +176,7 @@ public void run() {
             }
         }
         catch (final Exception exception) {
-            exception.printStackTrace();
+            Logger.debug("Unable to execute request.", exception);
 
             if (_callback != null) {
                 _callback.run(null);
diff --git a/src/main/java/com/softwareverde/http/querystring/QueryStringParser.java b/src/main/java/com/softwareverde/http/querystring/QueryStringParser.java
@@ -1,6 +1,7 @@
 package com.softwareverde.http.querystring;
 
 import com.softwareverde.constable.bytearray.MutableByteArray;
+import com.softwareverde.logging.Logger;
 import com.softwareverde.util.StringUtil;
 import com.softwareverde.util.Util;
 
@@ -42,7 +43,7 @@ public static String toString(final Map<String, String> params, final Map<String
             }
         }
         catch (final Exception exception) {
-            exception.printStackTrace();
+            Logger.debug("Error building query string.", exception);
         }
         return stringBuilder.toString();
     }

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,9 @@`
`2`	`2`
`3`	`3`	`import com.softwareverde.constable.bytearray.ByteArray;`
`4`	`4`	`import com.softwareverde.constable.bytearray.MutableByteArray;`
	`5`	`+import com.softwareverde.logging.Logger;`
`5`	`6`	`import com.softwareverde.util.IoUtil;`
`6`	`7`	`import com.softwareverde.util.ReflectionUtil;`
`7`		`-import com.softwareverde.util.StringUtil;`
`8`	`8`	`import com.softwareverde.util.Util;`
`9`	`9`
`10`	`10`	`import javax.net.ssl.HttpsURLConnection;`
`@@ -166,8 +166,7 @@ public void run() {`
`166`	`166`	`httpResponse._webSocket = webSocketFactory.newWebSocket(socket);`
`167`	`167`	`}`
`168`	`168`	`catch (final Exception exception) {`
`169`		`- System.out.println("NOTICE: Unable to get underlying socket for WebSocket within HttpRequest.");`
`170`		`- exception.printStackTrace();`
	`169`	`+ Logger.warn("Unable to get underlying socket for WebSocket within HttpRequest via reflection.", exception);`
`171`	`170`	`connection.disconnect();`
`172`	`171`	`}`
`173`	`172`	`}`
`@@ -177,7 +176,7 @@ public void run() {`
`177`	`176`	`}`
`178`	`177`	`}`
`179`	`178`	`catch (final Exception exception) {`
`180`		`- exception.printStackTrace();`
	`179`	`+ Logger.debug("Unable to execute request.", exception);`
`181`	`180`
`182`	`181`	`if (_callback != null) {`
`183`	`182`	`_callback.run(null);`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package com.softwareverde.http.querystring;`
`2`	`2`
`3`	`3`	`import com.softwareverde.constable.bytearray.MutableByteArray;`
	`4`	`+import com.softwareverde.logging.Logger;`
`4`	`5`	`import com.softwareverde.util.StringUtil;`
`5`	`6`	`import com.softwareverde.util.Util;`
`6`	`7`
`@@ -42,7 +43,7 @@ public static String toString(final Map<String, String> params, final Map<String`
`42`	`43`	`}`
`43`	`44`	`}`
`44`	`45`	`catch (final Exception exception) {`
`45`		`- exception.printStackTrace();`
	`46`	`+ Logger.debug("Error building query string.", exception);`
`46`	`47`	`}`
`47`	`48`	`return stringBuilder.toString();`
`48`	`49`	`}`