fixing test and some empty rules

gcaillat · gcaillat · commit 0bed92fa9eb7 · 2018-03-22T14:38:05.000+01:00
diff --git a/sonar-python-plugin/src/main/resources/org/sonar/plugins/python/pylint/remediation-cost.csv b/sonar-python-plugin/src/main/resources/org/sonar/plugins/python/pylint/remediation-cost.csv
@@ -75,6 +75,10 @@ E0704,10min
 E0710,15min
 E0711,5min
 E0712,20min
+E1001,10min
+E1002,10min
+E1003,10min
+E1004,10min
 E1101,10min
 E1102,3min
 E1111,20min
@@ -133,6 +137,7 @@ I0020,null
 I0021,null
 I0022,null
 I0101,null
+I1101,null
 R0123,20min
 R0201,20min
 R0202,15min
diff --git a/sonar-python-plugin/src/main/resources/org/sonar/plugins/python/pylint/rules.xml b/sonar-python-plugin/src/main/resources/org/sonar/plugins/python/pylint/rules.xml
@@ -317,7 +317,7 @@
     </rule>
     <rule>
         <key>E0001</key>
-        <name><![CDATA[]]></name>
+        <name><![CDATA[syntax error for a module]]></name>
         <configKey>E0001</configKey>
         <description>
             <![CDATA[Used when a syntax error is raised for a module.]]>
@@ -847,7 +847,7 @@
     </rule>
     <rule>
         <key>E1130</key>
-        <name><![CDATA[]]></name>
+        <name><![CDATA[Unary operand is used on an object which does not support this type of operation]]></name>
         <configKey>E1130</configKey>
         <description>
             <![CDATA[Emitted when a unary operand is used on an object which does not support thistype of operation]]>
@@ -856,7 +856,7 @@
     </rule>
     <rule>
         <key>E1131</key>
-        <name><![CDATA[]]></name>
+        <name><![CDATA[Unsupported binary arithmetic operation ]]></name>
         <configKey>E1131</configKey>
         <description>
             <![CDATA[Emitted when a binary arithmetic operation between two operands is notsupported.]]>
@@ -1135,7 +1135,7 @@
     </rule>
     <rule>
         <key>F0001</key>
-        <name><![CDATA[]]></name>
+        <name><![CDATA[Error preventing the analysis of a module ]]></name>
         <configKey>F0001</configKey>
         <description>
             <![CDATA[Used when an error occurred preventing the analysis of a module (unable tofind it for instance).]]>
@@ -1811,7 +1811,7 @@
     </rule>
     <rule>
         <key>W0511</key>
-        <name><![CDATA[]]></name>
+        <name><![CDATA[warning note as FIXME or XXX]]></name>
         <configKey>W0511</configKey>
         <description>
             <![CDATA[Used when a warning note as FIXME or XXX is detected.]]>
diff --git a/sonar-python-plugin/src/test/java/org/sonar/plugins/python/pylint/PylintRuleRepositoryTest.java b/sonar-python-plugin/src/test/java/org/sonar/plugins/python/pylint/PylintRuleRepositoryTest.java
@@ -41,12 +41,12 @@ public void createRulesTest() {
 
     List<RulesDefinition.Rule> rules = repository.rules();
     assertThat(rules).isNotNull();
-    assertThat(rules).hasSize(180);
+    assertThat(rules).hasSize(292);
 
     long rulesWithoutRemediationCost = rules.stream()
       .filter(rule -> rule.debtRemediationFunction() == null)
       .count();
-    assertThat(rulesWithoutRemediationCost).isEqualTo(24);
+    assertThat(rulesWithoutRemediationCost).isEqualTo(23);
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -41,12 +41,12 @@ public void createRulesTest() {`
`41`	`41`
`42`	`42`	`List<RulesDefinition.Rule> rules = repository.rules();`
`43`	`43`	`assertThat(rules).isNotNull();`
`44`		`- assertThat(rules).hasSize(180);`
	`44`	`+ assertThat(rules).hasSize(292);`
`45`	`45`
`46`	`46`	`long rulesWithoutRemediationCost = rules.stream()`
`47`	`47`	`.filter(rule -> rule.debtRemediationFunction() == null)`
`48`	`48`	`.count();`
`49`		`- assertThat(rulesWithoutRemediationCost).isEqualTo(24);`
	`49`	`+ assertThat(rulesWithoutRemediationCost).isEqualTo(23);`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`}`