feat(build): disable sourcemaps for production (angular#3963)

clydin · hansl · commit da1c19737aad · 2017-01-12T11:11:15.000-08:00
sourcemaps can be enabled using the `--sourcemap` option, if desired
diff --git a/packages/angular-cli/commands/build.run.ts b/packages/angular-cli/commands/build.run.ts
@@ -22,6 +22,15 @@ export default function buildRun(commandOptions: BuildOptions) {
     }
   }
 
+  if (typeof commandOptions.sourcemap === 'undefined') {
+    if (commandOptions.target == 'development') {
+      commandOptions.sourcemap = true;
+    }
+    if (commandOptions.target == 'production') {
+      commandOptions.sourcemap = false;
+    }
+  }
+
   const project = this.project;
 
   // Check angular version.
diff --git a/packages/angular-cli/commands/build.ts b/packages/angular-cli/commands/build.ts
@@ -39,7 +39,7 @@ const BuildCommand = Command.extend({
     { name: 'suppress-sizes', type: Boolean, default: false },
     { name: 'base-href',      type: String,  default: null, aliases: ['bh'] },
     { name: 'aot',            type: Boolean, default: false },
-    { name: 'sourcemap',      type: Boolean, default: true, aliases: ['sm'] },
+    { name: 'sourcemap',      type: Boolean, aliases: ['sm'] },
     { name: 'vendor-chunk',   type: Boolean, default: true },
     { name: 'verbose',        type: Boolean, default: false },
     { name: 'progress',       type: Boolean, default: true },
diff --git a/tests/e2e/tests/build/sourcemap.ts b/tests/e2e/tests/build/sourcemap.ts
@@ -6,6 +6,13 @@ import {expectToFail} from '../../utils/utils';
 export default function() {
   return ng('build')
     .then(() => expectFileToExist('dist/main.bundle.map'))
+
     .then(() => ng('build', '--no-sourcemap'))
-    .then(() => expectToFail(() => expectFileToExist('dist/main.bundle.map')));
+    .then(() => expectToFail(() => expectFileToExist('dist/main.bundle.map')))
+
+    .then(() => ng('build', '--prod', '--output-hashing=none'))
+    .then(() => expectToFail(() => expectFileToExist('dist/main.bundle.map')))
+
+    .then(() => ng('build', '--prod', '--output-hashing=none', '--sourcemap'))
+    .then(() => expectFileToExist('dist/main.bundle.map'));
 }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,15 @@ export default function buildRun(commandOptions: BuildOptions) {`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`
	`25`	`+ if (typeof commandOptions.sourcemap === 'undefined') {`
	`26`	`+ if (commandOptions.target == 'development') {`
	`27`	`+ commandOptions.sourcemap = true;`
	`28`	`+ }`
	`29`	`+ if (commandOptions.target == 'production') {`
	`30`	`+ commandOptions.sourcemap = false;`
	`31`	`+ }`
	`32`	`+ }`
	`33`	`+`
`25`	`34`	`const project = this.project;`
`26`	`35`
`27`	`36`	`// Check angular version.`