-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: liuyix/python-zipstream
base: master
head repository: allanlei/python-zipstream
compare: master
- 12 commits
- 3 files changed
- 6 contributors
Commits on Jan 28, 2016
-
Bugfix for allanlei#15 for compressing large files
This is a potential quick fix for Issue allanlei#15 which occurs when attempting to compress files larger than ZIP64_LIMIT. `zinfo.file_size` is never initialized to the correct file size and thus the determination of whether zip64 is required is made based on the file size of 0. This later results in an exception being raised as though the file size increased during compression, since the file size is actually counted during compression and later saved over `zinfo.file_size`. It is important to note that this fix may not be cross platform. Different versions of Python do different things on Windows with the `st_size` parameter in the `os.stat` call. So, that may be worth investigating further. However, in the short term, this will fix the problem on Linux, Mac, and some Windows platforms without making it worse where it still doesn't work. I would leave it to the maintainers to make a broader decision on whether this fix is appropriate or if a better solution would be desired. I'm happy to help.
Configuration menu - View commit details
-
Copy full SHA for da7d3ed - Browse repository at this point
Copy the full SHA da7d3edView commit details
Commits on Feb 23, 2016
-
Corrected order of arguments in example
The function write_iter receives a filename and an iterable in that order.
Configuration menu - View commit details
-
Copy full SHA for bdf5b14 - Browse repository at this point
Copy the full SHA bdf5b14View commit details
Commits on Mar 4, 2016
-
Merge pull request allanlei#17 from hecvd/master
Corrected order of arguments in example
Configuration menu - View commit details
-
Copy full SHA for d45fd94 - Browse repository at this point
Copy the full SHA d45fd94View commit details
Commits on May 6, 2016
-
Merge pull request allanlei#16 from lesthaeghet/master
Bugfix for allanlei#15 for compressing large files
Configuration menu - View commit details
-
Copy full SHA for 2ebe493 - Browse repository at this point
Copy the full SHA 2ebe493View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5476a18 - Browse repository at this point
Copy the full SHA 5476a18View commit details -
Configuration menu - View commit details
-
Copy full SHA for af6c9b1 - Browse repository at this point
Copy the full SHA af6c9b1View commit details
Commits on Aug 10, 2016
-
Fix incorrect function call in examples.
Order of arguments to write_iter incorrect.
Configuration menu - View commit details
-
Copy full SHA for 0c4772e - Browse repository at this point
Copy the full SHA 0c4772eView commit details
Commits on Jan 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0d3bed3 - Browse repository at this point
Copy the full SHA 0d3bed3View commit details
Commits on Feb 3, 2017
-
Merge pull request allanlei#21 from peter-juritz/patch-1
Fix incorrect function call in examples.
Configuration menu - View commit details
-
Copy full SHA for b056389 - Browse repository at this point
Copy the full SHA b056389View commit details -
Merge pull request allanlei#24 from marcosdiez/master
Fix documentation (Django section)
Configuration menu - View commit details
-
Copy full SHA for 41bb027 - Browse repository at this point
Copy the full SHA 41bb027View commit details
Commits on Apr 19, 2017
-
Fix indetion in the README (use sapces)
There should be no tabs in the Python code examples because it renders differently in GitHub
Configuration menu - View commit details
-
Copy full SHA for 45b2b55 - Browse repository at this point
Copy the full SHA 45b2b55View commit details
Commits on Jul 12, 2018
-
Merge pull request allanlei#26 from IndustriaTech/fix/readme-indetion
Fix indetion in the README (use sapces)
Configuration menu - View commit details
-
Copy full SHA for 28bb3f6 - Browse repository at this point
Copy the full SHA 28bb3f6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master