Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: liuyix/python-zipstream
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: allanlei/python-zipstream
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 3 files changed
  • 6 contributors

Commits on Jan 28, 2016

  1. Bugfix for allanlei#15 for compressing large files

    This is a potential quick fix for Issue allanlei#15 which occurs when attempting to compress files larger than ZIP64_LIMIT.  `zinfo.file_size` is never initialized to the correct file size and thus the determination of whether zip64 is required is made based on the file size of 0.  This later results in an exception being raised as though the file size increased during compression, since the file size is actually counted during compression and later saved over `zinfo.file_size`. 
    
    It is important to note that this fix may not be cross platform.  Different versions of Python do different things on Windows with the `st_size` parameter in the `os.stat` call.  So, that may be worth investigating further.  However, in the short term, this will fix the problem on Linux, Mac, and some Windows platforms without making it worse where it still doesn't work.
    
    I would leave it to the maintainers to make a broader decision on whether this fix is appropriate or if a better solution would be desired.  I'm happy to help.
    lesthaeghet committed Jan 28, 2016
    Configuration menu
    Copy the full SHA
    da7d3ed View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2016

  1. Corrected order of arguments in example

    The function write_iter receives a filename and an iterable in that order.
    hecvd committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    bdf5b14 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2016

  1. Merge pull request allanlei#17 from hecvd/master

    Corrected order of arguments in example
    allanlei committed Mar 4, 2016
    Configuration menu
    Copy the full SHA
    d45fd94 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2016

  1. Merge pull request allanlei#16 from lesthaeghet/master

    Bugfix for allanlei#15 for compressing large files
    allanlei committed May 6, 2016
    Configuration menu
    Copy the full SHA
    2ebe493 View commit details
    Browse the repository at this point in the history
  2. Bump version

    allanlei committed May 6, 2016
    Configuration menu
    Copy the full SHA
    5476a18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af6c9b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2016

  1. Fix incorrect function call in examples.

    Order of arguments to write_iter incorrect.
    peter-juritz authored Aug 10, 2016
    Configuration menu
    Copy the full SHA
    0c4772e View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2017

  1. Configuration menu
    Copy the full SHA
    0d3bed3 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. Merge pull request allanlei#21 from peter-juritz/patch-1

    Fix incorrect function call in examples.
    allanlei authored Feb 3, 2017
    Configuration menu
    Copy the full SHA
    b056389 View commit details
    Browse the repository at this point in the history
  2. Merge pull request allanlei#24 from marcosdiez/master

    Fix documentation (Django section)
    allanlei authored Feb 3, 2017
    Configuration menu
    Copy the full SHA
    41bb027 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2017

  1. Fix indetion in the README (use sapces)

    There should be no tabs in the Python code examples because it renders differently in GitHub
    vstoykov committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    45b2b55 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2018

  1. Merge pull request allanlei#26 from IndustriaTech/fix/readme-indetion

    Fix indetion in the README (use sapces)
    allanlei authored Jul 12, 2018
    Configuration menu
    Copy the full SHA
    28bb3f6 View commit details
    Browse the repository at this point in the history
Loading