fixed glitch that allowed duplicate GFF attributes

gpertea · gpertea · commit f556e329b8e6 · 2017-03-26T08:54:28.000-04:00
diff --git a/gclib/gff.cpp b/gclib/gff.cpp
@@ -1490,7 +1490,7 @@ void GffObj::copyAttrs(GffObj* from) { //typically from is the parent gene, and
 		bool haveit=false;
 		for (int ai=0;ai<this->attrs->Count();++ai) {
 			//do we have it already?
-			if (aid==this->attrs->Get(i)->attr_id) {
+			if (aid==this->attrs->Get(ai)->attr_id) {
 				haveit=true;
 				break; //skip this, don't replace
 			}
diff --git a/gclib/gff.h b/gclib/gff.h
@@ -340,7 +340,7 @@ enum GffPrintMode {
 
 class GffAttrs:public GList<GffAttr> {
   public:
-    GffAttrs():GList<GffAttr>(false,true,false) { }
+    GffAttrs():GList<GffAttr>(false,true,true) { }
     void add_or_update(GffNames* names, const char* attrname, const char* val) {
       int aid=names->attrs.getId(attrname);
       if (aid>=0) {

Original file line number	Diff line number	Diff line change
`@@ -1490,7 +1490,7 @@ void GffObj::copyAttrs(GffObj* from) { //typically from is the parent gene, and`
`1490`	`1490`	`bool haveit=false;`
`1491`	`1491`	`for (int ai=0;ai<this->attrs->Count();++ai) {`
`1492`	`1492`	`//do we have it already?`
`1493`		`- if (aid==this->attrs->Get(i)->attr_id) {`
	`1493`	`+ if (aid==this->attrs->Get(ai)->attr_id) {`
`1494`	`1494`	`haveit=true;`
`1495`	`1495`	`break; //skip this, don't replace`
`1496`	`1496`	`}`