libscript: Use marginally more efficient impl for &/&& ops.

peter-b · peter-b · commit 573756fae7e1 · 2015-12-16T19:02:13.000Z
`MCStringCreateWithString()` etc. are more efficient than using
`MCStringFormat()` for string concatenation.
diff --git a/libscript/src/module-string.cpp b/libscript/src/module-string.cpp
@@ -21,8 +21,8 @@
 
 extern "C" MC_DLLEXPORT_DEF void MCStringEvalConcatenate(MCStringRef p_left, MCStringRef p_right, MCStringRef& r_output)
 {
-    if (!MCStringFormat(r_output, "%@%@", p_left, p_right))
-        return;
+	if (!MCStringCreateWithStrings(r_output, p_left, p_right))
+		return;
 }
 
 extern "C" MC_DLLEXPORT_DEF void MCStringExecPutStringBefore(MCStringRef p_source, MCStringRef& x_target)
@@ -64,8 +64,8 @@ extern "C" MC_DLLEXPORT_DEF void MCStringExecReplace(MCStringRef p_pattern, MCSt
 
 extern "C" MC_DLLEXPORT_DEF void MCStringEvalConcatenateWithSpace(MCStringRef p_left, MCStringRef p_right, MCStringRef& r_output)
 {
-    if (!MCStringFormat(r_output, "%@ %@", p_left, p_right))
-        return;
+	if (!MCStringCreateWithStringsAndSeparator(r_output, ' ', p_left, p_right))
+		return;
 }
 
 extern "C" MC_DLLEXPORT_DEF void MCStringEvalLowercaseOf(MCStringRef p_source, MCStringRef& r_output)

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@`
`21`	`21`
`22`	`22`	`extern "C" MC_DLLEXPORT_DEF void MCStringEvalConcatenate(MCStringRef p_left, MCStringRef p_right, MCStringRef& r_output)`
`23`	`23`	`{`
`24`		`- if (!MCStringFormat(r_output, "%@%@", p_left, p_right))`
`25`		`- return;`
	`24`	`+ if (!MCStringCreateWithStrings(r_output, p_left, p_right))`
	`25`	`+ return;`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`extern "C" MC_DLLEXPORT_DEF void MCStringExecPutStringBefore(MCStringRef p_source, MCStringRef& x_target)`
`@@ -64,8 +64,8 @@ extern "C" MC_DLLEXPORT_DEF void MCStringExecReplace(MCStringRef p_pattern, MCSt`
`64`	`64`
`65`	`65`	`extern "C" MC_DLLEXPORT_DEF void MCStringEvalConcatenateWithSpace(MCStringRef p_left, MCStringRef p_right, MCStringRef& r_output)`
`66`	`66`	`{`
`67`		`- if (!MCStringFormat(r_output, "%@ %@", p_left, p_right))`
`68`		`- return;`
	`67`	`+ if (!MCStringCreateWithStringsAndSeparator(r_output, ' ', p_left, p_right))`
	`68`	`+ return;`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`extern "C" MC_DLLEXPORT_DEF void MCStringEvalLowercaseOf(MCStringRef p_source, MCStringRef& r_output)`