Test all outcomes of issue_event

begedin · begedin · commit dc9c2a43618f · 2018-02-14T12:16:10.000+01:00
diff --git a/lib/code_corps/github/sync/sync.ex b/lib/code_corps/github/sync/sync.ex
@@ -13,7 +13,9 @@ defmodule CodeCorps.GitHub.Sync do
     GitHub.Sync.Utils.Finder,
     GitHub.Utils.ResultAggregator,
     GithubAppInstallation,
+    GithubIssue,
     GithubRepo,
+    GithubUser,
     Repo,
     Task
   }
@@ -58,9 +60,12 @@ defmodule CodeCorps.GitHub.Sync do
       {:error, :repo, :unmatched_repository, _steps} ->
         {:error, :repo_not_found}
 
-      {:error, :github_issue, %Changeset{} = changeset, _steps} ->
+      {:error, :github_issue, %Changeset{data: %GithubIssue{}} = changeset, _steps} ->
         {:error, :validating_github_issue, changeset}
 
+      {:error, :github_issue, %Changeset{data: %GithubUser{}} = changeset, _steps} ->
+        {:error, :validating_github_user, changeset}
+
       {:error, :issue_user, %Changeset{} = changeset, _steps} ->
         {:error, :validating_user, changeset}
 
diff --git a/lib/code_corps/github/sync/task/changeset.ex b/lib/code_corps/github/sync/task/changeset.ex
@@ -77,16 +77,19 @@ defmodule CodeCorps.GitHub.Sync.Task.Changeset do
 
     list_type = issue |> get_task_list_type()
 
-    %TaskList{id: id} =
+    task_list_id =
       TaskList
       |> where(project_id: ^project_id)
       |> where([t], field(t, ^list_type) == true)
       |> Repo.one()
+      # ensure code executs if no list find
+      |> (fn list -> (list || %{}) |> Map.get(:id) end).()
 
     # put_change/2 instead of put_assoc/2 so task list
     # doesn't have to be preloaded
+    # id can be nil and will trigger validation in that case
     changeset
-    |> Changeset.put_change(:task_list_id, id)
+    |> Changeset.put_change(:task_list_id, task_list_id)
     |> Changeset.assoc_constraint(:task_list)
   end
 
diff --git a/test/lib/code_corps/github/sync/github_issue/github_issue_test.exs b/test/lib/code_corps/github/sync/github_issue/github_issue_test.exs
@@ -9,9 +9,12 @@ defmodule CodeCorps.GitHub.Sync.GithubIssueTest do
     GitHub.Adapters,
     GitHub.Sync,
     GithubIssue,
+    GithubUser,
     Repo
   }
 
+  alias Ecto.Changeset
+
   @issue_event_payload load_event_fixture("issues_opened")
 
   describe "create_or_update_issue/2+3" do
@@ -82,5 +85,16 @@ defmodule CodeCorps.GitHub.Sync.GithubIssueTest do
       {:error, changeset} = attrs |> Sync.GithubIssue.create_or_update_issue(github_repo)
       refute changeset.valid?
     end
+
+    test "returns github user changeset if insert of github user fails" do
+      %{"issue" => attrs} = @issue_event_payload
+      github_repo = insert(:github_repo)
+      assert {:error, %Changeset{data: %GithubUser{}} = changeset} =
+        attrs
+        |> Kernel.put_in(["user", "login"], nil)
+        |> Sync.GithubIssue.create_or_update_issue(github_repo)
+
+      refute changeset.valid?
+    end
   end
 end
diff --git a/test/lib/code_corps/github/sync/sync_test.exs b/test/lib/code_corps/github/sync/sync_test.exs
@@ -8,6 +8,7 @@ defmodule CodeCorps.GitHub.SyncTest do
 
   alias CodeCorps.{
     Comment,
+    GitHub.Adapters,
     GitHub.Sync,
     GithubAppInstallation,
     GithubComment,
@@ -21,6 +22,8 @@ defmodule CodeCorps.GitHub.SyncTest do
     User
   }
 
+  alias Ecto.Changeset
+
   describe "installation_repositories_event/1 added" do
 
     @payload load_event_fixture("installation_repositories_added")
@@ -51,7 +54,7 @@ defmodule CodeCorps.GitHub.SyncTest do
     end
 
     test "can fail when installation not found" do
-      assert {:error, :unmatched_installation, %{}} == @payload |> Sync.installation_repositories_event()
+      assert {:error, :unmatched_installation} == @payload |> Sync.installation_repositories_event()
     end
 
     test "fails with validation errors when syncing repos" do
@@ -337,6 +340,72 @@ defmodule CodeCorps.GitHub.SyncTest do
 
       assert existing_task.id == task.id
     end
+
+    test "can fail when finding repo" do
+      assert {:error, :repo_not_found} == @payload |> Sync.issue_event()
+    end
+
+    test "can fail on github issue validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+      assert {:error, :validating_github_issue, %Changeset{} = changeset} =
+        @payload
+        |> Kernel.put_in(["issue", "number"], nil)
+        |> Sync.issue_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on github user validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+      assert {:error, :validating_github_user, %Changeset{} = changeset} =
+        @payload
+        |> Kernel.put_in(["issue", "user", "login"], nil)
+        |> Sync.issue_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail on user validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      # setup data to trigger a unique constraint
+      email = "taken@mail.com"
+      insert(:user, email: email)
+      payload = @payload |> Kernel.put_in(["issue", "user", "email"], email)
+
+      assert {:error, :validating_user, %Changeset{} = changeset} =
+        payload |> Sync.issue_event()
+
+      refute changeset.valid?
+    end
+
+    test "can fail if matched by multiple users" do
+      github_repo =
+        insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      attrs =
+        @payload["issue"]
+        |> Adapters.Issue.to_issue()
+        |> Map.put(:github_repo, github_repo)
+
+      github_issue = insert(:github_issue, attrs)
+      # creates a user for each task, which should never happen normally
+      insert_pair(:task, github_issue: github_issue)
+
+      assert {:error, :multiple_issue_users_match} ==
+        @payload |> Sync.issue_event()
+    end
+
+    test "can fail on task validation" do
+      insert(:github_repo, github_id: @payload["repository"]["id"])
+
+      # validation is triggered due to missing task list
+
+      assert {:error, :validating_task, %Changeset{} = changeset} =
+        @payload |> Sync.issue_event()
+
+      refute changeset.valid?
+    end
   end
 
   describe "sync_repo/1" do
diff --git a/test/lib/code_corps/github/sync/task/changeset_test.exs b/test/lib/code_corps/github/sync/task/changeset_test.exs
@@ -118,6 +118,21 @@ defmodule CodeCorps.GitHub.Sync.Task.ChangesetTest do
       assert changeset |> Changeset.get_field(:archived) == true
       assert changeset |> Changeset.get_field(:task_list_id) == nil
     end
+
+    test "does not fail and instead returns invalid changeset if no task list matched" do
+      github_issue = insert(
+        :github_issue,
+        github_created_at: DateTime.utc_now |> Timex.shift(minutes: 1),
+        github_updated_at: DateTime.utc_now |> Timex.shift(hours: 1))
+      project = insert(:project)
+      github_repo = insert(:github_repo, project: project)
+      user = insert(:user)
+
+      changeset =
+        github_issue |> Task.Changeset.create_changeset(github_repo, user)
+
+      refute changeset.valid?
+    end
   end
 
   describe "update_changeset/3" do
@@ -248,5 +263,21 @@ defmodule CodeCorps.GitHub.Sync.Task.ChangesetTest do
       assert changeset |> Changeset.get_field(:archived) == true
       assert changeset |> Changeset.get_field(:task_list_id) == nil
     end
+
+    test "does not fail and instead returns invalid changeset if no task list matched" do
+      github_issue = insert(
+        :github_issue,
+        github_created_at: DateTime.utc_now |> Timex.shift(minutes: 1),
+        github_updated_at: DateTime.utc_now |> Timex.shift(hours: 1))
+      project = insert(:project)
+      github_repo = insert(:github_repo, project: project)
+      user = insert(:user)
+      task = insert(:task, project: project, github_issue: github_issue, github_repo: github_repo, user: user, modified_at: DateTime.utc_now)
+
+      changeset =
+        task |> Task.Changeset.update_changeset(github_issue, github_repo)
+
+      refute changeset.valid?
+    end
   end
 end
