Skip to content

Commit 1ee18db

Browse files
raethleinraethlein
committed
Fix issue with translation of consent text. Make link to privacy policy configurable. Update documentation accordingly.
1 parent 92639d9 commit 1ee18db

3 files changed

Lines changed: 15 additions & 8 deletions

File tree

‎app/mobile/README.md‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,17 @@ If you have the tool already installed, skip the respective step.
7777
sudo xcode-select --switch /Applications/Xcode.app
7878
```
7979

80-
1. Add configuration files. The respective services have to exist if you want to have Cotect running. Get in touch with the administrator of an existing project using this code to get the information or set up the services for a fresh project.
80+
2. Add configuration files. The respective services have to exist if you want to have Cotect running. Get in touch with the administrator of an existing project to get the information or set up the services for a fresh project.
8181
1. Add `.env` file to `app/mobile`:
8282
```bash
8383
COTECT_BACKEND_URL=https://...
84+
COTECT_PRIVACY_POLICY_URL=https://...
8485
```
8586

86-
> This is the URL where the Cotect backend can be reached. You find the code for it also in this repository.
87+
> `COTECT_BACKEND_URL` is the URL where the Cotect backend can be reached. You find the code for it also in this repository.\
88+
`COTECT_PRIVACY_POLICY_URL` should point to your hosted GDPR-compliant privacy policy.
89+
90+
> We use the library [react-native-dotenv](https://github.com/zetachang/react-native-dotenv) to interpolate those variables within the code.
8791

8892
1. Add Firebase configuration. We use the services *Phone Authentication* and *Crashlytics* from Firebase. You can configure a Firebase project [here](https://console.firebase.google.com/).
8993
1. Android: Download the `google-service.json` and add it to `android/app`
@@ -103,15 +107,15 @@ If you have the tool already installed, skip the respective step.
103107
</plist>
104108
```
105109
1. [only once] In Xcode, right click on the project > click on "Add file..." > select `GooglePlaces-Info.plist (make sure "Copy files if needed" is selected)` (make sure "Copy files if needed" is selected)
106-
1. Run iOS version (make sure Xcode is installed; there you can also install an emulator): `npx react-native run-ios`
107-
1. Run Android version: `npx react-native run-android`
110+
3. Run iOS version (make sure XCode is installed; there you can also install an emulator): `npx react-native run-ios`
111+
4. Run Android version (make sure Android Studio is installed; there you can also install an emulator): `npx react-native run-android`
108112
109113
### Build a Release Version
110114
111115
> Important: Don't use the debug certificates / keys you find in this repo for releasing your app. Rather, generate release keys and build the app with them!
112116
113117
1. Android: `cd android && ./gradlew app:assembleRelease`
114-
1. iOS: Use XCode, select the right provisioning profile, and then build the app with. Follow standard iOS release practices from there (e.g. creating an .ipa file manually or an archive from XCode)
118+
1. iOS: Use XCode, select the right provisioning profile, and then build the app with it. Follow standard iOS release practices from there (e.g. creating an .ipa file manually or an archive from XCode)
115119
116120
### Add new Fonts
117121

‎app/mobile/screens/steps/ReportSubmitStep.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import {StyleSheet, View, ScrollView, Linking} from 'react-native';
88

99
import {Checkbox, List, Avatar, Button, Card, Title, Paragraph, Text} from 'react-native-paper';
1010

11+
import {COTECT_PRIVACY_POLICY_URL} from 'react-native-dotenv';
12+
1113
import StepContainer from './StepContainer';
1214

1315
import {CARD_ITEM, ACTION_BUTTON, ACTION_BUTTON_LABEL} from '../../constants/DefaultStyles';
@@ -72,8 +74,8 @@ export default function ReportSubmitStep(props) {
7274
onPress={() => setConsentGiven(!isConsentGiven)}
7375
/>
7476
<Text>
75-
<Trans i18nKey="report.submitReport.consent">
76-
By submitting the report, you accept that your provided information are sent to the Cotect servers for further processing. You can read more in our <Text style={{color: 'blue'}} onPress={() => Linking.openURL('http://google.com')}>privacy policy</Text>.
77+
<Trans t={t} i18nKey="report.submit.consent">
78+
By submitting the report, you accept that your provided information are sent to the Cotect servers for further processing. You can read more in our <Text style={{color: 'blue'}} onPress={() => Linking.openURL(COTECT_PRIVACY_POLICY_URL)}>privacy policy</Text>.
7779
</Trans>
7880
</Text>
7981
</View>

‎app/mobile/translations/de.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,8 @@
174174
"exitAction": "Verlassen",
175175
"successText": "Wir haben deinen Bericht erhalten! Danke für deine Hilfe im Kampf gegen Corona!",
176176
"text": "Wir übermitteln deinen Bericht...",
177-
"title": "Bericht abschicken"
177+
"title": "Bericht abschicken",
178+
"consent": "Durch das Abschicken des Reports akzeptiere ich, dass die angegebenen Informationen an die Server geschickt werden. Mehr Informationen beinhaltet die <1>Datenschutzerklärung</1>"
178179
},
179180
"symptoms": {
180181
"title": "Hast du irgendwelche Symptome?",

0 commit comments

Comments
 (0)