refactor(@angular/cli): fix & temporarily disable select lint errors

clydin · hansl · commit 7a11cec7f3a3 · 2018-06-05T17:55:19.000-07:00
diff --git a/packages/angular/cli/commands/add.ts b/packages/angular/cli/commands/add.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { tags, terminal } from '@angular-devkit/core';
 import { NodePackageDoesNotSupportSchematics } from '@angular-devkit/schematics/tools';
 import { CommandScope, Option } from '../models/command';
diff --git a/packages/angular/cli/commands/build.ts b/packages/angular/cli/commands/build.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 import { Version } from '../upgrade/version';
diff --git a/packages/angular/cli/commands/config.ts b/packages/angular/cli/commands/config.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import {
   InvalidJsonCharacterException,
   JsonArray,
@@ -247,6 +248,7 @@ export default class ConfigCommand extends Command {
     const [config, configPath] = getWorkspaceRaw(options.global ? 'global' : 'local');
     if (!config || !configPath) {
       this.logger.error('Confguration file cannot be found.');
+
       return 1;
     }
 
diff --git a/packages/angular/cli/commands/doc.ts b/packages/angular/cli/commands/doc.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { Command } from '../models/command';
 const opn = require('opn');
 
diff --git a/packages/angular/cli/commands/e2e.ts b/packages/angular/cli/commands/e2e.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/easter-egg.ts b/packages/angular/cli/commands/easter-egg.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { terminal } from '@angular-devkit/core';
 import { Command, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/eject.ts b/packages/angular/cli/commands/eject.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { tags } from '@angular-devkit/core';
 import { Command, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/generate.ts b/packages/angular/cli/commands/generate.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { tags, terminal } from '@angular-devkit/core';
 import { CommandScope, Option } from '../models/command';
 import { SchematicCommand } from '../models/schematic-command';
diff --git a/packages/angular/cli/commands/getset.ts b/packages/angular/cli/commands/getset.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { Command, Option } from '../models/command';
 
 export interface Options {
diff --git a/packages/angular/cli/commands/help.ts b/packages/angular/cli/commands/help.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { terminal } from '@angular-devkit/core';
 import { Command, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/lint.ts b/packages/angular/cli/commands/lint.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/new.ts b/packages/angular/cli/commands/new.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { CommandScope, Option } from '../models/command';
 import { SchematicCommand } from '../models/schematic-command';
 import { getDefaultSchematicCollection } from '../utilities/config';
diff --git a/packages/angular/cli/commands/run.ts b/packages/angular/cli/commands/run.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/serve.ts b/packages/angular/cli/commands/serve.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 import { Version } from '../upgrade/version';
diff --git a/packages/angular/cli/commands/test.ts b/packages/angular/cli/commands/test.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 
diff --git a/packages/angular/cli/commands/update.ts b/packages/angular/cli/commands/update.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { normalize } from '@angular-devkit/core';
 import { CommandScope, Option } from '../models/command';
 import { CoreSchematicOptions, SchematicCommand } from '../models/schematic-command';
diff --git a/packages/angular/cli/commands/version.ts b/packages/angular/cli/commands/version.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { terminal } from '@angular-devkit/core';
 import * as child_process from 'child_process';
 import * as fs from 'fs';
diff --git a/packages/angular/cli/commands/xi18n.ts b/packages/angular/cli/commands/xi18n.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';
 import { CommandScope, Option } from '../models/command';
 
diff --git a/packages/angular/cli/custom-typings.d.ts b/packages/angular/cli/custom-typings.d.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 declare module 'yargs-parser' {
   const parseOptions: any;
   const yargsParser: <T = any>(args: string | string[], options?: parseOptions) => T;
diff --git a/packages/angular/cli/lib/cli/index.ts b/packages/angular/cli/lib/cli/index.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { logging, terminal } from '@angular-devkit/core';
 import { filter } from 'rxjs/operators';
 import { runCommand } from '../../models/command-runner';
diff --git a/packages/angular/cli/lib/init.ts b/packages/angular/cli/lib/init.ts
@@ -5,7 +5,6 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-// @ignoreDep v8-profiler
 import 'symbol-observable';
 const isWarningEnabled = require('../utilities/config').isWarningEnabled;
 
diff --git a/packages/angular/cli/models/architect-command.ts b/packages/angular/cli/models/architect-command.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import {
   Architect,
   BuildEvent,
@@ -187,7 +187,7 @@ export abstract class ArchitectCommand extends Command<ArchitectCommandOptions>
             }
           }
           newErrors.push(schemaError);
-        };
+        }
 
         if (newErrors.length > 0) {
           this.logger.error(new schema.SchemaValidationException(newErrors).message);
diff --git a/packages/angular/cli/models/command-runner.ts b/packages/angular/cli/models/command-runner.ts
@@ -1,5 +1,6 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { logging, strings as coreStrings, tags } from '@angular-devkit/core';
+import * as yargsParser from 'yargs-parser';
 import {
   ArgumentStrategy,
   CommandConstructor,
@@ -9,8 +10,6 @@ import {
 } from '../models/command';
 import { insideProject } from '../utilities/project';
 
-import * as yargsParser from 'yargs-parser';
-
 
 export interface CommandMap {
   [key: string]: CommandConstructor;
diff --git a/packages/angular/cli/models/command.ts b/packages/angular/cli/models/command.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { logging, terminal } from '@angular-devkit/core';
 
 export interface CommandConstructor {
diff --git a/packages/angular/cli/models/error.ts b/packages/angular/cli/models/error.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 export class NgToolkitError extends Error {
   constructor(message?: string) {
     super();
diff --git a/packages/angular/cli/models/schematic-command.ts b/packages/angular/cli/models/schematic-command.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { JsonObject, experimental } from '@angular-devkit/core';
 import { normalize, strings, tags, terminal, virtualFs } from '@angular-devkit/core';
 import { NodeJsSyncHost } from '@angular-devkit/core/node';
diff --git a/packages/angular/cli/models/workspace-loader.ts b/packages/angular/cli/models/workspace-loader.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import {
   Path,
   basename,
diff --git a/packages/angular/cli/tasks/npm-install.ts b/packages/angular/cli/tasks/npm-install.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { logging, terminal } from '@angular-devkit/core';
 import { ModuleNotFoundException, resolve } from '@angular-devkit/core/node';
 import { spawn } from 'child_process';
diff --git a/packages/angular/cli/upgrade/version.ts b/packages/angular/cli/upgrade/version.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { tags, terminal } from '@angular-devkit/core';
 import * as path from 'path';
 import { SemVer, satisfies } from 'semver';
diff --git a/packages/angular/cli/utilities/check-package-manager.ts b/packages/angular/cli/utilities/check-package-manager.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { terminal } from '@angular-devkit/core';
 import { exec } from 'child_process';
 import { promisify } from 'util';
diff --git a/packages/angular/cli/utilities/config.ts b/packages/angular/cli/utilities/config.ts
@@ -1,8 +1,8 @@
+// tslint:disable:no-global-tslint-disable file-header
 import {
   JsonAstObject,
   JsonObject,
   JsonParseMode,
-  JsonValue,
   experimental,
   normalize,
   parseJson,
@@ -280,7 +280,7 @@ export function getDefaultSchematicCollection(): string {
 export function getSchematicDefaults(
   collection: string,
   schematic: string,
-  project?: string | null
+  project?: string | null,
 ): {} {
   let result = {};
   const fullName = `${collection}:${schematic}`;
diff --git a/packages/angular/cli/utilities/find-up.ts b/packages/angular/cli/utilities/find-up.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 import { existsSync } from 'fs';
 import * as path from 'path';
 
diff --git a/packages/angular/cli/utilities/project.ts b/packages/angular/cli/utilities/project.ts
@@ -1,4 +1,4 @@
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { normalize } from '@angular-devkit/core';
 import * as fs from 'fs';
 import * as os from 'os';
diff --git a/packages/angular/cli/utilities/require-project-module.ts b/packages/angular/cli/utilities/require-project-module.ts
@@ -1,3 +1,4 @@
+// tslint:disable:no-global-tslint-disable file-header
 
 // resolve dependencies within the target project
 export function resolveProjectModule(root: string, moduleName: string) {
diff --git a/packages/angular/cli/utilities/schematics.ts b/packages/angular/cli/utilities/schematics.ts
@@ -1,10 +1,4 @@
-/**
- * Refer to the angular shematics library to let the dependency validator
- * know it is used..
- *
- * require('@schematics/angular')
- */
-// tslint:disable:no-any
+// tslint:disable:no-global-tslint-disable no-any file-header
 import { schema } from '@angular-devkit/core';
 import {
   Collection,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// tslint:disable:no-any`
	`1`	`+// tslint:disable:no-global-tslint-disable no-any file-header`
`2`	`2`	`import { tags, terminal } from '@angular-devkit/core';`
`3`	`3`	`import { NodePackageDoesNotSupportSchematics } from '@angular-devkit/schematics/tools';`
`4`	`4`	`import { CommandScope, Option } from '../models/command';`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// tslint:disable:no-global-tslint-disable file-header`
`1`	`2`	`import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command';`
`2`	`3`	`import { CommandScope, Option } from '../models/command';`
`3`	`4`	`import { Version } from '../upgrade/version';`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// tslint:disable:no-global-tslint-disable file-header`
`1`	`2`	`import { Command } from '../models/command';`
`2`	`3`	`const opn = require('opn');`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// tslint:disable:no-global-tslint-disable file-header`
`1`	`2`	`import { terminal } from '@angular-devkit/core';`
`2`	`3`	`import { Command, Option } from '../models/command';`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// tslint:disable:no-global-tslint-disable file-header`
`1`	`2`	`import { tags } from '@angular-devkit/core';`
`2`	`3`	`import { Command, Option } from '../models/command';`
`3`	`4`