fix(@angular/cli): ensure all architect schema errors are propagated

clydin · hansl · commit c69981f46e69 · 2018-06-05T17:55:19.000-07:00
diff --git a/packages/angular/cli/models/architect-command.ts b/packages/angular/cli/models/architect-command.ts
@@ -166,12 +166,12 @@ export abstract class ArchitectCommand extends Command<ArchitectCommandOptions>
       if (!targetSpec.project && this.target) {
         // This runs each target sequentially.
         // Running them in parallel would jumble the log messages.
-        return from(this.getProjectNamesByTarget(this.target)).pipe(
+        return await from(this.getProjectNamesByTarget(this.target)).pipe(
           concatMap(project => runSingleTarget({ ...targetSpec, project })),
           toArray(),
         ).toPromise().then(results => results.every(res => res === 0) ? 0 : 1);
       } else {
-        return runSingleTarget(targetSpec).toPromise();
+        return await runSingleTarget(targetSpec).toPromise();
       }
     } catch (e) {
       if (e instanceof schema.SchemaValidationException) {
@@ -182,8 +182,6 @@ export abstract class ArchitectCommand extends Command<ArchitectCommandOptions>
             if (unknownProperty in options) {
               const dashes = unknownProperty.length === 1 ? '-' : '--';
               this.logger.fatal(`Unknown option: '${dashes}${unknownProperty}'`);
-
-              break;
             }
           }
           newErrors.push(schemaError);
diff --git a/tests/legacy-cli/e2e/tests/commands/unknown-option.ts b/tests/legacy-cli/e2e/tests/commands/unknown-option.ts
@@ -1,9 +1,12 @@
-import { ng } from '../../utils/process';
+import { execAndWaitForOutputToMatch, ng } from '../../utils/process';
+import { expectToFail } from '../../utils/utils';
 
 export default async function() {
-  const { stderr } = await ng('build', '--notanoption');
+  // await expectToFail(() => ng('build', '--notanoption'));
 
-  if (!stderr.match(/Unknown option: '--notanoption'/)) {
-    throw new Error(`Expected "Unknown option:", received "${JSON.stringify(stderr)}".`);
-  }
+  await execAndWaitForOutputToMatch(
+    'ng',
+    [ 'build', '--notanoption' ],
+    /Unknown option: '--notanoption'/,
+  );
 }
