Fix issues found by ebert

Mohamed Seleem · Mohamed Seleem · commit 39a3e3d2d6d6 · 2017-10-22T13:43:57.000+02:00
diff --git a/src/javascript/lib/core/erlang_compat/filename.js b/src/javascript/lib/core/erlang_compat/filename.js
@@ -5,7 +5,7 @@ function join(arg, extra = null) {
     const name = components[i];
     const normalized_name = name.replace(/\/+/g, '/').replace(/^\/|\/$/g, '');
     names.push(normalized_name);
-    if (name[0] == '/') {
+    if (name[0] === '/') {
       names.push('');
       break;
     }
@@ -16,7 +16,7 @@ function join(arg, extra = null) {
 function dirname(arg) {
   const path = join([arg]);
   const index = path.lastIndexOf('/');
-  return index == -1 ? '.' : path.substr(0, index) || '/';
+  return index === -1 ? '.' : (path.substr(0, index) || '/');
 }
 
 export default {
diff --git a/src/javascript/tests/core/erlang_compat/filename_spec.js b/src/javascript/tests/core/erlang_compat/filename_spec.js
@@ -27,6 +27,6 @@ test('join/1', (t) => {
 });
 
 test('join/2', (t) => {
-  let result = Core.filename.join('/usr', 'bin');
+  const result = Core.filename.join('/usr', 'bin');
   t.is(result, '/usr/bin');
 });
