Remove some credo warnings

joeellis · joeellis · commit 8410fd4d817d · 2017-05-29T14:59:11.000-05:00
diff --git a/.credo.exs b/.credo.exs
@@ -98,9 +98,9 @@
         {Credo.Check.Refactor.NegatedConditionsInUnless},
         {Credo.Check.Refactor.NegatedConditionsWithElse},
         {Credo.Check.Refactor.Nesting},
-        {Credo.Check.Refactor.PipeChainStart},
+        {Credo.Check.Refactor.PipeChainStart, false},
         {Credo.Check.Refactor.UnlessWithElse},
-        {Credo.Check.Refactor.VariableRebinding},
+        {Credo.Check.Refactor.VariableRebinding, false},
 
         {Credo.Check.Warning.BoolOperationOnSameValues},
         {Credo.Check.Warning.IExPry},
diff --git a/lib/elixir_script/cli.ex b/lib/elixir_script/cli.ex
@@ -45,9 +45,9 @@ defmodule ElixirScript.CLI do
 
   options:
   --js-module [<identifer>:<path>] A js module used in your code. ex: React:react
-                        Multiple can be defined 
+                        Multiple can be defined
   -f  --format [format] module format of output. options: es (default), common, umd
-  -o  --output [path]   places output at the given path. 
+  -o  --output [path]   places output at the given path.
                         Can be a directory or filename.
   -e  --elixir          read input as elixir code string
   --remove-unused       Removes unused modules from output
@@ -121,8 +121,8 @@ defmodule ElixirScript.CLI do
 
   defp build_js_modules(values) do
     values
-    |> Enum.map(fn x -> 
-      [identifier, path] = String.split(x,":", trim: true)
+    |> Enum.map(fn x ->
+      [identifier, path] = String.split(x, ":", trim: true)
       { format_identifier(identifier), format_path(path) }
     end)
   end
@@ -132,7 +132,7 @@ defmodule ElixirScript.CLI do
     |> String.split(".")
     |> Module.concat
   end
-  
+
 
   defp format_path(path) do
     path
diff --git a/lib/elixir_script/passes/java_script_ast.ex b/lib/elixir_script/passes/java_script_ast.ex
@@ -8,12 +8,12 @@ defmodule ElixirScript.Passes.JavaScriptAST do
     State.set_module_data(compiler_data.state, compiler_data.data)
     State.set_loaded_modules(compiler_data.state, Map.get(compiler_data, :loaded_modules, []))
 
-    data = compiler_data.state 
+    data = compiler_data.state
     |> State.get_module_data
-    |> Enum.reject(fn {_,module_data} ->
+    |> Enum.reject(fn {_, module_data} ->
       module_data.app == :elixir && opts.import_standard_libs == false
     end)
-    |> Enum.map(fn({module_name, module_data}) -> 
+    |> Enum.map(fn({module_name, module_data}) ->
         module_data = compile(module_data, opts, compiler_data.state)
         {module_name, module_data}
     end)
diff --git a/lib/elixir_script/passes/java_script_code.ex b/lib/elixir_script/passes/java_script_code.ex
@@ -1,6 +1,7 @@
 defmodule ElixirScript.Passes.JavaScriptCode do
   @moduledoc false
-  alias ESTree.Tools.{Builder, Generator}
+  alias ESTree.Tools.Builder
+  alias ESTree.Tools.Generator
 
   def execute(compiler_data, _) do
     parent = self
diff --git a/lib/elixir_script/translator/kernel/special_forms/bitstring.ex b/lib/elixir_script/translator/kernel/special_forms/bitstring.ex
@@ -120,7 +120,7 @@ defmodule ElixirScript.Translator.Bitstring do
   end
 
   def make_interpolated_string(elements, env) do
-    translated_elements = Enum.map(elements, fn(x)->
+    translated_elements = Enum.map(elements, fn(x) ->
       case x do
         elem when is_binary(elem) ->
           Translator.translate!(elem, env)
diff --git a/lib/elixir_script/translator/kernel/special_forms/fn.ex b/lib/elixir_script/translator/kernel/special_forms/fn.ex
@@ -30,7 +30,7 @@ defmodule ElixirScript.Translator.Function do
 
       ({_, _, [{:when, _, [{_, _, params}, guards]}, body]}) ->
         body = convert_to_try(body)
-        process_function_body(params, body, env, name, guards)     
+        process_function_body(params, body, env, name, guards)
 
       ({_, _, [{_, _, params}, body]}) ->
         body = convert_to_try(body)
@@ -212,7 +212,7 @@ defmodule ElixirScript.Translator.Function do
 
         return_statement = case declaration do
           %ESTree.ArrayPattern{elements: elements} ->
-            if(length(elements) == 1) do
+            if length(elements) == 1 do
               JS.return_statement(hd(declaration.elements))
             else
               JS.return_statement(JS.array_expression(declaration.elements))
@@ -233,7 +233,7 @@ defmodule ElixirScript.Translator.Function do
     end
 
 
-    list = Enum.take(list, length(list)-1)
+    list = Enum.take(list, length(list) - 1)
     |> Enum.map(fn(x) ->
       case x do
         %ESTree.MemberExpression{} ->
diff --git a/lib/elixir_script/translator/kernel/special_forms/quote.ex b/lib/elixir_script/translator/kernel/special_forms/quote.ex
@@ -15,7 +15,7 @@ defmodule ElixirScript.Translator.Quote do
       (_) -> false
     end)
 
-    if(has_unquote_splicing) do
+    if has_unquote_splicing do
       expr = Enum.map(expr, fn
         ({:unquote_splicing, _, [param]}) ->
           make_unquote_slicing(param, env)
diff --git a/lib/elixir_script/watcher.ex b/lib/elixir_script/watcher.ex
@@ -23,7 +23,7 @@ defmodule ElixirScript.Watcher do
 
     try do
       if input_changed?(to_string(path), state) do
-        Logger.debug "Event: #{inspect event} Path: #{path}"
+        Logger.debug fn -> "Event: #{inspect event} Path: #{path}" end
         ElixirScript.compile_path(state[:input], state[:options])
       end
     rescue
