Rename foreign to defexternal

bryanjos · bryanjos · commit 9adeb3b7aa32 · 2017-08-03T20:30:25.000-05:00
diff --git a/JavascriptInterop.md b/JavascriptInterop.md
@@ -25,12 +25,12 @@ Here is an example of a foreign module for a JSON module
 defmodule MyApp.JSON do
   use ElixirScript.FFI
 
-  foreign stringify(map)
-  foreign parse(string)
+  defexternal stringify(map)
+  defexternal parse(string)
 end
 ```
 
-Foreign modules map to JavaScript files that export functions defined with the `foreign` macro.
+Foreign modules map to JavaScript files that export functions defined with the `defexternal` macro.
 ElixirScript expects JavaScript modules to be in the `priv/elixir_script` directory.
 These modules are copied to the output directory upon compilation.
 
diff --git a/lib/elixir_script/compiler.ex b/lib/elixir_script/compiler.ex
@@ -16,17 +16,13 @@ defmodule ElixirScript.Compiler do
 
     entry_modules = List.wrap(entry_modules)
 
-    IO.puts "Finding used modules"
     ElixirScript.FindUsedModules.execute(entry_modules, pid)
 
-    IO.puts "Finding used functions"
     ElixirScript.FindUsedFunctions.execute(entry_modules, pid)
 
-    IO.puts "Compiling"
     modules = ElixirScript.State.list_modules(pid)
     ElixirScript.Translate.execute(modules, pid)
 
-    IO.puts "Building Output"
     modules = ElixirScript.State.list_modules(pid)
     result = ElixirScript.Output.execute(modules, pid)
 
@@ -56,4 +52,4 @@ defmodule ElixirScript.Compiler do
   defp get_module_formatter(_) do
     ElixirScript.ModuleSystems.ES
   end
-end
+end
diff --git a/lib/elixir_script/ffi.ex b/lib/elixir_script/ffi.ex
@@ -3,20 +3,20 @@ defmodule ElixirScript.FFI do
   The foreign function interface for interacting with JavaScript
 
   To define a foreign module, make a new module and add `use ElixirScript.FFI`. to it
-  To define foreign functions, use the `foreign` macro.
+  To define external functions, use the `defexternal` macro.
 
   Here is an example of a foreign module for a JSON module
 
   ```elixir
   defmodule MyApp.JSON do
     use ElixirScript.FFI
 
-    foreign stringify(map)
-    foreign parse(string)
+    defexternal stringify(map)
+    defexternal parse(string)
   end
   ```
 
-  Foreign modules map to JavaScript files that export functions defined with the `foreign` macro.
+  Foreign modules map to JavaScript files that export functions defined with the `defexternal` macro.
   ElixirScript expects JavaScript modules to be in the `priv/elixir_script` directory.
   These modules are copied to the output directory upon compilation.
 
@@ -46,13 +46,13 @@ defmodule ElixirScript.FFI do
   @doc """
   Defines a JavaScript function to be called from Elixir modules
 
-  To define a foreign function, pass the name and arguments to `foreign`
+  To define an external function, pass the name and arguments to `defexternal`
 
   ```elixir
-  foreign my_js_function(arg1, arg2, arg3)
+  defexternal my_js_function(arg1, arg2, arg3)
   ```
   """
-  defmacro foreign({name, _, args}) do
+  defmacro defexternal({name, _, args}) do
     args = Enum.map(args, fn
       {:\\, meta0, [{name, meta, atom}, value]}->
         name = String.to_atom("_" <> Atom.to_string(name))
diff --git a/lib/elixir_script/lib/store.ex b/lib/elixir_script/lib/store.ex
@@ -2,11 +2,11 @@ defmodule ElixirScript.Core.Store do
   @moduledoc false
   use ElixirScript.FFI, global: true
 
-  foreign create(value, name \\ nil)
+  defexternal create(value, name \\ nil)
 
-  foreign update(key, value)
+  defexternal update(key, value)
 
-  foreign read(key)
+  defexternal read(key)
 
-  foreign remove(key)
+  defexternal remove(key)
 end
diff --git a/test/ffi_test.exs b/test/ffi_test.exs
@@ -4,7 +4,7 @@ defmodule ElixirScript.FFI.Test do
   defmodule MyTestModule do
     use ElixirScript.FFI
 
-    foreign my_test_function(arg1, arg2)
+    defexternal my_test_function(arg1, arg2)
   end
 
   test "FFI module has __foreign_info__ attribute" do
@@ -14,4 +14,4 @@ defmodule ElixirScript.FFI.Test do
   test "FFI module makes foreign function" do
     assert Keyword.has_key?(MyTestModule.__info__(:functions), :my_test_function)
   end
-end
+end
