Skip to content

Commit a9eae95

Browse files
author
Mohamed Seleem
committed
Fix filename.join/2 signature
1 parent f39e21c commit a9eae95

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/javascript/lib/core/erlang_compat/filename.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
function join(arg = [], extra = []) {
2-
let components = Array.isArray(arg) ? arg : [arg];
3-
components = components.concat(extra)
1+
function join(arg, extra = null) {
2+
const components = Array.isArray(arg) ? arg : [arg, extra];
43
let names = [];
54
for (let i = components.length - 1; i >= 0; i--) {
65
const name = components[i];

src/javascript/tests/core/erlang_compat/filename_spec.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,8 @@ test('join/1', (t) => {
1919
result = Core.filename.join(['a/b///c/']);
2020
t.is(result, 'a/b/c');
2121
});
22+
23+
test('join/2', (t) => {
24+
let result = Core.filename.join('/usr', 'bin');
25+
t.is(result, '/usr/bin');
26+
});

0 commit comments

Comments
 (0)