Disable "no-console" linting for specific console.warns

workingjubilee · workingjubilee · commit fab74b8b187c · 2019-08-20T00:35:49.000-07:00
These all are exceptional cases of warnings where the warning is
far more important than adhering to a style guide on lints, even if
some of them might potentially show up in the browser. Each is a
hand-picked exception, so these use in-file comment overrides.

Rationales are included in preceding comments.
diff --git a/src/javascript/lib/core.js b/src/javascript/lib/core.js
@@ -27,7 +27,12 @@ function get_global() {
     return global;
   }
 
+  /* As long as the window check precedes this, it won't display in a browser,
+     unless the ground cracks open and swallows JavaScript whole. */
+  /* eslint-disable no-console */
   console.warn('No global state found');
+  /* eslint-enable no-console */
+
   return null;
 }
 
diff --git a/src/javascript/lib/core/erlang_compat/elixir_errors.js b/src/javascript/lib/core/erlang_compat/elixir_errors.js
@@ -1,7 +1,11 @@
+/* It is far too "meta" to warn about including a warning in a warning */
+/* eslint-disable no-console */
+
 function warn(message) {
   const messageString = message.join('');
   console.warn(`warning: ${messageString}`);
 
+
   return Symbol.for('ok');
 }
 
diff --git a/src/javascript/lib/core/erlang_compat/io.js b/src/javascript/lib/core/erlang_compat/io.js
@@ -1,3 +1,5 @@
+/* The purpose of this module is, in fact, to do IO. */
+/* eslint-disable no-console */
 import erlang from './erlang';
 
 function put_chars(ioDevice, charData) {
diff --git a/src/javascript/lib/core/special_forms.js b/src/javascript/lib/core/special_forms.js
@@ -138,7 +138,10 @@ function _with(...args) {
 }
 
 function receive(clauses, timeout = 0, timeoutFn = () => true) {
+  /* It's more important to warn developers than follow style guides */
+  /* eslint-disable no-console */
   console.warn('Receive not supported');
+  /* eslint-enable no-console */
 
   const messages = []; // this.mailbox.get();
   const NOMATCH = Symbol('NOMATCH');

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,12 @@ function get_global() {`
`27`	`27`	`return global;`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ /* As long as the window check precedes this, it won't display in a browser,`
	`31`	`+ unless the ground cracks open and swallows JavaScript whole. */`
	`32`	`+ /* eslint-disable no-console */`
`30`	`33`	`console.warn('No global state found');`
	`34`	`+ /* eslint-enable no-console */`
	`35`	`+`
`31`	`36`	`return null;`
`32`	`37`	`}`
`33`	`38`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* The purpose of this module is, in fact, to do IO. */`
	`2`	`+/* eslint-disable no-console */`
`1`	`3`	`import erlang from './erlang';`
`2`	`4`
`3`	`5`	`function put_chars(ioDevice, charData) {`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,10 @@ function _with(...args) {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`function receive(clauses, timeout = 0, timeoutFn = () => true) {`
	`141`	`+ /* It's more important to warn developers than follow style guides */`
	`142`	`+ /* eslint-disable no-console */`
`141`	`143`	`console.warn('Receive not supported');`
	`144`	`+ /* eslint-enable no-console */`
`142`	`145`
`143`	`146`	`const messages = []; // this.mailbox.get();`
`144`	`147`	`const NOMATCH = Symbol('NOMATCH');`