JAVA-31265 Review log statements for projects - Week 8 - 2024 (eugenp#15939)

timis1 · web-flow · commit 3642db8f5fbd · 2024-02-21T23:37:25.000+01:00
diff --git a/apache-libraries-2/src/main/resources/logback.xml b/apache-libraries-2/src/main/resources/logback.xml
@@ -10,4 +10,6 @@
     <root level="INFO">
         <appender-ref ref="STDOUT" />
     </root>
+
+    <logger name="org.apache.camel.impl.engine" level="WARN"/>
 </configuration>
diff --git a/apache-libraries-2/src/test/resources/logback-test.xml b/apache-libraries-2/src/test/resources/logback-test.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
+            </pattern>
+        </encoder>
+    </appender>
+
+    <root level="INFO">
+        <appender-ref ref="STDOUT" />
+    </root>
+
+    <logger name="ch.qos.logback.classic.joran.action" level="WARN"/>
+</configuration>
diff --git a/core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/io/TraverseFileTreeUnitTest.groovy b/core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/io/TraverseFileTreeUnitTest.groovy
@@ -1,61 +1,71 @@
 package com.baeldung.io
 
-import org.junit.Test
-
 import groovy.io.FileType
 import groovy.io.FileVisitResult
+import org.junit.Test
+
+import static org.junit.Assert.assertTrue
 
 class TraverseFileTreeUnitTest {
     @Test
     void whenUsingEachFile_filesAreListed() {
+        var files = []
         new File('src/main/resources').eachFile { file ->
-            println file.name
+            files.add(file.name)
         }
+        assertTrue(files.size() > 1)
     }
     
     @Test(expected = IllegalArgumentException)
     void whenUsingEachFileOnAFile_anErrorOccurs() {
+        var files = []
         new File('src/main/resources/ioInput.txt').eachFile { file ->
-            println file.name
+            files.add(file.name)
         }
     }
     
     @Test
     void whenUsingEachFileMatch_filesAreListed() {
+        var files = []
         new File('src/main/resources').eachFileMatch(~/io.*\.txt/) { file ->
-            println file.name
+            files.add(file.name)
         }
     }
-    
+
     @Test
     void whenUsingEachFileRecurse_thenFilesInSubfoldersAreListed() {
+        var files = []
         new File('src/main').eachFileRecurse(FileType.FILES) { file ->
-            println "$file.parent $file.name"
+            files.add("$file.parent $file.name")
         }
     }
-    
+
     @Test
     void whenUsingEachFileRecurse_thenDirsInSubfoldersAreListed() {
+        var files = []
         new File('src/main').eachFileRecurse(FileType.DIRECTORIES) { file ->
-            println "$file.parent $file.name"
+            files.add("$file.parent $file.name")
         }
     }
-    
+
     @Test
     void whenUsingEachDirRecurse_thenDirsAndSubDirsAreListed() {
+        var files = []
         new File('src/main').eachDirRecurse { dir ->
-            println "$dir.parent $dir.name"
+            files.add("$dir.parent $dir.name")
         }
     }
-    
+
     @Test
     void whenUsingTraverse_thenDirectoryIsTraversed() {
+        var files = []
         new File('src/main').traverse { file ->
             if (file.directory && file.name == 'groovy') {
                 FileVisitResult.SKIP_SUBTREE
             } else {
-                println "$file.parent - $file.name"
+                files.add("$file.parent - $file.name")
             }
         }
+        assertTrue(files.size() > 1)
     }
 }
diff --git a/core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/stringtypes/DollarSlashyString.groovy b/core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/stringtypes/DollarSlashyString.groovy
@@ -2,6 +2,8 @@ package groovy.com.baeldung.stringtypes
 
 import org.junit.Test
 
+import static org.junit.Assert.assertFalse
+
 class DollarSlashyString {
 
     @Test
@@ -19,6 +21,7 @@ class DollarSlashyString {
             - $/$$
         /$
 
-        print(dollarSlashy)
+        //print(dollarSlashy)
+        assertFalse(dollarSlashy.isEmpty())
     }
 }
diff --git a/core-java-modules/core-java-collections/src/test/java/com/baeldung/hashtable/HashtableUnitTest.java b/core-java-modules/core-java-collections/src/test/java/com/baeldung/hashtable/HashtableUnitTest.java
@@ -60,14 +60,15 @@ public void whenIterate_thenFailFast() {
         table.put(new Word("dog"), "another animal");
 
         Iterator<Word> it = table.keySet().iterator();
-        System.out.println("iterator created");
+        // System.out.println("iterator created");
 
         table.remove(new Word("dog"));
-        System.out.println("element removed");
+        // System.out.println("element removed");
 
         while (it.hasNext()) {
             Word key = it.next();
-            System.out.println(table.get(key));
+            // System.out.println(table.get(key));
+            assertNotNull(table.get(key));
         }
     }
 
@@ -85,12 +86,13 @@ public void whenEnumerate_thenNotFailFast() {
         table.put(new Word("8"), "eight");
 
         Enumeration<Word> enumKey = table.keys();
-        System.out.println("Enumeration created");
+        // System.out.println("Enumeration created");
         table.remove(new Word("1"));
-        System.out.println("element removed");
+        // System.out.println("element removed");
         while (enumKey.hasMoreElements()) {
             Word key = enumKey.nextElement();
-            System.out.println(table.get(key));
+            // System.out.println(table.get(key));
+            assertNotNull(table.get(key));
         }
     }
 
@@ -110,7 +112,8 @@ public void whenAddElements_thenIterationOrderUnpredicable() {
         Iterator<Map.Entry<Word, String>> it = table.entrySet().iterator();
         while (it.hasNext()) {
             Map.Entry<Word, String> entry = it.next();
-            System.out.println(entry.getValue());
+            // System.out.println(entry.getValue());
+            assertNotNull(entry.getValue());
         }
     }
 
diff --git a/core-java-modules/core-java-concurrency-simple/src/test/resources/logback.xml b/core-java-modules/core-java-concurrency-simple/src/test/resources/logback.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
+            </pattern>
+        </encoder>
+    </appender>
+
+    <root level="INFO">
+        <appender-ref ref="STDOUT" />
+    </root>
+</configuration>
diff --git a/core-java-modules/core-java-httpclient/src/test/resources/logback.xml b/core-java-modules/core-java-httpclient/src/test/resources/logback.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
+            </pattern>
+        </encoder>
+    </appender>
+
+    <root level="INFO">
+        <appender-ref ref="STDOUT" />
+    </root>
+
+    <logger name="org.eclipse.jetty.server.handler" level="WARN"/>
+    <logger name="org.mockserver.log" level="WARN"/>
+</configuration>
diff --git a/core-java-modules/core-java-security-4/src/main/java/com/baeldung/enablessldebug/SSLDebugLogger.java b/core-java-modules/core-java-security-4/src/main/java/com/baeldung/enablessldebug/SSLDebugLogger.java
@@ -23,9 +23,9 @@ public static void makeHttpsRequest() throws Exception {
 
         try (BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
             String line;
-            logger.info("Response from " + url + ":");
+            logger.debug("Response from " + url + ":");
             while ((line = reader.readLine()) != null) {
-                logger.info(line);
+                logger.debug(line);
             }
         }
     }
diff --git a/core-java-modules/core-java-security-4/src/test/resources/logback.xml b/core-java-modules/core-java-security-4/src/test/resources/logback.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
+            </pattern>
+        </encoder>
+    </appender>
+
+    <root level="INFO">
+        <appender-ref ref="STDOUT" />
+    </root>
+</configuration>
diff --git a/spring-web-modules/spring-session/spring-session-mongodb/src/test/resources/logback.xml b/spring-web-modules/spring-session/spring-session-mongodb/src/test/resources/logback.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
+            </pattern>
+        </encoder>
+    </appender>
+
+    <root level="INFO">
+        <appender-ref ref="STDOUT" />
+    </root>
+
+    <logger name="org.springframework.boot.test.context" level="WARN"/>
+    <logger name="o.s.b.a.mongo.embedded" level="WARN"/>
+
+</configuration>

Original file line number	Diff line number	Diff line change
`@@ -1,61 +1,71 @@`
`1`	`1`	`package com.baeldung.io`
`2`	`2`
`3`		`-import org.junit.Test`
`4`		`-`
`5`	`3`	`import groovy.io.FileType`
`6`	`4`	`import groovy.io.FileVisitResult`
	`5`	`+import org.junit.Test`
	`6`	`+`
	`7`	`+import static org.junit.Assert.assertTrue`
`7`	`8`
`8`	`9`	`class TraverseFileTreeUnitTest {`
`9`	`10`	`@Test`
`10`	`11`	`void whenUsingEachFile_filesAreListed() {`
	`12`	`+ var files = []`
`11`	`13`	`new File('src/main/resources').eachFile { file ->`
`12`		`- println file.name`
	`14`	`+ files.add(file.name)`
`13`	`15`	`}`
	`16`	`+ assertTrue(files.size() > 1)`
`14`	`17`	`}`
`15`	`18`
`16`	`19`	`@Test(expected = IllegalArgumentException)`
`17`	`20`	`void whenUsingEachFileOnAFile_anErrorOccurs() {`
	`21`	`+ var files = []`
`18`	`22`	`new File('src/main/resources/ioInput.txt').eachFile { file ->`
`19`		`- println file.name`
	`23`	`+ files.add(file.name)`
`20`	`24`	`}`
`21`	`25`	`}`
`22`	`26`
`23`	`27`	`@Test`
`24`	`28`	`void whenUsingEachFileMatch_filesAreListed() {`
	`29`	`+ var files = []`
`25`	`30`	`new File('src/main/resources').eachFileMatch(~/io.*\.txt/) { file ->`
`26`		`- println file.name`
	`31`	`+ files.add(file.name)`
`27`	`32`	`}`
`28`	`33`	`}`
`29`		`-`
	`34`	`+`
`30`	`35`	`@Test`
`31`	`36`	`void whenUsingEachFileRecurse_thenFilesInSubfoldersAreListed() {`
	`37`	`+ var files = []`
`32`	`38`	`new File('src/main').eachFileRecurse(FileType.FILES) { file ->`
`33`		`- println "$file.parent $file.name"`
	`39`	`+ files.add("$file.parent $file.name")`
`34`	`40`	`}`
`35`	`41`	`}`
`36`		`-`
	`42`	`+`
`37`	`43`	`@Test`
`38`	`44`	`void whenUsingEachFileRecurse_thenDirsInSubfoldersAreListed() {`
	`45`	`+ var files = []`
`39`	`46`	`new File('src/main').eachFileRecurse(FileType.DIRECTORIES) { file ->`
`40`		`- println "$file.parent $file.name"`
	`47`	`+ files.add("$file.parent $file.name")`
`41`	`48`	`}`
`42`	`49`	`}`
`43`		`-`
	`50`	`+`
`44`	`51`	`@Test`
`45`	`52`	`void whenUsingEachDirRecurse_thenDirsAndSubDirsAreListed() {`
	`53`	`+ var files = []`
`46`	`54`	`new File('src/main').eachDirRecurse { dir ->`
`47`		`- println "$dir.parent $dir.name"`
	`55`	`+ files.add("$dir.parent $dir.name")`
`48`	`56`	`}`
`49`	`57`	`}`
`50`		`-`
	`58`	`+`
`51`	`59`	`@Test`
`52`	`60`	`void whenUsingTraverse_thenDirectoryIsTraversed() {`
	`61`	`+ var files = []`
`53`	`62`	`new File('src/main').traverse { file ->`
`54`	`63`	`if (file.directory && file.name == 'groovy') {`
`55`	`64`	`FileVisitResult.SKIP_SUBTREE`
`56`	`65`	`} else {`
`57`		`- println "$file.parent - $file.name"`
	`66`	`+ files.add("$file.parent - $file.name")`
`58`	`67`	`}`
`59`	`68`	`}`
	`69`	`+ assertTrue(files.size() > 1)`
`60`	`70`	`}`
`61`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,8 @@ package groovy.com.baeldung.stringtypes`
`2`	`2`
`3`	`3`	`import org.junit.Test`
`4`	`4`
	`5`	`+import static org.junit.Assert.assertFalse`
	`6`	`+`
`5`	`7`	`class DollarSlashyString {`
`6`	`8`
`7`	`9`	`@Test`
`@@ -19,6 +21,7 @@ class DollarSlashyString {`
`19`	`21`	`- $/$$`
`20`	`22`	`/$`
`21`	`23`
`22`		`- print(dollarSlashy)`
	`24`	`+ //print(dollarSlashy)`
	`25`	`+ assertFalse(dollarSlashy.isEmpty())`
`23`	`26`	`}`
`24`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,9 @@ public static void makeHttpsRequest() throws Exception {`
`23`	`23`
`24`	`24`	`try (BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {`
`25`	`25`	`String line;`
`26`		`- logger.info("Response from " + url + ":");`
	`26`	`+ logger.debug("Response from " + url + ":");`
`27`	`27`	`while ((line = reader.readLine()) != null) {`
`28`		`- logger.info(line);`
	`28`	`+ logger.debug(line);`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`	`}`