refactor: fix pipe type

dgp1130 · dgp1130 · commit 79821006b81a · 2024-06-27T11:21:30.000-07:00
An explicit cast was removed in angular@fa9bce0#diff-29e41c6172a2d68db9886be9e933ed2b477732095313e104c52a725f887276cf which relies on [control flow narrowing](https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#control-flow-narrowing-for-constant-indexed-accesses) in TS 5.5. However, google3 is still on TS 5.4, so we can't fully depend on that feature. Using an intermediate variable makes the type narrowing work correctly even in TS 5.4.
diff --git a/packages/angular_devkit/schematics/src/rules/template.ts b/packages/angular_devkit/schematics/src/rules/template.ts
@@ -133,12 +133,13 @@ export function applyPathTemplate<T extends PathTemplateData>(
           if (!(pipe in data)) {
             throw new UnknownPipeException(pipe);
           }
-          if (typeof data[pipe] != 'function') {
+          const pipeFn = data[pipe];
+          if (typeof pipeFn != 'function') {
             throw new InvalidPipeException(pipe);
           }
 
           // Coerce to string.
-          return '' + data[pipe](acc);
+          return '' + pipeFn(acc);
         }, '' + replacement);
       }
 

Original file line number	Diff line number	Diff line change
`@@ -133,12 +133,13 @@ export function applyPathTemplate<T extends PathTemplateData>(`
`133`	`133`	`if (!(pipe in data)) {`
`134`	`134`	`throw new UnknownPipeException(pipe);`
`135`	`135`	`}`
`136`		`- if (typeof data[pipe] != 'function') {`
	`136`	`+ const pipeFn = data[pipe];`
	`137`	`+ if (typeof pipeFn != 'function') {`
`137`	`138`	`throw new InvalidPipeException(pipe);`
`138`	`139`	`}`
`139`	`140`
`140`	`141`	`// Coerce to string.`
`141`		`- return '' + data[pipe](acc);`
	`142`	`+ return '' + pipeFn(acc);`
`142`	`143`	`}, '' + replacement);`
`143`	`144`	`}`
`144`	`145`