Fixing lints

bryanjos · bryanjos · commit 9733a056d88b · 2017-09-09T03:44:54.000-05:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -6,6 +6,7 @@ module.exports = {
     'no-restricted-syntax': 'off',
     'no-underscore-dangle': 'off',
     'import/extensions': 'off',
+    'import/no-extraneous-dependencies': ['error', { devDependencies: false }],
   },
   extends: 'airbnb-base',
   plugins: ['import'],
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
@@ -10,15 +10,15 @@ function copy(subject, n = 1) {
 }
 
 function first(subject) {
-  if (subject.length == 0) {
-    throw new Error(`Binary is of length 0`);
+  if (subject.length === 0) {
+    throw new Error('Binary is of length 0');
   }
   return at(subject, 0);
 }
 
 function last(subject) {
-  if (subject.length == 0) {
-    throw new Error(`Binary is of length 0`);
+  if (subject.length === 0) {
+    throw new Error('Binary is of length 0');
   }
   return subject.slice(-1);
 }
@@ -29,20 +29,19 @@ function list_to_bin(bytelist) {
 
 function part(subject, posOrTuple, len = null) {
   if (len === null) {
-    var pos;
-    [pos, len] = posOrTuple.values;
-    return subject.substr(pos, len);
-  } else {
-    return subject.substr(posOrTuple, len);
+    const [pos, theLen] = posOrTuple.values;
+    return subject.substr(pos, theLen);
   }
+
+  return subject.substr(posOrTuple, len);
 }
 
-//TODO: Support more options
-//TODO: pattern cannot be list of strings
+// TODO: Support more options
+// TODO: pattern cannot be list of strings
 function replace(subject, pattern, replacement, options = []) {
   const opt_global = proplists.get_value(Symbol.for('global'), options);
 
-  var regex;
+  let regex;
   if (opt_global !== Symbol.for('undefined')) {
     regex = new RegExp(pattern, 'g');
   } else {
@@ -52,8 +51,8 @@ function replace(subject, pattern, replacement, options = []) {
   return subject.replace(regex, replacement);
 }
 
-//TODO: Support more options, global is implied
-//TODO: pattern cannot be list of strings
+// TODO: Support more options, global is implied
+// TODO: pattern cannot be list of strings
 function split(subject, pattern, options = []) {
   return subject.split(pattern);
 }
diff --git a/src/javascript/tests/core/erlang_compat/binary_spec.js b/src/javascript/tests/core/erlang_compat/binary_spec.js
@@ -55,7 +55,9 @@ test('replace/3', (t) => {
 });
 
 test('replace/4', (t) => {
-  const result = Core.binary.replace('abcb', 'b', 'c', [new Core.Tuple(Symbol.for('global'), true)]);
+  const result = Core.binary.replace('abcb', 'b', 'c', [
+    new Core.Tuple(Symbol.for('global'), true),
+  ]);
   t.deepEqual(result, 'accc');
 });
 
