Skip to content

Commit 46fe093

Browse files
committed
Removed all Sysout's instead using SLF4J logger
1 parent ab79a6b commit 46fe093

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

spring-boot/spring-boot-testconfiguration/src/main/java/io/reflectoring/springboot/testconfiguration/WebClientConfiguration.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package io.reflectoring.springboot.testconfiguration;
22

3+
import org.slf4j.Logger;
4+
import org.slf4j.LoggerFactory;
35
import org.springframework.beans.factory.annotation.Value;
46
import org.springframework.context.annotation.Bean;
57
import org.springframework.context.annotation.Configuration;
@@ -9,14 +11,15 @@
911

1012
@Configuration
1113
public class WebClientConfiguration {
14+
private static final Logger LOGGER = LoggerFactory.getLogger(WebClientConfiguration.class);
1215
@Bean
1316
public WebClient getWebClient(final WebClient.Builder builder,
1417
@Value("${data.service.endpoint:https://google.com}") final String url) {
1518
WebClient webClient = builder.baseUrl(url)
1619
.defaultHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE)
1720
// more configurations and customizations
1821
.build();
19-
System.out.println("WebClient Instance Created During Testing: " + webClient.toString());
22+
LOGGER.info("WebClient Bean Instance: {}", webClient);
2023
return webClient;
2124
}
2225
}
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
package io.reflectoring.springboot.testconfiguration.service;
22

3+
import org.slf4j.Logger;
4+
import org.slf4j.LoggerFactory;
35
import org.springframework.stereotype.Service;
46
import org.springframework.web.reactive.function.client.WebClient;
57

68
@Service
79
public class DataService {
10+
private static final Logger LOGGER = LoggerFactory.getLogger(DataService.class);
811
private final WebClient webClient;
912
public DataService(final WebClient webClient) {
1013
this.webClient = webClient;
11-
System.out.println("WebClient instance " + this.webClient.toString());
14+
LOGGER.info("WebClient instance {}", this.webClient);
1215
}
1316
}

spring-boot/spring-boot-testconfiguration/src/test/java/io/reflectoring/springboot/testconfiguration/UsingStaticInnerTestConfiguration.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import io.reflectoring.springboot.testconfiguration.service.DataService;
44
import org.junit.jupiter.api.Test;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57
import org.springframework.beans.factory.annotation.Autowired;
68
import org.springframework.boot.test.context.SpringBootTest;
79
import org.springframework.boot.test.context.TestConfiguration;
@@ -21,13 +23,13 @@ void contextLoads() {
2123

2224
@TestConfiguration
2325
public static class WebClientTestConfiguration {
26+
private static final Logger LOGGER = LoggerFactory.getLogger(WebClientTestConfiguration.class);
2427
@Bean
2528
public WebClient getWebClient(final WebClient.Builder builder) {
2629
WebClient webClient = builder
2730
.baseUrl("http://localhost")
2831
.build();
29-
System.out.println("WebClient Instance Created During Testing, using static inner class: "
30-
+ webClient.toString());
32+
LOGGER.info("WebClient Instance Created During Testing, using static inner class: {}", webClient);
3133
return webClient;
3234
}
3335
}
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
11
package io.reflectoring.springboot.testconfiguration;
22

3+
import org.slf4j.Logger;
4+
import org.slf4j.LoggerFactory;
35
import org.springframework.boot.test.context.TestConfiguration;
46
import org.springframework.context.annotation.Bean;
5-
import org.springframework.context.annotation.Primary;
67
import org.springframework.web.reactive.function.client.WebClient;
78

89
@TestConfiguration
910
public class WebClientTestConfiguration {
11+
private static final Logger LOGGER = LoggerFactory.getLogger(UsingStaticInnerTestConfiguration.WebClientTestConfiguration.class);
1012
@Bean
1113
public WebClient getWebClient(final WebClient.Builder builder) {
1214
WebClient webClient = builder
1315
.baseUrl("http://localhost")
1416
.build();
15-
System.out.println("WebClient Instance Created During Testing: " + webClient.toString());
17+
LOGGER.info("WebClient Instance Created During Testing: {}", webClient);
1618
return webClient;
1719
}
1820
}

0 commit comments

Comments
 (0)