Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bloominstituteoftechnology/JavaScript-IV
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jdorety/JavaScript-IV
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 25, 2018

  1. Re-factor object constructors to class constructors

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    8d17622 View commit details
    Browse the repository at this point in the history

  2. Refactor prototype methods to class methods

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    0ecca4d View commit details
    Browse the repository at this point in the history

  3. refactor Hero and Villain objects to class

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    e45a06b View commit details
    Browse the repository at this point in the history

  4. Finish refactoring all Classes 

    Need to work on destroy and takeDamage methods
    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    1e931d2 View commit details
    Browse the repository at this point in the history

  5. Fix takeDamage() add diceRoll()

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    af4c660 View commit details
    Browse the repository at this point in the history

  6. Complete MVP prototype-refactor.js

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    2b47102 View commit details
    Browse the repository at this point in the history

  7. Create Person and Intructor class constructors

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    bda1a15 View commit details
    Browse the repository at this point in the history

  8. Create Student class contructor

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    fd8a303 View commit details
    Browse the repository at this point in the history

  9. Complete ProjectManager class constructor

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    229ff03 View commit details
    Browse the repository at this point in the history

  10. Create several objects for testing purposes

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    15e5f51 View commit details
    Browse the repository at this point in the history

  11. Add lots of console logs for testing purposes.

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    6f4f27c View commit details
    Browse the repository at this point in the history

  12. Complete MVP lambda-classes.js

    @jdorety
    jdorety committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    ddb0822 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Add grade property to Student object, and make basic evaluate method

    @jdorety
    jdorety committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    b3c51a9 View commit details
    Browse the repository at this point in the history

  2. Implemented and tested Instructor.evaluate() and Student.graduate()

    @jdorety
    jdorety committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    3c82f1c View commit details
    Browse the repository at this point in the history
Loading