Fix gaps / inconsistencies in BACKUP / RESTORE device type (microsoft#40)

arvindshmicrosoft · web-flow · commit 7ffc71ec8cca · 2023-06-01T20:42:16.000-07:00
* Fix gaps / inconsistencies in BACKUP / RESTORE device type Originally created just to fix microsoft#29, but in the process fixed subtle issues with VirtualDevice and DatabaseSnapshot device types as well. * Add the URL device type for use with BACKUP and RESTORE statements for 110 parser and above. URL backups were introduced with SQL Server 2012. Also updated the ScriptGenerator to ensure URL devices are correctly scripted. * Add version constraints for device types DatabaseSnapshot and VirtualDevice, both of which are only supported for SQL 2005+. * Remove dead code related to Disk device type in grammar 90 and above. In all grammars other than 80, the different device types are handled by the DeviceTypesHelper class, so the special case in the grammar for Disk device type was never used. In 80 grammar though, the Disk device type is not treated as an indentifier and hence the special case for Disk is still needed. * Add regression tests for device types URL, VIRTUAL_DEVICE and DATABASE_SNAPSHOT and for good measure, DISK as well. * Address code review comments
diff --git a/SqlScriptDom/Parser/TSql/DeviceType.cs b/SqlScriptDom/Parser/TSql/DeviceType.cs
@@ -18,7 +18,8 @@ public enum DeviceType
         Disk = 1,
         Tape = 2,
         VirtualDevice = 3,
-        DatabaseSnapshot = 4
+        DatabaseSnapshot = 4,
+        Url = 5
     }
 
 #pragma warning restore 1591
diff --git a/SqlScriptDom/Parser/TSql/DeviceTypesHelper.cs b/SqlScriptDom/Parser/TSql/DeviceTypesHelper.cs
@@ -14,8 +14,9 @@ private DeviceTypesHelper()
         {
             AddOptionMapping(DeviceType.Disk, CodeGenerationSupporter.Disk);
             AddOptionMapping(DeviceType.Tape, CodeGenerationSupporter.Tape);
-            AddOptionMapping(DeviceType.VirtualDevice, CodeGenerationSupporter.VirtualDevice);
-            AddOptionMapping(DeviceType.DatabaseSnapshot, CodeGenerationSupporter.DatabaseSnapshot);
+            AddOptionMapping(DeviceType.VirtualDevice, CodeGenerationSupporter.VirtualDevice, SqlVersionFlags.TSql90AndAbove);
+            AddOptionMapping(DeviceType.DatabaseSnapshot, CodeGenerationSupporter.DatabaseSnapshot, SqlVersionFlags.TSql90AndAbove);
+            AddOptionMapping(DeviceType.Url, CodeGenerationSupporter.Url, SqlVersionFlags.TSql110AndAbove);
         }
 
         internal static readonly DeviceTypesHelper Instance = new DeviceTypesHelper();
diff --git a/SqlScriptDom/Parser/TSql/TSql100.g b/SqlScriptDom/Parser/TSql/TSql100.g
@@ -3149,11 +3149,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier 
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);                
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql100);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql110.g b/SqlScriptDom/Parser/TSql/TSql110.g
@@ -3855,11 +3855,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier 
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);                
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql110);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql120.g b/SqlScriptDom/Parser/TSql/TSql120.g
@@ -3965,11 +3965,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier 
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);                
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql120);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql130.g b/SqlScriptDom/Parser/TSql/TSql130.g
@@ -4833,11 +4833,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql130);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql140.g b/SqlScriptDom/Parser/TSql/TSql140.g
@@ -5189,11 +5189,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql140);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql150.g b/SqlScriptDom/Parser/TSql/TSql150.g
@@ -5712,11 +5712,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql150);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql160.g b/SqlScriptDom/Parser/TSql/TSql160.g
@@ -5737,11 +5737,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql160);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/Parser/TSql/TSql80.g b/SqlScriptDom/Parser/TSql/TSql80.g
@@ -1259,7 +1259,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier 
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);                
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql80);
             }
         |   Disk
             {
diff --git a/SqlScriptDom/Parser/TSql/TSql90.g b/SqlScriptDom/Parser/TSql/TSql90.g
@@ -2122,11 +2122,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn
         (
             tDevType:Identifier 
             {
-                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);                
-            }
-        |   Disk
-            {
-                vResult.DeviceType = DeviceType.Disk;
+                vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql90);
             }
         )
         EqualsSign vPhysicalDevice = stringOrVariable
diff --git a/SqlScriptDom/ScriptDom/SqlServer/ScriptGenerator/SqlScriptGeneratorVisitor.DeviceInfo.cs b/SqlScriptDom/ScriptDom/SqlServer/ScriptGenerator/SqlScriptGeneratorVisitor.DeviceInfo.cs
@@ -17,6 +17,7 @@ partial class SqlScriptGeneratorVisitor
             {DeviceType.Disk,  new KeywordGenerator(TSqlTokenType.Disk)},
             {DeviceType.Tape, new IdentifierGenerator(CodeGenerationSupporter.Tape)},
             {DeviceType.VirtualDevice, new IdentifierGenerator(CodeGenerationSupporter.VirtualDevice)},
+            {DeviceType.Url, new IdentifierGenerator(CodeGenerationSupporter.Url)},
         };
 
         public override void ExplicitVisit(DeviceInfo node)
diff --git a/Test/SqlDom/BackupRestoreRegressionTests.cs b/Test/SqlDom/BackupRestoreRegressionTests.cs
@@ -0,0 +1,160 @@
+﻿//------------------------------------------------------------------------------
+// <copyright file="BackupRestoreRegressionTests.cs" company="Microsoft">
+//   Copyright (c) Microsoft Corporation.  All rights reserved.
+// </copyright>
+//------------------------------------------------------------------------------
+
+using Microsoft.SqlServer.TransactSql.ScriptDom;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using SqlStudio.Tests.AssemblyTools.TestCategory;
+using System.Collections.Generic;
+using System.IO;
+
+namespace SqlStudio.Tests.UTSqlScriptDom
+{
+    public partial class SqlDomTests
+    {
+        /// <summary>
+        /// Test for RESTORE ... FROM URL ... syntax
+        /// Also tests the related BACKUP ... TO URL ... syntax
+        /// See https://github.com/microsoft/SqlScriptDOM/issues/29 for details on the issue.
+        /// </summary>
+        [TestMethod]
+        [Priority(0)]
+        [SqlStudioTestCategory(Category.UnitTest)]
+        public void BackupRestoreUrl()
+        {
+            ParserTestUtils.ExecuteTestForAllParsers(parser =>
+            {
+                string script = @"BACKUP DATABASE AdventureWorks2016
+TO URL = 'https://mystorageaccount.blob.core.windows.net/mycontainername/AdventureWorks2016.bak'
+WITH COMPRESSION
+,STATS = 5;
+
+RESTORE DATABASE Sales
+FROM URL = 'https://mystorageaccount.blob.core.windows.net/mysecondcontainer/Sales.bak'
+WITH MOVE 'Sales_Data1' to 'https://mystorageaccount.blob.core.windows.net/myfirstcontainer/Sales_Data1.mdf',
+MOVE 'Sales_log' to 'https://mystorageaccount.blob.core.windows.net/myfirstcontainer/Sales_log.ldf',
+STATS = 10;
+
+RESTORE DATABASE AdventureWorks2012
+    FROM DISK = 'Z:\SQLServerBackups\AdventureWorks2012.bak'
+    WITH FILE = 6,
+      NORECOVERY;
+";
+                using (var scriptReader = new StringReader(script))
+                {
+                    var fragment = parser.Parse(scriptReader, out IList<ParseError> errors) as TSqlScript;
+                    if (!(parser is TSql80Parser || parser is TSql90Parser || parser is TSql100Parser))
+                    {
+                        // for these parser versions we expect success
+                        Assert.AreEqual(0, errors.Count);
+                        Assert.IsTrue(fragment is TSqlScript);
+                        Assert.IsTrue(fragment.Batches[0].Statements[0] is BackupStatement);
+                        Assert.AreEqual(DeviceType.Url, (fragment.Batches[0].Statements[0] as BackupStatement).Devices[0].DeviceType);
+                        Assert.AreEqual("https://mystorageaccount.blob.core.windows.net/mycontainername/AdventureWorks2016.bak", ((fragment.Batches[0].Statements[0] as BackupStatement).Devices[0].PhysicalDevice as StringLiteral).Value);
+                        Assert.IsTrue(fragment.Batches[0].Statements[1] is RestoreStatement);
+                        Assert.AreEqual(DeviceType.Url, (fragment.Batches[0].Statements[1] as RestoreStatement).Devices[0].DeviceType);
+                        Assert.AreEqual("https://mystorageaccount.blob.core.windows.net/mysecondcontainer/Sales.bak", ((fragment.Batches[0].Statements[1] as RestoreStatement).Devices[0].PhysicalDevice as StringLiteral).Value);
+
+                        // regression test to ensure that DISK device type is correctly handled
+                        Assert.IsTrue(fragment.Batches[0].Statements[2] is RestoreStatement);
+                        Assert.AreEqual(DeviceType.Disk, (fragment.Batches[0].Statements[2] as RestoreStatement).Devices[0].DeviceType);
+                        Assert.AreEqual("Z:\\SQLServerBackups\\AdventureWorks2012.bak", ((fragment.Batches[0].Statements[2] as RestoreStatement).Devices[0].PhysicalDevice as StringLiteral).Value);
+                        Assert.AreEqual(RestoreOptionKind.File, ((fragment.Batches[0].Statements[2] as RestoreStatement).Options[0] as ScalarExpressionRestoreOption).OptionKind);
+                        Assert.AreEqual("6", (((fragment.Batches[0].Statements[2] as RestoreStatement).Options[0] as ScalarExpressionRestoreOption).Value as IntegerLiteral).Value);
+                        Assert.AreEqual("Z:\\SQLServerBackups\\AdventureWorks2012.bak", ((fragment.Batches[0].Statements[2] as RestoreStatement).Devices[0].PhysicalDevice as StringLiteral).Value);
+
+                        if (parser is TSql110Parser)
+                        {
+                            SqlScriptGenerator scriptGen = ParserTestUtils.CreateScriptGen(SqlVersion.Sql110);
+                            scriptGen.GenerateScript(fragment, out string prettyPrinted);
+                            Assert.AreEqual(@"BACKUP DATABASE AdventureWorks2016
+    TO URL = 'https://mystorageaccount.blob.core.windows.net/mycontainername/AdventureWorks2016.bak'
+    WITH COMPRESSION, STATS = 5;
+
+RESTORE DATABASE Sales FROM URL = 'https://mystorageaccount.blob.core.windows.net/mysecondcontainer/Sales.bak'
+    WITH MOVE 'Sales_Data1' TO 'https://mystorageaccount.blob.core.windows.net/myfirstcontainer/Sales_Data1.mdf', MOVE 'Sales_log' TO 'https://mystorageaccount.blob.core.windows.net/myfirstcontainer/Sales_log.ldf', STATS = 10;
+
+RESTORE DATABASE AdventureWorks2012 FROM DISK = 'Z:\SQLServerBackups\AdventureWorks2012.bak'
+    WITH FILE = 6, NORECOVERY;"
+, prettyPrinted.Trim());
+                        }
+                    }
+                    else
+                    {
+                        // for the older parsers this syntax is expected to return errors
+                        Assert.AreEqual(2, errors.Count);
+                        Assert.AreEqual("Incorrect syntax near URL.", errors[0].Message);
+                        Assert.AreEqual("Incorrect syntax near URL.", errors[1].Message);
+                    }
+                }
+            }, true);
+        }
+
+        /// <summary>
+        /// Test for RESTORE ... FROM DATABASE_SNAPSHOT ... syntax. This is supported in SQL Server 2005+, so parser version 90+.
+        /// </summary>
+        [TestMethod]
+        [Priority(0)]
+        [SqlStudioTestCategory(Category.UnitTest)]
+        public void RestoreFromDBSnapshot()
+        {
+            ParserTestUtils.ExecuteTestForAllParsers(parser =>
+            {
+                string script = @"RESTORE DATABASE AdventureWorks2012 FROM DATABASE_SNAPSHOT = 'AdventureWorks_dbss1800'";
+                using (var scriptReader = new StringReader(script))
+                {
+                    var fragment = parser.Parse(scriptReader, out IList<ParseError> errors) as TSqlScript;
+                    if (parser is TSql80Parser)
+                    {
+                        // for the older parsers this syntax is expected to return errors
+                        Assert.AreEqual(1, errors.Count);
+                        Assert.AreEqual("Incorrect syntax near DATABASE_SNAPSHOT.", errors[0].Message);
+                    }
+                    else
+                    {
+                        // for these parser versions we expect success
+                        Assert.AreEqual(0, errors.Count);
+                        Assert.IsTrue(fragment is TSqlScript);
+                        Assert.IsTrue(fragment.Batches[0].Statements[0] is RestoreStatement);
+                    }
+                }
+            }, true);
+        }
+
+        /// <summary>
+        /// Test for BACKUP / RESTORE ... VIRTUAL_DEVICE ... syntax. This is supported in SQL Server 2005+, so parser version 90+.
+        /// </summary>
+        [TestMethod]
+        [Priority(0)]
+        [SqlStudioTestCategory(Category.UnitTest)]
+        public void BackupRestoreVirtualDevice()
+        {
+            ParserTestUtils.ExecuteTestForAllParsers(parser =>
+            {
+                string script = @"BACKUP DATABASE MyDB TO VIRTUAL_DEVICE='{A9FD7855-A978-4931-8027-F0EFB1D4F4EA}' WITH STATS = 10;
+RESTORE DATABASE MyDB FROM VIRTUAL_DEVICE='{A9FD7855-A978-4931-8027-F0EFB1D4F4EA}' WITH NORECOVERY, CHECKSUM, REPLACE, BUFFERCOUNT=16, MAXTRANSFERSIZE=2097152";
+                using (var scriptReader = new StringReader(script))
+                {
+                    var fragment = parser.Parse(scriptReader, out IList<ParseError> errors) as TSqlScript;
+                    if (parser is TSql80Parser)
+                    {
+                        // for the older parsers this syntax is expected to return errors
+                        Assert.AreEqual(2, errors.Count);
+                        Assert.AreEqual("Incorrect syntax near VIRTUAL_DEVICE.", errors[0].Message);
+                        Assert.AreEqual("Incorrect syntax near VIRTUAL_DEVICE.", errors[1].Message);
+                    }
+                    else
+                    {
+                        // for these parser versions we expect success
+                        Assert.AreEqual(0, errors.Count);
+                        Assert.IsTrue(fragment is TSqlScript);
+                        Assert.IsTrue(fragment.Batches[0].Statements[0] is BackupStatement);
+                        Assert.IsTrue(fragment.Batches[0].Statements[1] is RestoreStatement);
+                    }
+                }
+            }, true);
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,8 @@ public enum DeviceType`
`18`	`18`	`Disk = 1,`
`19`	`19`	`Tape = 2,`
`20`	`20`	`VirtualDevice = 3,`
`21`		`- DatabaseSnapshot = 4`
	`21`	`+ DatabaseSnapshot = 4,`
	`22`	`+ Url = 5`
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`#pragma warning restore 1591`
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,9 @@ private DeviceTypesHelper()`
`14`	`14`	`{`
`15`	`15`	`AddOptionMapping(DeviceType.Disk, CodeGenerationSupporter.Disk);`
`16`	`16`	`AddOptionMapping(DeviceType.Tape, CodeGenerationSupporter.Tape);`
`17`		`- AddOptionMapping(DeviceType.VirtualDevice, CodeGenerationSupporter.VirtualDevice);`
`18`		`- AddOptionMapping(DeviceType.DatabaseSnapshot, CodeGenerationSupporter.DatabaseSnapshot);`
	`17`	`+ AddOptionMapping(DeviceType.VirtualDevice, CodeGenerationSupporter.VirtualDevice, SqlVersionFlags.TSql90AndAbove);`
	`18`	`+ AddOptionMapping(DeviceType.DatabaseSnapshot, CodeGenerationSupporter.DatabaseSnapshot, SqlVersionFlags.TSql90AndAbove);`
	`19`	`+ AddOptionMapping(DeviceType.Url, CodeGenerationSupporter.Url, SqlVersionFlags.TSql110AndAbove);`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`internal static readonly DeviceTypesHelper Instance = new DeviceTypesHelper();`
Original file line number	Diff line number	Diff line change
`@@ -3149,11 +3149,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`3149`	`3149`	`(`
`3150`	`3150`	`tDevType:Identifier`
`3151`	`3151`	`{`
`3152`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`3153`		`- }`
`3154`		`- \| Disk`
`3155`		`- {`
`3156`		`- vResult.DeviceType = DeviceType.Disk;`
	`3152`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql100);`
`3157`	`3153`	`}`
`3158`	`3154`	`)`
`3159`	`3155`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -3855,11 +3855,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`3855`	`3855`	`(`
`3856`	`3856`	`tDevType:Identifier`
`3857`	`3857`	`{`
`3858`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`3859`		`- }`
`3860`		`- \| Disk`
`3861`		`- {`
`3862`		`- vResult.DeviceType = DeviceType.Disk;`
	`3858`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql110);`
`3863`	`3859`	`}`
`3864`	`3860`	`)`
`3865`	`3861`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -3965,11 +3965,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`3965`	`3965`	`(`
`3966`	`3966`	`tDevType:Identifier`
`3967`	`3967`	`{`
`3968`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`3969`		`- }`
`3970`		`- \| Disk`
`3971`		`- {`
`3972`		`- vResult.DeviceType = DeviceType.Disk;`
	`3968`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql120);`
`3973`	`3969`	`}`
`3974`	`3970`	`)`
`3975`	`3971`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -4833,11 +4833,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`4833`	`4833`	`(`
`4834`	`4834`	`tDevType:Identifier`
`4835`	`4835`	`{`
`4836`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`4837`		`- }`
`4838`		`- \| Disk`
`4839`		`- {`
`4840`		`- vResult.DeviceType = DeviceType.Disk;`
	`4836`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql130);`
`4841`	`4837`	`}`
`4842`	`4838`	`)`
`4843`	`4839`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -5189,11 +5189,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`5189`	`5189`	`(`
`5190`	`5190`	`tDevType:Identifier`
`5191`	`5191`	`{`
`5192`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`5193`		`- }`
`5194`		`- \| Disk`
`5195`		`- {`
`5196`		`- vResult.DeviceType = DeviceType.Disk;`
	`5192`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql140);`
`5197`	`5193`	`}`
`5198`	`5194`	`)`
`5199`	`5195`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -5712,11 +5712,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`5712`	`5712`	`(`
`5713`	`5713`	`tDevType:Identifier`
`5714`	`5714`	`{`
`5715`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`5716`		`- }`
`5717`		`- \| Disk`
`5718`		`- {`
`5719`		`- vResult.DeviceType = DeviceType.Disk;`
	`5715`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql150);`
`5720`	`5716`	`}`
`5721`	`5717`	`)`
`5722`	`5718`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -5737,11 +5737,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`5737`	`5737`	`(`
`5738`	`5738`	`tDevType:Identifier`
`5739`	`5739`	`{`
`5740`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
`5741`		`- }`
`5742`		`- \| Disk`
`5743`		`- {`
`5744`		`- vResult.DeviceType = DeviceType.Disk;`
	`5740`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql160);`
`5745`	`5741`	`}`
`5746`	`5742`	`)`
`5747`	`5743`	`EqualsSign vPhysicalDevice = stringOrVariable`
Original file line number	Diff line number	Diff line change
`@@ -1259,7 +1259,7 @@ deviceInfo returns [DeviceInfo vResult = FragmentFactory.CreateFragment<DeviceIn`
`1259`	`1259`	`(`
`1260`	`1260`	`tDevType:Identifier`
`1261`	`1261`	`{`
`1262`		`- vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType);`
	`1262`	`+ vResult.DeviceType = DeviceTypesHelper.Instance.ParseOption(tDevType, SqlVersionFlags.TSql80);`
`1263`	`1263`	`}`
`1264`	`1264`	`\| Disk`
`1265`	`1265`	`{`