Fix test and add broken test

Sascha Hagedorn · Sascha Hagedorn · commit 5018366210bd · 2020-03-27T15:28:47.000+01:00
diff --git a/src/main/java/com/cleancoder/args/ArgsMain.java b/src/main/java/com/cleancoder/args/ArgsMain.java
@@ -9,11 +9,16 @@ public class ArgsMain {
 
     public ArgsMain(String[] givenArgs) {
         this.givenArgs = Arrays.asList(givenArgs);
-        if (this.givenArgs.contains("-u"))
+
+        if (this.givenArgs.stream().anyMatch(arg -> !isAllowed(arg)))
             throw new IllegalArgumentException("Parameter -u is not supported");
     }
 
     boolean isHelp() {
         return givenArgs.contains("-h");
     }
+
+    private boolean isAllowed(String arg) {
+        return arg.equals("-h");
+    }
 }
diff --git a/src/test/java/com/cleancoder/args/ArgsTest.java b/src/test/java/com/cleancoder/args/ArgsTest.java
@@ -27,7 +27,12 @@ public void detectWhenHelpIsNotRequested() {
 
   @Test
   public void shouldThrowIllegalArgumentExceptionOnUnknownArg() {
-    assertThatIllegalArgumentException().isThrownBy(() -> new ArgsMain(Arrays.array("-u")));
-    assertThatIllegalArgumentException().isThrownBy(() -> new ArgsMain(Arrays.array("-k")));
+    assertThatIllegalArgumentException()
+            .isThrownBy(() -> new ArgsMain(Arrays.array("-u")))
+            .withMessage("Parameter -u is not supported");
+
+    assertThatIllegalArgumentException()
+            .isThrownBy(() -> new ArgsMain(Arrays.array("-k")))
+            .withMessage("Parameter -k is not supported");
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,16 @@ public class ArgsMain {`
`9`	`9`
`10`	`10`	`public ArgsMain(String[] givenArgs) {`
`11`	`11`	`this.givenArgs = Arrays.asList(givenArgs);`
`12`		`- if (this.givenArgs.contains("-u"))`
	`12`	`+`
	`13`	`+ if (this.givenArgs.stream().anyMatch(arg -> !isAllowed(arg)))`
`13`	`14`	`throw new IllegalArgumentException("Parameter -u is not supported");`
`14`	`15`	`}`
`15`	`16`
`16`	`17`	`boolean isHelp() {`
`17`	`18`	`return givenArgs.contains("-h");`
`18`	`19`	`}`
	`20`	`+`
	`21`	`+ private boolean isAllowed(String arg) {`
	`22`	`+ return arg.equals("-h");`
	`23`	`+ }`
`19`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,12 @@ public void detectWhenHelpIsNotRequested() {`
`27`	`27`
`28`	`28`	`@Test`
`29`	`29`	`public void shouldThrowIllegalArgumentExceptionOnUnknownArg() {`
`30`		`- assertThatIllegalArgumentException().isThrownBy(() -> new ArgsMain(Arrays.array("-u")));`
`31`		`- assertThatIllegalArgumentException().isThrownBy(() -> new ArgsMain(Arrays.array("-k")));`
	`30`	`+ assertThatIllegalArgumentException()`
	`31`	`+ .isThrownBy(() -> new ArgsMain(Arrays.array("-u")))`
	`32`	`+ .withMessage("Parameter -u is not supported");`
	`33`	`+`
	`34`	`+ assertThatIllegalArgumentException()`
	`35`	`+ .isThrownBy(() -> new ArgsMain(Arrays.array("-k")))`
	`36`	`+ .withMessage("Parameter -k is not supported");`
`32`	`37`	`}`
`33`	`38`	`}`