[21826] Ensure mobilePickPhoto works in all Android devices

livecodepanos · livecodepanos · commit 235fa59acbfe · 2019-03-13T10:34:52.000+02:00
diff --git a/docs/notes/bugfix-21826.md b/docs/notes/bugfix-21826.md
@@ -0,0 +1 @@
+# Ensure mobilePickPhoto "camera" does not fail in some Android 8+ devices
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -2047,7 +2047,18 @@ public void showCamera()
 			return;
 		}
 
-		String t_path = m_temp_image_file.getPath();
+        // getPath() returns a path starting with /, e.g. /storage/emulated/0/Android/data/<app_id>/cache/..
+        // This path is appended to content://<app_id>.fileprovider/share/, resulting in an URI like:
+        //
+        // content://<app_id>.fileprovider//storage/emulated/0/Android/data/<app_id>/cache/..
+        //
+        // This is not a problem in general, but in _some_ devices (e.g. Huawei nova e3) this URI is
+        // normalized to:
+        //
+        // content://<app_id>.fileprovider/storage/emulated/0/Android/data/<app_id>/cache/..
+        //
+        // This results in the URI not being found. So use .substring(1) to remove the first slash
+		String t_path = m_temp_image_file.getPath().substring(1);
 
 		Uri t_uri;
 		t_uri = FileProvider.getProvider(getContext()).addPath(t_path, t_path, "image/jpeg", true, ParcelFileDescriptor.MODE_WRITE_ONLY);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure mobilePickPhoto "camera" does not fail in some Android 8+ devices`