[[ Bug 19670 ]] Fix effective working screenrect on Android

montegoulding · montegoulding · commit 7dc0f897cecd · 2018-09-18T13:59:50.000+10:00
This patch fixes the effective working screenrect on Android when
the status bar is hidden. Previously to determine the area not covered
by screen decorations we used `getGlobalVisibleRect`, however this only
took clipping into account and in some cases decorations do not clip the
view.

This patch uses `getWindowVisibleDisplayFrame` which is documented to tell
`you the available area where content can be placed and remain visible to
users.`
diff --git a/docs/notes/bugfix-19670.md b/docs/notes/bugfix-19670.md
@@ -0,0 +1 @@
+# Fix effective working screenrect on Android when status bar is hidden
diff --git a/engine/src/java/com/runrev/android/Engine.java b/engine/src/java/com/runrev/android/Engine.java
@@ -1218,8 +1218,8 @@ public String getViewportAsString()
 	private Rect getEffectiveWorkarea()
 	{
 		Rect t_workrect = new Rect();
-		getGlobalVisibleRect(t_workrect);
-		return t_workrect;
+        getWindowVisibleDisplayFrame(t_workrect);
+        return t_workrect;
 	}
 
 	public String getEffectiveWorkareaAsString()

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix effective working screenrect on Android when status bar is hidden`
Original file line number	Diff line number	Diff line change
`@@ -1218,8 +1218,8 @@ public String getViewportAsString()`
`1218`	`1218`	`private Rect getEffectiveWorkarea()`
`1219`	`1219`	`{`
`1220`	`1220`	`Rect t_workrect = new Rect();`
`1221`		`- getGlobalVisibleRect(t_workrect);`
`1222`		`- return t_workrect;`
	`1221`	`+ getWindowVisibleDisplayFrame(t_workrect);`
	`1222`	`+ return t_workrect;`
`1223`	`1223`	`}`
`1224`	`1224`
`1225`	`1225`	`public String getEffectiveWorkareaAsString()`