[[ Cleanup ]] resolve various warnings in browser src

montegoulding · montegoulding · commit f89004730279 · 2017-12-18T12:09:42.000+11:00
diff --git a/libbrowser/src/libbrowser_cef.cpp b/libbrowser/src/libbrowser_cef.cpp
@@ -249,9 +249,7 @@ static const char *s_auth_scheme_strings[] =
 
 bool MCCefAuthSchemeFromCefString(const CefString &p_string, MCCefAuthScheme &r_scheme)
 {
-	const char **t_strings;
-	t_strings = s_auth_scheme_strings;
-	
+
 	for (uint32_t i = 0; s_auth_scheme_strings[i] != nil; i++)
 	{
 		if (p_string == s_auth_scheme_strings[i])
@@ -676,6 +674,16 @@ class MCCefMessageResult
 					MCCStringFree(t_tmp);
 			}
 				break;
+				case VTYPE_NULL:
+				case VTYPE_BOOL:
+				case VTYPE_DOUBLE:
+				case VTYPE_STRING:
+				case VTYPE_BINARY:
+				case VTYPE_DICTIONARY:
+				case VTYPE_LIST:
+				case VTYPE_INVALID:
+				/* UNIMPLEMENTED */
+				break;
 		}
 		
 		return t_converted;
@@ -875,10 +883,7 @@ class MCCefBrowserClient : public CefClient, CefLifeSpanHandler, CefRequestHandl
 			
 			if (t_success)
 				t_success = MCCefStringToUtf8String(t_args->GetString(0), t_handler);
-			
-			uint32_t t_arg_count;
-			t_arg_count = 0;
-			
+
 			MCBrowserListRef t_param_list;
 			t_param_list = nil;
 			
@@ -1671,10 +1676,7 @@ bool MCCefBrowserBase::EvaluateJavaScript(const char *p_script, char *&r_result)
 {
 	bool t_success;
 	t_success = true;
-	
-	const MCCefMessageResult *t_result;
-	t_result = nil;
-	
+
 	CefString t_script;
 	t_success = MCCefStringFromUtf8String(p_script, t_script);
 	
diff --git a/libbrowser/src/libbrowser_cefprocess.cpp b/libbrowser/src/libbrowser_cefprocess.cpp
@@ -129,6 +129,9 @@ bool MCCefListToV8List(CefRefPtr<CefV8Context> p_context, CefRefPtr<CefListValue
 			case VTYPE_LIST:
 				/* TODO - IMPLEMENT */
 				t_success = false;
+				break;
+			case VTYPE_INVALID:
+				t_success = false;
 		}
 		
 		t_success = t_v8 != NULL;
@@ -226,10 +229,7 @@ bool MCCefV8ObjectToDictionary(CefRefPtr<CefV8Context> p_context, CefRefPtr<CefV
 	{
 		CefRefPtr<CefV8Value> t_val;
 		t_val = p_obj->GetValue(*i);
-		
-		uint32_t t_index;
-		t_index = i - t_keys.begin();
-		
+
 		if (t_val->IsBool())
 			t_success = t_dict->SetBool(*i, t_val->GetBoolValue());
 		else if (t_val->IsInt())
diff --git a/revbrowser/src/cefbrowser.cpp b/revbrowser/src/cefbrowser.cpp
@@ -88,8 +88,6 @@ static const char *s_auth_scheme_strings[] =
 
 bool MCCefAuthSchemeFromCefString(const CefString &p_string, MCCefAuthScheme &r_scheme)
 {
-	const char **t_strings;
-	t_strings = s_auth_scheme_strings;
 	
 	for (uint32_t i = 0; s_auth_scheme_strings[i] != nil; i++)
 	{
@@ -418,6 +416,15 @@ class MCCefMessageResult
 					MCCStringFree(t_tmp);
 			}
 			break;
+			case VTYPE_NULL:
+			case VTYPE_BOOL:
+			case VTYPE_DOUBLE:
+			case VTYPE_BINARY:
+			case VTYPE_STRING:
+			case VTYPE_DICTIONARY:
+			case VTYPE_LIST:
+			case VTYPE_INVALID:
+				break;
 		}
 
 		return t_converted;
@@ -1581,9 +1588,6 @@ char *MCCefBrowserBase::ExecuteScript(const char *p_javascript_string)
 	bool t_success;
 	t_success = true;
 
-	const MCCefMessageResult *t_result;
-	t_result = nil;
-
 	CefString t_script;
 	t_success = MCCefStringFromUtf8String(p_javascript_string, t_script);
 
diff --git a/revbrowser/src/cefprocess.cpp b/revbrowser/src/cefprocess.cpp
@@ -129,6 +129,9 @@ bool MCCefListToV8List(CefRefPtr<CefV8Context> p_context, CefRefPtr<CefListValue
 		case VTYPE_LIST:
 			/* TODO - IMPLEMENT */
 			t_success = false;
+			break;
+		case VTYPE_INVALID:
+			t_success = false;
 		}
 
 		t_success = t_v8 != NULL;

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,9 @@ bool MCCefListToV8List(CefRefPtr<CefV8Context> p_context, CefRefPtr<CefListValue`
`129`	`129`	`case VTYPE_LIST:`
`130`	`130`	`/* TODO - IMPLEMENT */`
`131`	`131`	`t_success = false;`
	`132`	`+ break;`
	`133`	`+ case VTYPE_INVALID:`
	`134`	`+ t_success = false;`
`132`	`135`	`}`
`133`	`136`
`134`	`137`	`t_success = t_v8 != NULL;`