[[ Bug 21986 ]] Fix benign leak of backdrop window on macOS

runrevmark · runrevmark · commit 04e976aaea6a · 2019-04-18T15:13:52.000+01:00
This patch fixes the failure to release the backdrop window on
engine shutdown on macOS. The leak is benign as it cannot affect
user code, however it does clutter up memory leak logs.
diff --git a/docs/notes/bugfix-21986.md b/docs/notes/bugfix-21986.md
@@ -0,0 +1 @@
+# Fix benign leak of backdrop window on engine shutdown on macOS
diff --git a/engine/src/desktop-dc.cpp b/engine/src/desktop-dc.cpp
@@ -135,6 +135,8 @@ Boolean MCScreenDC::open()
 Boolean MCScreenDC::close(Boolean force)
 {
 	MCPlatformReleaseMenu(icon_menu);
+    
+    MCPlatformReleaseWindow(backdrop_window);
 	
 	// COCOA-TODO: Is this still needed?
 	if (ncolors != 0)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix benign leak of backdrop window on engine shutdown on macOS`
Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,8 @@ Boolean MCScreenDC::open()`
`135`	`135`	`Boolean MCScreenDC::close(Boolean force)`
`136`	`136`	`{`
`137`	`137`	`MCPlatformReleaseMenu(icon_menu);`
	`138`	`+`
	`139`	`+ MCPlatformReleaseWindow(backdrop_window);`
`138`	`140`
`139`	`141`	`// COCOA-TODO: Is this still needed?`
`140`	`142`	`if (ncolors != 0)`