Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Commit 0b32022

Browse files
author
Monte Goulding
committed
some minor fixes for parameter handling
1 parent f10f158 commit 0b32022

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

lcidlc/src/InterfaceGenerate.cpp

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ class CStringTypeMapper: public CTypesTypeMapper
363363

364364
virtual void Default(CoderRef p_coder, ParameterType p_mode, const char *p_name, ValueRef p_value)
365365
{
366-
CoderWriteStatement(p_coder, "success = default__%s(\"%s\", %s)", StringGetCStringPtr(p_value), p_name);
366+
CoderWriteStatement(p_coder, "success = default__cstring(\"%s\", %s)", StringGetCStringPtr(p_value), p_name);
367367
CodeInOutCopy(p_coder, p_mode, p_name);
368368
}
369369

@@ -496,7 +496,7 @@ class JavaStringTypeMapper: public TypeMapper
496496

497497
virtual void Default(CoderRef p_coder, ParameterType p_mode, const char *p_name, ValueRef p_value)
498498
{
499-
CoderWriteStatement(p_coder, "%s = default__java_string(__java_env, \"%s\", %s)", StringGetCStringPtr(p_value), p_name);
499+
CoderWriteStatement(p_coder, "%s = default__java_string(__java_env, \"%s\", %s)", p_name, StringGetCStringPtr(p_value), p_name);
500500
}
501501

502502
virtual void Store(CoderRef p_coder, ParameterType p_mode, const char *p_name, const char *p_target)
@@ -1301,8 +1301,14 @@ static bool InterfaceGenerateVariant(InterfaceRef self, CoderRef p_coder, Handle
13011301
CoderWrite(p_coder, "returnvalue = __java_env -> CallStatic%sMethod(s_java_class, s_method", t_java_method_type);
13021302
else
13031303
CoderWrite(p_coder, "__java_env -> CallStaticVoidMethod(s_java_class, s_method");
1304-
for(uindex_t i = 0; i < p_variant -> parameter_count; i++)
1305-
CoderWrite(p_coder, ", t_param_%d", i);
1304+
1305+
for(uint32_t k = 0; k < p_variant -> parameter_count; k++)
1306+
{
1307+
HandlerParameter *t_parameter;
1308+
t_parameter = &p_variant -> parameters[k];
1309+
CoderWrite(p_coder, ", param__%s", NameGetCString(t_parameter -> name));
1310+
}
1311+
13061312
CoderWrite(p_coder, ")");
13071313
CoderEndStatement(p_coder);
13081314

0 commit comments

Comments
 (0)