[[ Drawing ]] Use types more effectively

runrevmark · runrevmark · commit 24bd18e8b4e3 · 2017-12-14T18:54:57.000Z
This patch changes the libgraphics drawing implementation to
use MCSpan, MCGPoint, MCGSize and MCGRectangle rather than
separate pointer/lengths and multiple float parameters.
diff --git a/engine/src/graphicscontext.cpp b/engine/src/graphicscontext.cpp
@@ -1234,7 +1234,7 @@ void MCGraphicsContext::drawpict(uint1 *data, uint4 length, bool embed, const MC
 {
     MCGContextSave(m_gcontext);
     MCGContextClipToRect(m_gcontext, MCRectangleToMCGRectangle(crect));
-    MCGContextPlayback(m_gcontext, MCRectangleToMCGRectangle(drect), data, length);
+    MCGContextPlayback(m_gcontext, MCRectangleToMCGRectangle(drect), MCMakeSpan(static_cast<const byte_t*>(data), length));
     MCGContextRestore(m_gcontext);
 }
 
diff --git a/libgraphics/include/graphics.h b/libgraphics/include/graphics.h
@@ -1015,7 +1015,7 @@ void MCGContextDrawPlatformText(MCGContextRef context, const unichar_t *text, ui
 MCGFloat MCGContextMeasurePlatformText(MCGContextRef context, const unichar_t *text, uindex_t length, const MCGFont &p_font, const MCGAffineTransform &p_transform);
 bool MCGContextMeasurePlatformTextImageBounds(MCGContextRef context, const unichar_t *text, uindex_t length, const MCGFont &p_font, const MCGAffineTransform &p_transform, MCGRectangle &r_bounds);
 
-void MCGContextPlayback(MCGContextRef context, MCGRectangle p_dst_rect, const void *p_drawing, size_t p_drawing_byte_size);
+void MCGContextPlayback(MCGContextRef context, MCGRectangle p_dst_rect, MCSpan<const byte_t> p_drawing);
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/libgraphics/src/drawing.cpp b/libgraphics/src/drawing.cpp

Original file line number	Diff line number	Diff line change
`@@ -1234,7 +1234,7 @@ void MCGraphicsContext::drawpict(uint1 *data, uint4 length, bool embed, const MC`
`1234`	`1234`	`{`
`1235`	`1235`	`MCGContextSave(m_gcontext);`
`1236`	`1236`	`MCGContextClipToRect(m_gcontext, MCRectangleToMCGRectangle(crect));`
`1237`		`- MCGContextPlayback(m_gcontext, MCRectangleToMCGRectangle(drect), data, length);`
	`1237`	`+ MCGContextPlayback(m_gcontext, MCRectangleToMCGRectangle(drect), MCMakeSpan(static_cast<const byte_t*>(data), length));`
`1238`	`1238`	`MCGContextRestore(m_gcontext);`
`1239`	`1239`	`}`
`1240`	`1240`