[[ BrowserWidget ]] Fix no return value in MCBrowserValueSetList. Replace "double_t" (not defined on windows) with "double"

livecodeian · livecodeian · commit 35704c9c6754 · 2015-07-17T15:12:39.000+01:00
diff --git a/libbrowser/include/libbrowser.h b/libbrowser/include/libbrowser.h
@@ -167,19 +167,19 @@ MC_DLLEXPORT bool MCBrowserListGetType(MCBrowserListRef p_list, uint32_t p_index
 	
 MC_DLLEXPORT bool MCBrowserListSetBoolean(MCBrowserListRef p_list, uint32_t p_index, bool p_value);
 MC_DLLEXPORT bool MCBrowserListSetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t p_value);
-MC_DLLEXPORT bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t p_value);
+MC_DLLEXPORT bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double p_value);
 MC_DLLEXPORT bool MCBrowserListSetUTF8String(MCBrowserListRef p_list, uint32_t p_index, const char *p_value);
 MC_DLLEXPORT bool MCBrowserListSetList(MCBrowserListRef p_list, uint32_t p_index, MCBrowserListRef p_value);
 	
 MC_DLLEXPORT bool MCBrowserListAppendBoolean(MCBrowserListRef p_list, bool p_value);
 MC_DLLEXPORT bool MCBrowserListAppendInteger(MCBrowserListRef p_list, int32_t p_value);
-MC_DLLEXPORT bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double_t p_value);
+MC_DLLEXPORT bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double p_value);
 MC_DLLEXPORT bool MCBrowserListAppendUTF8String(MCBrowserListRef p_list, const char *p_value);
 MC_DLLEXPORT bool MCBrowserListAppendList(MCBrowserListRef p_list, MCBrowserListRef p_value);
 	
 MC_DLLEXPORT bool MCBrowserListGetBoolean(MCBrowserListRef p_list, uint32_t p_index, bool &r_value);
 MC_DLLEXPORT bool MCBrowserListGetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t &r_value);
-MC_DLLEXPORT bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t &r_value);
+MC_DLLEXPORT bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double &r_value);
 MC_DLLEXPORT bool MCBrowserListGetUTF8String(MCBrowserListRef p_list, uint32_t p_index, char *&r_value);
 MC_DLLEXPORT bool MCBrowserListGetList(MCBrowserListRef p_list, uint32_t p_index, MCBrowserListRef &r_value);
 	
diff --git a/libbrowser/src/libbrowser_value.cpp b/libbrowser/src/libbrowser_value.cpp
@@ -28,7 +28,7 @@ struct MCBrowserValue
 	{
 		bool boolean;
 		int32_t integer;
-		double_t double_val;
+		double double_val;
 		char *utf8_string;
 		MCBrowserListRef array;
 	};
@@ -89,7 +89,7 @@ bool MCBrowserValueGetInteger(MCBrowserValue &self, int32_t &r_value)
 	return true;
 }
 
-bool MCBrowserValueSetDouble(MCBrowserValue &self, double_t p_value)
+bool MCBrowserValueSetDouble(MCBrowserValue &self, double p_value)
 {
 	MCBrowserValueClear(self);
 	self.type = kMCBrowserValueTypeDouble;
@@ -98,7 +98,7 @@ bool MCBrowserValueSetDouble(MCBrowserValue &self, double_t p_value)
 	return true;
 }
 
-bool MCBrowserValueGetDouble(MCBrowserValue &self, double_t &r_value)
+bool MCBrowserValueGetDouble(MCBrowserValue &self, double &r_value)
 {
 	if (self.type != kMCBrowserValueTypeDouble)
 		return false;
@@ -138,6 +138,8 @@ bool MCBrowserValueSetList(MCBrowserValue &self, MCBrowserListRef p_value)
 	MCBrowserValueClear(self);
 	self.type = kMCBrowserValueTypeList;
 	self.array = t_array;
+
+	return true;
 }
 
 bool MCBrowserValueGetList(MCBrowserValue &self, MCBrowserListRef &r_value)
@@ -221,15 +223,15 @@ class MCBrowserList : public MCBrowserRefCounted
 		return MCBrowserValueGetInteger(m_elements[p_index], r_value);
 	}
 	
-	bool SetDouble(uint32_t p_index, double_t p_value)
+	bool SetDouble(uint32_t p_index, double p_value)
 	{
 		if (p_index >= m_size)
 			return false;
 		
 		return MCBrowserValueSetDouble(m_elements[p_index], p_value);
 	}
 
-	bool GetDouble(uint32_t p_index, double_t &r_value)
+	bool GetDouble(uint32_t p_index, double &r_value)
 	{
 		if (p_index >= m_size)
 			return false;
@@ -285,7 +287,7 @@ class MCBrowserList : public MCBrowserRefCounted
 		return Expand(m_size + 1) && SetInteger(t_index, p_value);
 	}
 	
-	bool AppendDouble(double_t p_value)
+	bool AppendDouble(double p_value)
 	{
 		uint32_t t_index;
 		t_index = m_size;
@@ -380,7 +382,7 @@ bool MCBrowserListSetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t
 	return ((MCBrowserList*)p_list)->SetInteger(p_index, p_value);
 }
 
-bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t p_value)
+bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double p_value)
 {
 	if (p_list == nil)
 		return false;
@@ -420,7 +422,7 @@ bool MCBrowserListAppendInteger(MCBrowserListRef p_list, int32_t p_value)
 	return ((MCBrowserList*)p_list)->AppendInteger(p_value);
 }
 
-bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double_t p_value)
+bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double p_value)
 {
 	if (p_list == nil)
 		return false;
@@ -460,7 +462,7 @@ bool MCBrowserListGetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t
 	return ((MCBrowserList*)p_list)->GetInteger(p_index, r_value);
 }
 
-bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t &r_value)
+bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double &r_value)
 {
 	if (p_list == nil)
 		return false;

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ struct MCBrowserValue`
`28`	`28`	`{`
`29`	`29`	`bool boolean;`
`30`	`30`	`int32_t integer;`
`31`		`- double_t double_val;`
	`31`	`+ double double_val;`
`32`	`32`	`char *utf8_string;`
`33`	`33`	`MCBrowserListRef array;`
`34`	`34`	`};`
`@@ -89,7 +89,7 @@ bool MCBrowserValueGetInteger(MCBrowserValue &self, int32_t &r_value)`
`89`	`89`	`return true;`
`90`	`90`	`}`
`91`	`91`
`92`		`-bool MCBrowserValueSetDouble(MCBrowserValue &self, double_t p_value)`
	`92`	`+bool MCBrowserValueSetDouble(MCBrowserValue &self, double p_value)`
`93`	`93`	`{`
`94`	`94`	`MCBrowserValueClear(self);`
`95`	`95`	`self.type = kMCBrowserValueTypeDouble;`
`@@ -98,7 +98,7 @@ bool MCBrowserValueSetDouble(MCBrowserValue &self, double_t p_value)`
`98`	`98`	`return true;`
`99`	`99`	`}`
`100`	`100`
`101`		`-bool MCBrowserValueGetDouble(MCBrowserValue &self, double_t &r_value)`
	`101`	`+bool MCBrowserValueGetDouble(MCBrowserValue &self, double &r_value)`
`102`	`102`	`{`
`103`	`103`	`if (self.type != kMCBrowserValueTypeDouble)`
`104`	`104`	`return false;`
`@@ -138,6 +138,8 @@ bool MCBrowserValueSetList(MCBrowserValue &self, MCBrowserListRef p_value)`
`138`	`138`	`MCBrowserValueClear(self);`
`139`	`139`	`self.type = kMCBrowserValueTypeList;`
`140`	`140`	`self.array = t_array;`
	`141`	`+`
	`142`	`+ return true;`
`141`	`143`	`}`
`142`	`144`
`143`	`145`	`bool MCBrowserValueGetList(MCBrowserValue &self, MCBrowserListRef &r_value)`
`@@ -221,15 +223,15 @@ class MCBrowserList : public MCBrowserRefCounted`
`221`	`223`	`return MCBrowserValueGetInteger(m_elements[p_index], r_value);`
`222`	`224`	`}`
`223`	`225`
`224`		`- bool SetDouble(uint32_t p_index, double_t p_value)`
	`226`	`+ bool SetDouble(uint32_t p_index, double p_value)`
`225`	`227`	`{`
`226`	`228`	`if (p_index >= m_size)`
`227`	`229`	`return false;`
`228`	`230`
`229`	`231`	`return MCBrowserValueSetDouble(m_elements[p_index], p_value);`
`230`	`232`	`}`
`231`	`233`
`232`		`- bool GetDouble(uint32_t p_index, double_t &r_value)`
	`234`	`+ bool GetDouble(uint32_t p_index, double &r_value)`
`233`	`235`	`{`
`234`	`236`	`if (p_index >= m_size)`
`235`	`237`	`return false;`
`@@ -285,7 +287,7 @@ class MCBrowserList : public MCBrowserRefCounted`
`285`	`287`	`return Expand(m_size + 1) && SetInteger(t_index, p_value);`
`286`	`288`	`}`
`287`	`289`
`288`		`- bool AppendDouble(double_t p_value)`
	`290`	`+ bool AppendDouble(double p_value)`
`289`	`291`	`{`
`290`	`292`	`uint32_t t_index;`
`291`	`293`	`t_index = m_size;`
`@@ -380,7 +382,7 @@ bool MCBrowserListSetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t`
`380`	`382`	`return ((MCBrowserList*)p_list)->SetInteger(p_index, p_value);`
`381`	`383`	`}`
`382`	`384`
`383`		`-bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t p_value)`
	`385`	`+bool MCBrowserListSetDouble(MCBrowserListRef p_list, uint32_t p_index, double p_value)`
`384`	`386`	`{`
`385`	`387`	`if (p_list == nil)`
`386`	`388`	`return false;`
`@@ -420,7 +422,7 @@ bool MCBrowserListAppendInteger(MCBrowserListRef p_list, int32_t p_value)`
`420`	`422`	`return ((MCBrowserList*)p_list)->AppendInteger(p_value);`
`421`	`423`	`}`
`422`	`424`
`423`		`-bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double_t p_value)`
	`425`	`+bool MCBrowserListAppendDouble(MCBrowserListRef p_list, double p_value)`
`424`	`426`	`{`
`425`	`427`	`if (p_list == nil)`
`426`	`428`	`return false;`
`@@ -460,7 +462,7 @@ bool MCBrowserListGetInteger(MCBrowserListRef p_list, uint32_t p_index, int32_t`
`460`	`462`	`return ((MCBrowserList*)p_list)->GetInteger(p_index, r_value);`
`461`	`463`	`}`
`462`	`464`
`463`		`-bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double_t &r_value)`
	`465`	`+bool MCBrowserListGetDouble(MCBrowserListRef p_list, uint32_t p_index, double &r_value)`
`464`	`466`	`{`
`465`	`467`	`if (p_list == nil)`
`466`	`468`	`return false;`