Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Commit 3fc19de

Browse files
[[ Gyp ]] Ensure that revdb exports all the required symbols
1 parent 42956e5 commit 3fc19de

File tree

3 files changed

+19
-6
lines changed

3 files changed

+19
-6
lines changed

libexternal/libexternal.gyp

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,5 +69,22 @@
6969
],
7070
}
7171
},
72+
{
73+
'target_name': 'libExternal-symbol-exports',
74+
'type': 'none',
75+
76+
'direct_dependent_settings':
77+
{
78+
'variables':
79+
{
80+
'ios_external_symbols':
81+
[
82+
'_getXtable',
83+
'_setExternalInterfaceVersion',
84+
'_configureSecurity',
85+
],
86+
},
87+
},
88+
},
7289
],
7390
}

libexternal/src/external.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ static ExternalDeleteCallback s_delete = NULL;
100100

101101
static ExternalSecurityHandler *s_security_handlers = NULL;
102102

103-
#if defined(_LINUX) || defined(__MACOSX) || defined(TARGET_SUBPLATFORM_ANDROID)
103+
#if !defined(_WIN32)
104104
void getXtable(ExternalOperationCallback p_operations[], ExternalDeleteCallback p_delete, const char **r_name, ExternalDeclaration **r_table, ExternalDeleteCallback *r_external_delete) __attribute__((visibility("default")));
105105
void configureSecurity(ExternalSecurityHandler *p_handlers) __attribute__((visibility("default")));
106106
void setExternalInterfaceVersion(unsigned int p_version) __attribute__((visibility("default")));

revdb/revdb.gyp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,7 @@
554554
[
555555
'../libcore/libcore.gyp:libCore',
556556
'../libexternal/libexternal.gyp:libExternal',
557+
'../libexternal/libexternal.gyp:libExternal-symbol-exports',
557558
],
558559

559560
'include_dirs':
@@ -571,11 +572,6 @@
571572
'INFOPLIST_FILE': 'rsrc/revdb-Info.plist',
572573
},
573574

574-
'variables':
575-
{
576-
'ios_external_symbols': [ '_getXtable' ],
577-
},
578-
579575
'all_dependent_settings':
580576
{
581577
'variables':

0 commit comments

Comments
 (0)