[[ Bug 21608 ]] Remove second break wait from invoke handler block

montegoulding · montegoulding · commit 4f70c2ff905a · 2018-10-19T11:28:31.000+11:00
This patch removes the call to `MCBrowserRunloopBreakWait` as we are
already using the LCB `post` command which does `MCEngineRunloopBreakWait`.

On iOS 12 this second break wait causes an app lockup that has been hard
to diagnose. Perhaps breaking an `MCFiberDispatch` `pthread_cond_wait` that
should not be broken.
diff --git a/docs/notes/bugfix-21608.md b/docs/notes/bugfix-21608.md
@@ -0,0 +1 @@
+# Fix application lockup when invoking a handler from the browser widget on iOS 12
diff --git a/libbrowser/src/libbrowser_uiwebview.mm b/libbrowser/src/libbrowser_uiwebview.mm
@@ -416,9 +416,6 @@ inline void MCBrowserRunBlockOnMainFiber(void (^p_block)(void))
 				OnJavaScriptCall([p_handler cStringUsingEncoding: NSUTF8StringEncoding], t_args);
 
 				MCBrowserListRelease(t_args);
-				
-				// IM-2016-09-30: [[ Bug 18406 ]] Wake main thread to process handler call
-				MCBrowserRunloopBreakWait();
 			}
 		};
 	}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix application lockup when invoking a handler from the browser widget on iOS 12`
Original file line number	Diff line number	Diff line change
`@@ -416,9 +416,6 @@ inline void MCBrowserRunBlockOnMainFiber(void (^p_block)(void))`
`416`	`416`	`OnJavaScriptCall([p_handler cStringUsingEncoding: NSUTF8StringEncoding], t_args);`
`417`	`417`
`418`	`418`	`MCBrowserListRelease(t_args);`
`419`		`-`
`420`		`- // IM-2016-09-30: [[ Bug 18406 ]] Wake main thread to process handler call`
`421`		`- MCBrowserRunloopBreakWait();`
`422`	`419`	`}`
`423`	`420`	`};`
`424`	`421`	`}`