[CID 16621] revxml: Fix memory leak in XML_ListByAttributeValue()

peter-b · peter-b · commit 51830916cbbf · 2017-01-24T12:51:44.000Z
`XML_ListByAttributeValue()` was leaking each attribute value.
Attribute values are allocated with `strdup()`, and therefore should
be destroyed with `free()`.

Coverity-ID: 16621
diff --git a/revxml/src/revxml.cpp b/revxml/src/revxml.cpp
@@ -2096,6 +2096,7 @@ void XML_ListByAttributeValue(char *args[], int nargs, char **retstring,
 						if (attributevalue){
 							util_concatstring(attributevalue, strlen(attributevalue), 
 							result, buflen , bufsize);
+                            free(attributevalue);
 						}
 						util_concatstring(itemsep, itemseplen,result, buflen , bufsize);
 				}

Original file line number	Diff line number	Diff line change
`@@ -2096,6 +2096,7 @@ void XML_ListByAttributeValue(char args[], int nargs, char *retstring,`
`2096`	`2096`	`if (attributevalue){`
`2097`	`2097`	`util_concatstring(attributevalue, strlen(attributevalue),`
`2098`	`2098`	`result, buflen , bufsize);`
	`2099`	`+ free(attributevalue);`
`2099`	`2100`	`}`
`2100`	`2101`	`util_concatstring(itemsep, itemseplen,result, buflen , bufsize);`
`2101`	`2102`	`}`