[[ BrowserWidget ]] Don't signal failure in get/set unsupported property

livecodeian · livecodeian · commit 61c0da8f7673 · 2015-08-20T14:27:29.000+01:00
diff --git a/libbrowser/src/libbrowser_android.cpp b/libbrowser/src/libbrowser_android.cpp
@@ -141,7 +141,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase
 				break;
 		}
 		
-		return false;
+		return true;
 	}
 	
 	virtual bool SetBoolProperty(MCBrowserProperty p_property, bool p_value)
@@ -155,7 +155,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase
 				break;
 		}
 		
-		return false;
+		return true;
 	}
 	
 	virtual bool GetStringProperty(MCBrowserProperty p_property, char *&r_utf8_string)
@@ -172,7 +172,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase
 				break;
 		}
 		
-		return false;
+		return true;
 	}
 	
 	virtual bool SetStringProperty(MCBrowserProperty p_property, const char *p_utf8_string)
@@ -186,7 +186,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase
 				break;
 		}
 		
-		return false;
+		return true;
 	}
 	
 	virtual bool GoBack()
diff --git a/libbrowser/src/libbrowser_cef.cpp b/libbrowser/src/libbrowser_cef.cpp
@@ -1437,7 +1437,7 @@ bool MCCefBrowserBase::GetBoolProperty(MCBrowserProperty p_property, bool &r_val
 			break;
 	}
 	
-	return false;
+	return true;
 }
 
 bool MCCefBrowserBase::SetBoolProperty(MCBrowserProperty p_property, bool p_value)
@@ -1460,7 +1460,7 @@ bool MCCefBrowserBase::SetBoolProperty(MCBrowserProperty p_property, bool p_valu
 			break;
 	}
 	
-	return false;
+	return true;
 }
 
 bool MCCefBrowserBase::SetStringProperty(MCBrowserProperty p_property, const char *p_value)
@@ -1482,7 +1482,7 @@ bool MCCefBrowserBase::SetStringProperty(MCBrowserProperty p_property, const cha
 			break;
 	}
 	
-	return false;
+	return true;
 }
 
 bool MCCefBrowserBase::GetStringProperty(MCBrowserProperty p_property, char *&r_value)
@@ -1508,7 +1508,7 @@ bool MCCefBrowserBase::GetStringProperty(MCBrowserProperty p_property, char *&r_
 			break;
 	}
 	
-	return false;
+	return true;
 }
 
 ////////////////////////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase`
`141`	`141`	`break;`
`142`	`142`	`}`
`143`	`143`
`144`		`- return false;`
	`144`	`+ return true;`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`virtual bool SetBoolProperty(MCBrowserProperty p_property, bool p_value)`
`@@ -155,7 +155,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase`
`155`	`155`	`break;`
`156`	`156`	`}`
`157`	`157`
`158`		`- return false;`
	`158`	`+ return true;`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`virtual bool GetStringProperty(MCBrowserProperty p_property, char *&r_utf8_string)`
`@@ -172,7 +172,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase`
`172`	`172`	`break;`
`173`	`173`	`}`
`174`	`174`
`175`		`- return false;`
	`175`	`+ return true;`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`virtual bool SetStringProperty(MCBrowserProperty p_property, const char *p_utf8_string)`
`@@ -186,7 +186,7 @@ class MCAndroidWebViewBrowser : public MCBrowserBase`
`186`	`186`	`break;`
`187`	`187`	`}`
`188`	`188`
`189`		`- return false;`
	`189`	`+ return true;`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`virtual bool GoBack()`
Original file line number	Diff line number	Diff line change
`@@ -1437,7 +1437,7 @@ bool MCCefBrowserBase::GetBoolProperty(MCBrowserProperty p_property, bool &r_val`
`1437`	`1437`	`break;`
`1438`	`1438`	`}`
`1439`	`1439`
`1440`		`- return false;`
	`1440`	`+ return true;`
`1441`	`1441`	`}`
`1442`	`1442`
`1443`	`1443`	`bool MCCefBrowserBase::SetBoolProperty(MCBrowserProperty p_property, bool p_value)`
`@@ -1460,7 +1460,7 @@ bool MCCefBrowserBase::SetBoolProperty(MCBrowserProperty p_property, bool p_valu`
`1460`	`1460`	`break;`
`1461`	`1461`	`}`
`1462`	`1462`
`1463`		`- return false;`
	`1463`	`+ return true;`
`1464`	`1464`	`}`
`1465`	`1465`
`1466`	`1466`	`bool MCCefBrowserBase::SetStringProperty(MCBrowserProperty p_property, const char *p_value)`
`@@ -1482,7 +1482,7 @@ bool MCCefBrowserBase::SetStringProperty(MCBrowserProperty p_property, const cha`
`1482`	`1482`	`break;`
`1483`	`1483`	`}`
`1484`	`1484`
`1485`		`- return false;`
	`1485`	`+ return true;`
`1486`	`1486`	`}`
`1487`	`1487`
`1488`	`1488`	`bool MCCefBrowserBase::GetStringProperty(MCBrowserProperty p_property, char *&r_value)`
`@@ -1508,7 +1508,7 @@ bool MCCefBrowserBase::GetStringProperty(MCBrowserProperty p_property, char *&r_`
`1508`	`1508`	`break;`
`1509`	`1509`	`}`
`1510`	`1510`
`1511`		`- return false;`
	`1511`	`+ return true;`
`1512`	`1512`	`}`
`1513`	`1513`
`1514`	`1514`	`////////////////////////////////////////////////////////////////////////////////`