[CID 125394] Use correct deallocator for IO_read_cstring_legacy result

peter-b · peter-b · commit 64a4e3ef378f · 2017-02-06T16:37:07.000Z
`IO_read_cstring_legacy()` allocates the buffer it returns using
`MCMemoryAllocate()`.

Coverity-ID: 125394
diff --git a/engine/src/block.cpp b/engine/src/block.cpp
@@ -266,10 +266,8 @@ IO_stat MCBlock::load(IO_handle stream, uint32_t version, bool is_ext)
 			//   so load, delete and unset the flag.
 			// MW-2013-11-19: [[ UnicodeFileFormat ]] The storage of this is ignored,
 			//   so is legacy,
-			char *backcolorname;
-			if ((stat = IO_read_cstring_legacy(backcolorname, stream, 2)) != IO_NORMAL)
+			if ((stat = IO_discard_cstring_legacy(stream, 2)) != IO_NORMAL)
 				return checkloadstat(stat);
-			delete backcolorname;
 			flags &= ~F_HAS_BACK_COLOR_NAME;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -266,10 +266,8 @@ IO_stat MCBlock::load(IO_handle stream, uint32_t version, bool is_ext)`
`266`	`266`	`// so load, delete and unset the flag.`
`267`	`267`	`// MW-2013-11-19: [[ UnicodeFileFormat ]] The storage of this is ignored,`
`268`	`268`	`// so is legacy,`
`269`		`- char *backcolorname;`
`270`		`- if ((stat = IO_read_cstring_legacy(backcolorname, stream, 2)) != IO_NORMAL)`
	`269`	`+ if ((stat = IO_discard_cstring_legacy(stream, 2)) != IO_NORMAL)`
`271`	`270`	`return checkloadstat(stat);`
`272`		`- delete backcolorname;`
`273`	`271`	`flags &= ~F_HAS_BACK_COLOR_NAME;`
`274`	`272`	`}`
`275`	`273`	`}`