[[ Bug 20013 ]] RevDB database types should be case insensitive.

livecodemichael · livecodemichael · commit 757f170aec39 · 2017-08-09T10:06:16.000+01:00
The database type passed to revOpenDatabase is used by revdb to
find the appropriate driver. Make sure we convert the type to
lowercase in order to find the correct driver in case sensitive
systems (the driver file names are all lowercase).
diff --git a/docs/notes/bugfix-20013.md b/docs/notes/bugfix-20013.md
@@ -0,0 +1 @@
+# Database type passed to revOpenDatabase should be case insensitive
diff --git a/revdb/src/revdb.cpp b/revdb/src/revdb.cpp
@@ -291,26 +291,30 @@ DATABASEREC *LoadDatabaseDriver(const char *p_type)
 {
     DATABASEREC *t_database_rec = nullptr;
     
+    char t_type[32];
+    strcpy(t_type, p_type);
+    strlwr(t_type);
+
     if (revdbdriverpaths != nullptr)
     {
         t_database_rec = LoadDatabaseDriverInFolder(revdbdriverpaths, p_type);
     }
     else
     {
-        t_database_rec = LoadDatabaseDriverInFolder(".", p_type);
+        t_database_rec = LoadDatabaseDriverInFolder(".", t_type);
         
         
         if (t_database_rec == nullptr)
             t_database_rec = LoadDatabaseDriverInFolder("./Database Drivers",
-                                                        p_type);
+                                                        t_type);
 
         if (t_database_rec == nullptr)
             t_database_rec = LoadDatabaseDriverInFolder("./database_drivers",
-                                                        p_type);
+                                                        t_type);
 
         if (t_database_rec == nullptr)
             t_database_rec = LoadDatabaseDriverInFolder("./drivers",
-                                                        p_type);
+                                                        t_type);
     }
     
     if (t_database_rec != nullptr)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Database type passed to revOpenDatabase should be case insensitive`
Original file line number	Diff line number	Diff line change
`@@ -291,26 +291,30 @@ DATABASEREC LoadDatabaseDriver(const char p_type)`
`291`	`291`	`{`
`292`	`292`	`DATABASEREC *t_database_rec = nullptr;`
`293`	`293`
	`294`	`+ char t_type[32];`
	`295`	`+ strcpy(t_type, p_type);`
	`296`	`+ strlwr(t_type);`
	`297`	`+`
`294`	`298`	`if (revdbdriverpaths != nullptr)`
`295`	`299`	`{`
`296`	`300`	`t_database_rec = LoadDatabaseDriverInFolder(revdbdriverpaths, p_type);`
`297`	`301`	`}`
`298`	`302`	`else`
`299`	`303`	`{`
`300`		`- t_database_rec = LoadDatabaseDriverInFolder(".", p_type);`
	`304`	`+ t_database_rec = LoadDatabaseDriverInFolder(".", t_type);`
`301`	`305`
`302`	`306`
`303`	`307`	`if (t_database_rec == nullptr)`
`304`	`308`	`t_database_rec = LoadDatabaseDriverInFolder("./Database Drivers",`
`305`		`- p_type);`
	`309`	`+ t_type);`
`306`	`310`
`307`	`311`	`if (t_database_rec == nullptr)`
`308`	`312`	`t_database_rec = LoadDatabaseDriverInFolder("./database_drivers",`
`309`		`- p_type);`
	`313`	`+ t_type);`
`310`	`314`
`311`	`315`	`if (t_database_rec == nullptr)`
`312`	`316`	`t_database_rec = LoadDatabaseDriverInFolder("./drivers",`
`313`		`- p_type);`
	`317`	`+ t_type);`
`314`	`318`	`}`
`315`	`319`
`316`	`320`	`if (t_database_rec != nullptr)`