[[ Bug 19536 ]] Fix menu not closing when clicking on other side

montegoulding · montegoulding · commit 7d3a28eee853 · 2018-03-12T15:20:26.000+11:00
This patch  fixes a bugh where the stack of the button with the menu
was being used to determine if the user clicked away from the menu
rather than the menu stack itself. This was causing the menu to only
dismiss if the use clicked in a location less than the top left of the
button.
diff --git a/docs/notes/bugfix-19536.md b/docs/notes/bugfix-19536.md
@@ -0,0 +1 @@
+# Fix menu not being dismissed when user clicks on location greater than menu right or bottom
diff --git a/engine/src/button.cpp b/engine/src/button.cpp
@@ -1373,7 +1373,7 @@ Boolean MCButton::mup(uint2 which, bool p_release)
                 // We also need to close the menu if the button release happened
                 // outside of the menu tree.
                 bool t_outside = true;
-                MCObject* t_menu = this;
+                MCObject* t_menu = menu;
                 while (t_outside && t_menu != NULL)
                 {
                     // Check whether the click was inside the menu (the rect

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix menu not being dismissed when user clicks on location greater than menu right or bottom`
Original file line number	Diff line number	Diff line change
`@@ -1373,7 +1373,7 @@ Boolean MCButton::mup(uint2 which, bool p_release)`
`1373`	`1373`	`// We also need to close the menu if the button release happened`
`1374`	`1374`	`// outside of the menu tree.`
`1375`	`1375`	`bool t_outside = true;`
`1376`		`- MCObject* t_menu = this;`
	`1376`	`+ MCObject* t_menu = menu;`
`1377`	`1377`	`while (t_outside && t_menu != NULL)`
`1378`	`1378`	`{`
`1379`	`1379`	`// Check whether the click was inside the menu (the rect`