[[ Bug 20510 ]] Fix crash in revDatabaseTableNames

runrevmark · runrevmark · commit 8c52ea4dd4e8 · 2017-10-06T15:31:53.000+01:00
This patch ensures the m_internal_buffer instance var introduced
in the MySQL and PostgreSQL drivers to fix the length limit of
the revDatabaseTableNames call is initialized to nullptr when
the connection is created.
diff --git a/docs/notes/bugfix-20510.md b/docs/notes/bugfix-20510.md
@@ -0,0 +1 @@
+# Fix crash on Windows when using revDatabaseTableNames()
diff --git a/revdb/src/dbmysql.h b/revdb/src/dbmysql.h
@@ -52,6 +52,7 @@ class DBCursor_MYSQL:public CDBCursor
 class DBConnection_MYSQL: public CDBConnection
 {
 public:
+    DBConnection_MYSQL(): m_internal_buffer(nullptr) {}
 	~DBConnection_MYSQL() {disconnect();}
 	Bool connect(char **args, int numargs);
 	void disconnect();
@@ -67,10 +68,11 @@ class DBConnection_MYSQL: public CDBConnection
 	void getTables(char *buffer, int *bufsize);
 	int getConnectionType(void) { return -1; }
 	int getVersion(void) { return 2; }
-    large_buffer_t *m_internal_buffer;
 protected:
 	bool BindVariables(MYSQL_STMT *p_statement, DBString *p_arguments, int p_argument_count, int *p_placeholders, int p_placeholder_count, MYSQL_BIND **p_bind);
 	bool ExecuteQuery(char *p_query, DBString *p_arguments, int p_argument_count);
 	MYSQL mysql;
+private:
+    large_buffer_t *m_internal_buffer;
 };
 #endif
diff --git a/revdb/src/dbpostgresql.h b/revdb/src/dbpostgresql.h
@@ -123,6 +123,7 @@ class DBCursor_POSTGRESQL:public CDBCursor
 class DBConnection_POSTGRESQL: public CDBConnection
 {
 public:
+    DBConnection_POSTGRESQL(): m_internal_buffer(nullptr) {}
 	~DBConnection_POSTGRESQL() {disconnect();}
 	Bool connect(char **args, int numargs);
 	void disconnect();

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix crash on Windows when using revDatabaseTableNames()`
Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ class DBCursor_POSTGRESQL:public CDBCursor`
`123`	`123`	`class DBConnection_POSTGRESQL: public CDBConnection`
`124`	`124`	`{`
`125`	`125`	`public:`
	`126`	`+ DBConnection_POSTGRESQL(): m_internal_buffer(nullptr) {}`
`126`	`127`	`~DBConnection_POSTGRESQL() {disconnect();}`
`127`	`128`	`Bool connect(char **args, int numargs);`
`128`	`129`	`void disconnect();`