[[ Bug 17969 ]] Fixed bug causing erronous rendering when creating ovals

abrisan · abrisan · commit 94911cb032ef · 2017-05-24T09:37:09.000+01:00
diff --git a/docs/notes/bugfix-17969.md b/docs/notes/bugfix-17969.md
@@ -0,0 +1 @@
+# Fixed bug preventing correct rendering of ovals when creating them
diff --git a/libgraphics/src/path.cpp b/libgraphics/src/path.cpp
@@ -488,8 +488,8 @@ void MCGPathAddArc(MCGPathRef self, MCGPoint p_center, MCGSize p_radii, MCGFloat
 		{
 			// Use Skia implementation
 			SkRect t_bounds;
-			t_bounds = SkRect::MakeXYWH(MCGCoordToSkCoord(p_center . x - p_radii . width), MCGCoordToSkCoord(p_center . y - p_radii . height),
-			                            MCGFloatToSkScalar(p_radii . width * 2), MCGFloatToSkScalar(p_radii . height * 2));
+			t_bounds = SkRect::MakeXYWH(MCGCoordToSkCoord(p_center . x - (p_radii . width * 0.5f)), MCGCoordToSkCoord(p_center . y - (p_radii . height * 0.5f)),
+			                            MCGFloatToSkScalar(p_radii . width), MCGFloatToSkScalar(p_radii . height));
 			self -> path -> addArc(t_bounds, MCGFloatToSkScalar(p_start_angle), MCGFloatToSkScalar(p_finish_angle - p_start_angle));
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fixed bug preventing correct rendering of ovals when creating them`
Original file line number	Diff line number	Diff line change
`@@ -488,8 +488,8 @@ void MCGPathAddArc(MCGPathRef self, MCGPoint p_center, MCGSize p_radii, MCGFloat`
`488`	`488`	`{`
`489`	`489`	`// Use Skia implementation`
`490`	`490`	`SkRect t_bounds;`
`491`		`- t_bounds = SkRect::MakeXYWH(MCGCoordToSkCoord(p_center . x - p_radii . width), MCGCoordToSkCoord(p_center . y - p_radii . height),`
`492`		`- MCGFloatToSkScalar(p_radii . width * 2), MCGFloatToSkScalar(p_radii . height * 2));`
	`491`	`+ t_bounds = SkRect::MakeXYWH(MCGCoordToSkCoord(p_center . x - (p_radii . width * 0.5f)), MCGCoordToSkCoord(p_center . y - (p_radii . height * 0.5f)),`
	`492`	`+ MCGFloatToSkScalar(p_radii . width), MCGFloatToSkScalar(p_radii . height));`
`493`	`493`	`self -> path -> addArc(t_bounds, MCGFloatToSkScalar(p_start_angle), MCGFloatToSkScalar(p_finish_angle - p_start_angle));`
`494`	`494`	`}`
`495`	`495`	`}`