[[ CID 90610 ]] Return the appropriate error when Enumerating the zip items fails

livecodesebastien · livecodesebastien · commit ace3c872ee3e · 2015-06-02T12:12:08.000+01:00
diff --git a/revzip/src/revzip.cpp b/revzip/src/revzip.cpp
@@ -1275,7 +1275,10 @@ void revZipEnumerateItems(char *p_arguments[], int p_argument_count, char **r_re
 			{
 				std::string t_outerr = "ziperr," + std::string((zip_strerror(t_archive)));
 				t_result = strdup(t_outerr.c_str());
-				t_error = False;
+                // SN-2015-06-02: [[ CID 90610 ]] Quit the loop if an error is
+                //  encountered - and set t_error to the right value.
+				t_error = True;
+                break;
 			}
 			else
 			{

Original file line number	Diff line number	Diff line change
`@@ -1275,7 +1275,10 @@ void revZipEnumerateItems(char p_arguments[], int p_argument_count, char *r_re`
`1275`	`1275`	`{`
`1276`	`1276`	`std::string t_outerr = "ziperr," + std::string((zip_strerror(t_archive)));`
`1277`	`1277`	`t_result = strdup(t_outerr.c_str());`
`1278`		`- t_error = False;`
	`1278`	`+ // SN-2015-06-02: [[ CID 90610 ]] Quit the loop if an error is`
	`1279`	`+ // encountered - and set t_error to the right value.`
	`1280`	`+ t_error = True;`
	`1281`	`+ break;`
`1279`	`1282`	`}`
`1280`	`1283`	`else`
`1281`	`1284`	`{`