[[ emscripten ]] Add HiDPI support to emscripten engine

livecode-vulcan · Ian Macphail · commit b371af846305 · 2021-06-24T09:37:31.000+01:00
This patch adds support for rendering at high DPI, based on the
JavaScript 'window.devicePixelRatio' property
diff --git a/engine/src/em-dc.cpp b/engine/src/em-dc.cpp
@@ -33,6 +33,8 @@ along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
 #include "globals.h"
 #include "graphics_util.h"
 
+#include <emscripten.h>
+
 /* ================================================================
  * Helper Functions
  * ================================================================ */
@@ -258,6 +260,7 @@ bool MCScreenDC::platform_getdisplays(bool p_effective, MCDisplay *&r_displays,
 		return false;
 	
 	t_display->viewport = t_display->workarea = MCEmscriptenGetDisplayRect();
+	t_display->pixel_scale = emscripten_get_device_pixel_ratio();
 	
 	r_displays = t_display;
 	r_count = 1;
diff --git a/engine/src/em-resolution.cpp b/engine/src/em-resolution.cpp
@@ -29,17 +29,18 @@ along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
  * Resolution independence
  * ================================================================ */
 
-/* FIXME use emscripten_get_device_pixel_ratio() */
+static MCGFloat s_emscripten_device_scale = 1.0;
 
 void
 MCResPlatformInitPixelScaling()
 {
+	s_emscripten_device_scale = emscripten_get_device_pixel_ratio();
 }
 
 bool
 MCResPlatformSupportsPixelScaling()
 {
-	return false;
+	return true;
 }
 
 bool
@@ -57,15 +58,13 @@ MCResPlatformCanSetPixelScale()
 MCGFloat
 MCResPlatformGetDefaultPixelScale()
 {
-	MCEmscriptenNotImplemented();
-	return NAN;
+	return s_emscripten_device_scale;
 }
 
 MCGFloat
 MCResPlatformGetUIDeviceScale()
 {
-	MCEmscriptenNotImplemented();
-	return NAN;
+	return s_emscripten_device_scale;
 }
 
 void
diff --git a/engine/src/em-stack.cpp b/engine/src/em-stack.cpp
@@ -32,6 +32,8 @@ along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
 #include "graphics_util.h"
 #include "globals.h"
 
+#include "region.h"
+
 /* ================================================================
  * Stack initialisation
  * ================================================================ */
@@ -109,34 +111,83 @@ MCStack::release_window_buffer()
  * View management
  * ================================================================ */
 
+static MCStackUpdateCallback s_updatewindow_callback = nullptr;
+static void *s_updatewindow_context = nullptr;
+
 bool MCStack::view_platform_dirtyviewonresize() const
 {
 	return true;
 }
 
-void
-MCStack::view_platform_updatewindow(MCRegionRef p_dirty_region)
+void MCStack::view_platform_updatewindowwithcallback(MCRegionRef p_region, MCStackUpdateCallback p_callback, void *p_context)
+{
+	s_updatewindow_callback = p_callback;
+	s_updatewindow_context = p_context;
+
+	view_platform_updatewindow(p_region);
+
+	s_updatewindow_callback = nil;
+	s_updatewindow_context = nil;
+}
+
+void MCStack::view_platform_updatewindow(MCRegionRef p_dirty_region)
 {
-	/* FIXME implement HiDPI support */
+	MCRegionRef t_scaled_region;
+	t_scaled_region = nil;
+	
+	MCRegionRef t_screen_region;
+	t_screen_region = nil;
+	
+	MCGFloat t_scale;
+	t_scale = MCResGetPixelScale();
+	
+	if (t_scale != 1.0)
+	{
+		/* UNCHECKED */ MCRegionTransform(p_dirty_region, MCGAffineTransformMakeScale(t_scale, t_scale), t_scaled_region);
+		t_screen_region = t_scaled_region;
+	}
+	else
+		t_screen_region = p_dirty_region;
+	
+	view_device_updatewindow(t_screen_region);
+	
+	if (t_scaled_region != nil)
+		MCRegionDestroy(t_scaled_region);
+}
 
+void MCStack::view_device_updatewindow(MCRegionRef p_region)
+{
 	/* dirtyrect() calls that occur prior to configure() being called
 	 * for the first time will result in an update region being too
 	 * big. Restrict to a valid region. */
 
 	uint32_t t_window = reinterpret_cast<uint32_t>(window);
 	
-	MCGRegionRef t_region = MCGRegionRef(p_dirty_region);
-	MCRectangle t_valid = MCEmscriptenGetWindowRect(t_window);
-	t_valid.x = t_valid.y = 0;
+	MCRectangle t_window_rect = MCEmscriptenGetWindowRect(t_window);
+	MCRectangle t_canvas_rect = MCRectangleGetScaledCeilingRect(t_window_rect, MCResGetPixelScale());
+	t_canvas_rect.x = t_canvas_rect.y = 0;
 
-	MCGRegionIntersectRect(t_region, MCRectangleToMCGIntegerRectangle(t_valid));
+	MCGRegionRef t_region = MCGRegionRef(p_region);
 
-    MCGIntegerRectangle t_rect = MCGRegionGetBounds(t_region);
+	MCGRegionIntersectRect(t_region, MCRectangleToMCGIntegerRectangle(t_canvas_rect));
 
-	MCEmscriptenSyncCanvasSize(t_window, t_valid.width, t_valid.height);
-	
-    MCHtmlCanvasStackSurface t_surface(t_window, t_rect);
-	view_surface_redrawwindow(&t_surface, t_region);
+	MCGIntegerRectangle t_rect = MCGRegionGetBounds(t_region);
+	MCEmscriptenSyncCanvasSize(t_window, t_canvas_rect.width, t_canvas_rect.height);
+
+	// IM-2014-01-30: [[ HiDPI ]] Ensure stack backing scale is set
+	view_setbackingscale(MCResGetPixelScale());
+
+	MCHtmlCanvasStackSurface t_surface(t_window, MCGRegionGetBounds(t_region));
+	if (t_surface.Lock())
+	{
+		// IM-2014-01-31: [[ HiDPI ]] If a callback is given then use it to render to the surface
+		if (s_updatewindow_callback != nil)
+			s_updatewindow_callback(&t_surface, (MCRegionRef)t_region, s_updatewindow_context);
+		else
+			view_surface_redrawwindow(&t_surface, t_region);
+
+		t_surface.Unlock();
+	}
 }
 
 MCRectangle
diff --git a/engine/src/stack.h b/engine/src/stack.h
@@ -1029,7 +1029,7 @@ class MCStack : public MCObject, public MCMixinObjectHandle<MCStack>
 		uint32_t p_minwidth, uint32_t p_minheight,
 		uint32_t p_maxwidth, uint32_t p_maxheight);
 	void view_device_updatewindow(MCRegionRef p_region);
-#elif defined(_MOBILE)
+#elif defined(_MOBILE) || defined(__EMSCRIPTEN__)
 
 	// IM-2014-01-30: [[ HiDPI ]] platform-specific view device methods
 	

Original file line number	Diff line number	Diff line change
`@@ -29,17 +29,18 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */`
`29`	`29`	`* Resolution independence`
`30`	`30`	`* ================================================================ */`
`31`	`31`
`32`		`-/* FIXME use emscripten_get_device_pixel_ratio() */`
	`32`	`+static MCGFloat s_emscripten_device_scale = 1.0;`
`33`	`33`
`34`	`34`	`void`
`35`	`35`	`MCResPlatformInitPixelScaling()`
`36`	`36`	`{`
	`37`	`+ s_emscripten_device_scale = emscripten_get_device_pixel_ratio();`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`bool`
`40`	`41`	`MCResPlatformSupportsPixelScaling()`
`41`	`42`	`{`
`42`		`- return false;`
	`43`	`+ return true;`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`bool`
`@@ -57,15 +58,13 @@ MCResPlatformCanSetPixelScale()`
`57`	`58`	`MCGFloat`
`58`	`59`	`MCResPlatformGetDefaultPixelScale()`
`59`	`60`	`{`
`60`		`- MCEmscriptenNotImplemented();`
`61`		`- return NAN;`
	`61`	`+ return s_emscripten_device_scale;`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`MCGFloat`
`65`	`65`	`MCResPlatformGetUIDeviceScale()`
`66`	`66`	`{`
`67`		`- MCEmscriptenNotImplemented();`
`68`		`- return NAN;`
	`67`	`+ return s_emscripten_device_scale;`
`69`	`68`	`}`
`70`	`69`
`71`	`70`	`void`