[[ Cleanup ]] revpdfprinter: Provide switch branches for all enum members.

peter-b · peter-b · commit cb67f2dc77ee · 2014-12-30T13:17:43.000Z
diff --git a/revpdfprinter/src/revpdfprinter.cpp b/revpdfprinter/src/revpdfprinter.cpp
@@ -17,6 +17,7 @@ along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
 #include "revpdfprinter.h"
 
 #include <cairo-pdf.h>
+#include <stdlib.h>
 #include <stdio.h>
 #include <float.h>
 
@@ -214,8 +215,10 @@ bool MCPDFPrintingDevice::CanRenderPaint(const MCCustomPrinterPaint& p_paint)
 		return p_paint.gradient.type == kMCCustomPrinterGradientLinear ||
 			p_paint.gradient.type == kMCCustomPrinterGradientRadial;
 		break;
+	case kMCCustomPrinterPaintNone:
+	default:
+		return false;
 	}
-	return false;
 }
 
 bool MCPDFPrintingDevice::CanRenderImage(const MCCustomPrinterImage& p_image)
@@ -811,6 +814,9 @@ bool MCPDFPrintingDevice::draw_path(const MCCustomPrinterPath &p_path)
 				t_points += 3;
 			}
 			break;
+		case kMCCustomPrinterPathEnd:
+			/* Shouldn't ever be reached */
+			abort();
 		}
 		t_success = (m_status = cairo_status(m_context)) == CAIRO_STATUS_SUCCESS;
 	}
@@ -869,6 +875,8 @@ bool MCPDFPrintingDevice::apply_paint(const MCCustomPrinterPaint &p_paint)
 			case kMCCustomPrinterGradientRadial:
 				t_paint_pattern = cairo_pattern_create_radial(0, 0, 0, 0, 0, t_extent);
 				break;
+			default:
+				break;
 			}
 			if (p_paint.gradient.repeat > 1 && !p_paint.gradient.wrap)
 			{
@@ -960,6 +968,8 @@ bool MCPDFPrintingDevice::apply_paint(const MCCustomPrinterPaint &p_paint)
 			init_matrix(t_transform, p_paint.gradient.transform);
 		}
 		break;
+	case kMCCustomPrinterPaintNone:
+		break;
 	}
 	if (t_paint_pattern != nil && t_success)
 	{

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */`
`17`	`17`	`#include "revpdfprinter.h"`
`18`	`18`
`19`	`19`	`#include <cairo-pdf.h>`
	`20`	`+#include <stdlib.h>`
`20`	`21`	`#include <stdio.h>`
`21`	`22`	`#include <float.h>`
`22`	`23`
`@@ -214,8 +215,10 @@ bool MCPDFPrintingDevice::CanRenderPaint(const MCCustomPrinterPaint& p_paint)`
`214`	`215`	`return p_paint.gradient.type == kMCCustomPrinterGradientLinear \|\|`
`215`	`216`	`p_paint.gradient.type == kMCCustomPrinterGradientRadial;`
`216`	`217`	`break;`
	`218`	`+ case kMCCustomPrinterPaintNone:`
	`219`	`+ default:`
	`220`	`+ return false;`
`217`	`221`	`}`
`218`		`- return false;`
`219`	`222`	`}`
`220`	`223`
`221`	`224`	`bool MCPDFPrintingDevice::CanRenderImage(const MCCustomPrinterImage& p_image)`
`@@ -811,6 +814,9 @@ bool MCPDFPrintingDevice::draw_path(const MCCustomPrinterPath &p_path)`
`811`	`814`	`t_points += 3;`
`812`	`815`	`}`
`813`	`816`	`break;`
	`817`	`+ case kMCCustomPrinterPathEnd:`
	`818`	`+ /* Shouldn't ever be reached */`
	`819`	`+ abort();`
`814`	`820`	`}`
`815`	`821`	`t_success = (m_status = cairo_status(m_context)) == CAIRO_STATUS_SUCCESS;`
`816`	`822`	`}`
`@@ -869,6 +875,8 @@ bool MCPDFPrintingDevice::apply_paint(const MCCustomPrinterPaint &p_paint)`
`869`	`875`	`case kMCCustomPrinterGradientRadial:`
`870`	`876`	`t_paint_pattern = cairo_pattern_create_radial(0, 0, 0, 0, 0, t_extent);`
`871`	`877`	`break;`
	`878`	`+ default:`
	`879`	`+ break;`
`872`	`880`	`}`
`873`	`881`	`if (p_paint.gradient.repeat > 1 && !p_paint.gradient.wrap)`
`874`	`882`	`{`
`@@ -960,6 +968,8 @@ bool MCPDFPrintingDevice::apply_paint(const MCCustomPrinterPaint &p_paint)`
`960`	`968`	`init_matrix(t_transform, p_paint.gradient.transform);`
`961`	`969`	`}`
`962`	`970`	`break;`
	`971`	`+ case kMCCustomPrinterPaintNone:`
	`972`	`+ break;`
`963`	`973`	`}`
`964`	`974`	`if (t_paint_pattern != nil && t_success)`
`965`	`975`	`{`