[[ Bug 13827 ]] Use UTF-8 strings when building iOS externals

livecodesebastien · livecodesebastien · commit de2d5ab7a807 · 2014-10-28T10:26:43.000Z
diff --git a/docs/notes/bugfix-13827.md b/docs/notes/bugfix-13827.md
@@ -0,0 +1 @@
+# Can't use double-byte characters for a standalone name
diff --git a/ide-support/revdeploylibraryios.livecodescript b/ide-support/revdeploylibraryios.livecodescript
@@ -185,7 +185,7 @@ command deployDo pTargetStack, pSimulator, pAppBundle
       
       put empty into sDeploySimulationStatus
       try
-         revIPhoneLaunchAppInSimulator tTempAppBundle, tFamily, "revIDEDeployIOSLaunchCallback"
+         revIPhoneLaunchAppInSimulator textEncode(tTempAppBundle, "utf-8"), tFamily, "revIDEDeployIOSLaunchCallback"
       catch tException
       end try
       
diff --git a/ide-support/revsaveasiosstandalone.livecodescript b/ide-support/revsaveasiosstandalone.livecodescript
@@ -1246,10 +1246,11 @@ private command revCreateMobilePlist pSettings, pAppBundle, pTarget, pFonts
    
    local tPlist
    put url ("file:" & tTemplateFile) into tPlist
-   replace "${EXECUTABLE_NAME}" with tExeName in tPlist
-   replace "${BUNDLE_IDENTIFIER}" with tBundleId in tPlist
+   // SN-2014-10-27: [[ Bug 13827 ]] Strings in a Plist file should be UTF-8 encoded
+   replace "${EXECUTABLE_NAME}" with textEncode(tExeName, "utf-8") in tPlist
+   replace "${BUNDLE_IDENTIFIER}" with textEncode(tBundleId, "utf-8") in tPlist
    replace "${BUNDLE_VERSION}" with tBundleVersion in tPlist
-   replace "${BUNDLE_DISPLAY_NAME_SUPPORT}" with "<string>" & tDisplayName & "</string>" in tPlist
+   replace "${BUNDLE_DISPLAY_NAME_SUPPORT}" with "<string>" & textEncode(tDisplayName, "utf-8") & "</string>" in tPlist
    replace "${MINIMUM_OS_SUPPORT}" with "<string>" & tMinimumOS & "</string>" in tPlist
    replace "${CUSTOM_FONTS}" with tCustomFonts in tPlist
    
diff --git a/revmobile/src/reviphone.mm b/revmobile/src/reviphone.mm
@@ -494,10 +494,10 @@ bool revIPhoneLaunchAppInSimulator(MCVariableRef *argv, uint32_t argc, MCVariabl
 		t_success = Throw("simulator already running");
 	
 	// Fetch the app path
-	const char *t_app;
-	t_app = nil;
+	MCString t_app;
 	if (t_success)
-		t_success = CheckError(MCVariableFetch(argv[0], kMCOptionAsCString, &t_app));
+        // SN-2014-10-28: [[ Bug 13827 ]] Fetch the string as an MCString (to allow UTF-8 characters)
+		t_success = CheckError(MCVariableFetch(argv[0], kMCOptionAsString, &t_app));
 	
 	// Fetch the family string
 	const char *t_family;
@@ -533,7 +533,8 @@ bool revIPhoneLaunchAppInSimulator(MCVariableRef *argv, uint32_t argc, MCVariabl
 		[t_delegate setMessage: t_callback];
 		[t_delegate setTarget: t_target];
 
-		t_app_spec = [s_simulator_proxy specifierWithApplicationPath: [NSString stringWithCString:t_app encoding: NSMacOSRomanStringEncoding]];
+        // SN-2014-10-27: [[ Bug 13827 ]] We need to pass the parameter as a UTF-8 string
+		t_app_spec = [s_simulator_proxy specifierWithApplicationPath: [NSString stringWithUTF8String:t_app.buffer]];
 		
 		t_session_config = [s_simulator_proxy newSessionConfig];
 		

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Can't use double-byte characters for a standalone name`