[[ Cleanup ]] Provide virtual destructors for all classes that may be deleted.

peter-b · peter-b · commit e4fa62fc4731 · 2014-12-30T16:29:25.000Z
diff --git a/engine/src/customprinter.cpp b/engine/src/customprinter.cpp
@@ -1680,6 +1680,8 @@ class MCLoggingPrintingDevice: public MCCustomPrintingDevice
 		m_target = p_target;
 	}
 
+	virtual ~MCLoggingPrintingDevice(void) {}
+
 	////////
 
 	void Destroy(void)
@@ -1824,6 +1826,8 @@ class MCDebugPrintingDevice: public MCCustomPrintingDevice
 		m_stream = nil;
 	}
 
+	virtual ~MCDebugPrintingDevice(void) {}
+
 	void Destroy(void)
 	{
 		delete this;
diff --git a/engine/src/edittool.h b/engine/src/edittool.h
@@ -33,6 +33,7 @@ class MCGraphic;
 class MCEditTool
 {
 public:
+	virtual ~MCEditTool(void) {};
 	virtual bool mdown(int2 x, int2 y, uint2 which) = 0;
 	virtual bool mfocus(int2 x, int2 y) = 0;
 	virtual bool mup(int2 x, int2 y, uint2 which) = 0;
diff --git a/engine/src/lnxflst.h b/engine/src/lnxflst.h
@@ -29,6 +29,7 @@ along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
 class MCFontlist
 {
 public:
+	virtual ~MCFontlist(void) {};
 	virtual void destroy(void) = 0;
 
 	virtual MCFontStruct *getfont(MCNameRef fname, uint2 &size, uint2 style, Boolean printer) = 0;
diff --git a/engine/src/mctheme.h b/engine/src/mctheme.h
@@ -236,6 +236,7 @@ MCWidgetTabPaneInfo;
 class MCTheme //base class for all widgets
 {
 public:
+	virtual ~MCTheme(void) {};
 	virtual Boolean load();
 	virtual void unload();
 
diff --git a/engine/src/printer.h b/engine/src/printer.h
@@ -55,6 +55,8 @@ enum MCPrinterLinkType
 class MCPrinterDevice
 {
 public:
+	virtual ~MCPrinterDevice(void) {};
+
 	// Return a descriptive string of the last printer error that occured. This
 	// call should return NULL if ERROR has not been returned by any method of
 	// the object.
diff --git a/engine/src/transfer.h b/engine/src/transfer.h
@@ -201,6 +201,9 @@ class MCPasteboard
 	//
 	// virtual bool QuerySystem(const char**& r_system_types, unsigned int& r_system_type_count) = 0;
 	// virtual bool FetchSystem(const char *p_system_type, MCSharedString*& r_data) = 0;
+
+protected:
+	virtual ~MCPasteboard(void) {};
 };
 
 
@@ -248,7 +251,7 @@ class MCLocalPasteboard: public MCPasteboard
 
 private:
 	// Destroy the object.
-	~MCLocalPasteboard(void);
+	virtual ~MCLocalPasteboard(void);
 
 	// Search for the given type on the pasteboard and return the index.
 	// If the type is not found, false is returned.

Original file line number	Diff line number	Diff line change
`@@ -1680,6 +1680,8 @@ class MCLoggingPrintingDevice: public MCCustomPrintingDevice`
`1680`	`1680`	`m_target = p_target;`
`1681`	`1681`	`}`
`1682`	`1682`
	`1683`	`+ virtual ~MCLoggingPrintingDevice(void) {}`
	`1684`	`+`
`1683`	`1685`	`////////`
`1684`	`1686`
`1685`	`1687`	`void Destroy(void)`
`@@ -1824,6 +1826,8 @@ class MCDebugPrintingDevice: public MCCustomPrintingDevice`
`1824`	`1826`	`m_stream = nil;`
`1825`	`1827`	`}`
`1826`	`1828`
	`1829`	`+ virtual ~MCDebugPrintingDevice(void) {}`
	`1830`	`+`
`1827`	`1831`	`void Destroy(void)`
`1828`	`1832`	`{`
`1829`	`1833`	`delete this;`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ class MCGraphic;`
`33`	`33`	`class MCEditTool`
`34`	`34`	`{`
`35`	`35`	`public:`
	`36`	`+ virtual ~MCEditTool(void) {};`
`36`	`37`	`virtual bool mdown(int2 x, int2 y, uint2 which) = 0;`
`37`	`38`	`virtual bool mfocus(int2 x, int2 y) = 0;`
`38`	`39`	`virtual bool mup(int2 x, int2 y, uint2 which) = 0;`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ along with LiveCode. If not see <http://www.gnu.org/licenses/>. */`
`29`	`29`	`class MCFontlist`
`30`	`30`	`{`
`31`	`31`	`public:`
	`32`	`+ virtual ~MCFontlist(void) {};`
`32`	`33`	`virtual void destroy(void) = 0;`
`33`	`34`
`34`	`35`	`virtual MCFontStruct *getfont(MCNameRef fname, uint2 &size, uint2 style, Boolean printer) = 0;`
Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,7 @@ MCWidgetTabPaneInfo;`
`236`	`236`	`class MCTheme //base class for all widgets`
`237`	`237`	`{`
`238`	`238`	`public:`
	`239`	`+ virtual ~MCTheme(void) {};`
`239`	`240`	`virtual Boolean load();`
`240`	`241`	`virtual void unload();`
`241`	`242`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,8 @@ enum MCPrinterLinkType`
`55`	`55`	`class MCPrinterDevice`
`56`	`56`	`{`
`57`	`57`	`public:`
	`58`	`+ virtual ~MCPrinterDevice(void) {};`
	`59`	`+`
`58`	`60`	`// Return a descriptive string of the last printer error that occured. This`
`59`	`61`	`// call should return NULL if ERROR has not been returned by any method of`
`60`	`62`	`// the object.`